[GitHub] spark pull request #17594: Write the log first to fix a race contion in test...

2017-04-10 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/17594 Write the log first to fix a race contion in tests ## What changes were proposed in this pull request? This PR fixes the following failure: ``` sbt.ForkMain$ForkError: org.scalatest

[GitHub] spark issue #17568: [SPARK-20254][SQL] Remove unnecessary data conversion fo...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17568 **[Test build #75669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75669/testReport)** for PR 17568 at commit [`3be368c`](https://github.com/apache/spark/commit/3b

[GitHub] spark issue #17582: [SPARK-20239][Core] Improve HistoryServer's ACL mechanis...

2017-04-10 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17582 > user configured with "spark.admin.acls" (or group) or "spark.ui.view.acls" (or group), or the user who started SHS could list all the applications, otherwise none of them can be listed So

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75664/ Test PASSed. ---

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17330 **[Test build #75664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75664/testReport)** for PR 17330 at commit [`f1e63c8`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17591 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17591 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75665/ Test PASSed. ---

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17591 **[Test build #75665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75665/testReport)** for PR 17591 at commit [`e02fc4a`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #17495: [SPARK-20172][Core] Add file permission check whe...

2017-04-10 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17495#discussion_r110721933 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -571,6 +572,34 @@ class FsHistoryProviderSuite extends Spa

[GitHub] spark pull request #17495: [SPARK-20172][Core] Add file permission check whe...

2017-04-10 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17495#discussion_r110722790 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -320,14 +321,15 @@ private[history] class FsHistoryProvider(conf

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17592 Should this go into branch-2.1 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark issue #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPredicates ...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17520 **[Test build #75668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75668/testReport)** for PR 17520 at commit [`b923bd5`](https://github.com/apache/spark/commit/b9

[GitHub] spark pull request #16774: [SPARK-19357][ML] Adding parallel model evaluatio...

2017-04-10 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/16774#discussion_r110717717 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0") (@Since("1.4.0"

[GitHub] spark pull request #17480: [SPARK-20079][Core][yarn] Re registration of AM h...

2017-04-10 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17480#discussion_r110716862 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -249,7 +249,14 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "...

2017-04-10 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17436#discussion_r110714213 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -67,6 +67,9 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging wit

[GitHub] spark pull request #16774: [SPARK-19357][ML] Adding parallel model evaluatio...

2017-04-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/16774#discussion_r110713910 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -100,31 +108,60 @@ class CrossValidator @Since("1.2.0") (@Since("1

[GitHub] spark pull request #16774: [SPARK-19357][ML] Adding parallel model evaluatio...

2017-04-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/16774#discussion_r110712166 --- Diff: docs/ml-tuning.md --- @@ -55,6 +55,9 @@ for multiclass problems. The default metric used to choose the best `ParamMap` c method in each o

[GitHub] spark issue #17550: [SPARK-20240][SQL] SparkSQL support limitations of max d...

2017-04-10 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17550 We do not add the new things into 1.6 branch. Please open the PR using the master branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17077 **[Test build #75667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75667/testReport)** for PR 17077 at commit [`71c9e0f`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17077 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75667/ Test PASSed. ---

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17077 **[Test build #75667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75667/testReport)** for PR 17077 at commit [`71c9e0f`](https://github.com/apache/spark/commit/71

[GitHub] spark issue #17364: [SPARK-20038] [SQL]: FileFormatWriter.ExecuteWriteTask.r...

2017-04-10 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/17364 @squito Is this ready to go in? Like I warned, I'm not going to add tests for this, not on its own --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for...

2017-04-10 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17077#discussion_r110699779 --- Diff: python/pyspark/sql/tests.py --- @@ -2167,6 +2167,61 @@ def test_BinaryType_serialization(self): df = self.spark.createDataFrame(data,

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17077 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17077 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75666/ Test FAILed. ---

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17077 **[Test build #75666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75666/testReport)** for PR 17077 at commit [`481416d`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for bucket...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17077 **[Test build #75666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75666/testReport)** for PR 17077 at commit [`481416d`](https://github.com/apache/spark/commit/48

[GitHub] spark pull request #17585: [SPARK-20273] [SQL] Disallow Non-deterministic Fi...

2017-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17591 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17591 **[Test build #75665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75665/testReport)** for PR 17591 at commit [`e02fc4a`](https://github.com/apache/spark/commit/e0

[GitHub] spark issue #12823: [SPARK-14985][ML] Update LinearRegression, LogisticRegre...

2017-04-10 Thread BenFradet
Github user BenFradet commented on the issue: https://github.com/apache/spark/pull/12823 ping @jkbradley if you could take a look, that'd be great. If you have the time, there is also the #17431 segue. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17330 **[Test build #75664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75664/testReport)** for PR 17330 at commit [`f1e63c8`](https://github.com/apache/spark/commit/f1

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-10 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17587 @cloud-fan Good to see what plan is generated in your comment. People (especially I) will forgot what plan we generated in the future. When I saw the comment in `upCastToExpectedType`, I understoo

[GitHub] spark pull request #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for...

2017-04-10 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17077#discussion_r110693499 --- Diff: python/pyspark/sql/tests.py --- @@ -2167,6 +2167,61 @@ def test_BinaryType_serialization(self): df = self.spark.createDataFrame(data,

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-10 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110693397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -59,6 +58,13 @@ abstract class SubqueryExpression

[GitHub] spark pull request #17077: [SPARK-16931][PYTHON][SQL] Add Python wrapper for...

2017-04-10 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17077#discussion_r110692936 --- Diff: python/pyspark/sql/tests.py --- @@ -2167,6 +2167,61 @@ def test_BinaryType_serialization(self): df = self.spark.createDataFrame(data,

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110692833 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,27 +94,46 @@ private class SharedInMemoryC

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110692271 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,27 +94,46 @@ private class SharedInMemoryC

[GitHub] spark pull request #17566: [SPARK-19518][SQL] IGNORE NULLS in first / last i...

2017-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110692150 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala --- @@ -220,6 +221,32 @@ class FileIndexSuite extends

[GitHub] spark issue #17593: [SPARK-20279][WEB-UI]In web ui,'Only showing 200' should...

2017-04-10 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/17593 I agree with @srowen we left it that way since sorting can change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #17566: [SPARK-19518][SQL] IGNORE NULLS in first / last in SQL

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17566 LGTM - merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpen...

2017-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17592 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17592 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17592 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75662/ Test PASSed. ---

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17592 **[Test build #75662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75662/testReport)** for PR 17592 at commit [`d486d60`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #17308: [SPARK-19968][SS] Use a cached instance of `Kafka...

2017-04-10 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17308#discussion_r110685760 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to

[GitHub] spark issue #17491: [SPARK-20175][SQL] Exists should not be evaluated in Joi...

2017-04-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17491 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17591 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75663/ Test PASSed. ---

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17591 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17591 **[Test build #75663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75663/testReport)** for PR 17591 at commit [`ef8e9e9`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17592 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75661/ Test PASSed. ---

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17592 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17592 **[Test build #75661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75661/testReport)** for PR 17592 at commit [`19ca5a1`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #17587: [SPARK-20274][SQL] support compatible array eleme...

2017-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17587#discussion_r110676717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -270,12 +270,13 @@ object ScalaReflection extends ScalaRefl

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17587 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110671916 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110671813 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -59,6 +58,13 @@ abstract class SubqueryExpression(

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110671334 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -59,6 +58,13 @@ abstract class SubqueryExpression(

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110671100 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17330: [SPARK-19993][SQL] Caching logical plans containi...

2017-04-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17330#discussion_r110671091 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala --- @@ -236,6 +244,12 @@ case class ScalarSubquery(

[GitHub] spark issue #17587: [SPARK-20274][SQL] support compatible array element type...

2017-04-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17587 @kiszk The plan may not be very helpful, as the only difference in the plan is `MapObjects.lambdaFunction`, before it was just `LambdaVariable`, but now it's `Cast(LambdaVariable, xxx)` --- If y

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110669561 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110667171 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17591 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75660/ Test PASSed. ---

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17591 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17591 **[Test build #75660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75660/testReport)** for PR 17591 at commit [`f4ae52a`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110664282 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala --- @@ -360,6 +360,55 @@ class PrefixSpanSuite extends SparkFunSuite with MLl

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17527 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75657/ Test PASSed. ---

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17527 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17527: [SPARK-20156][CORE][SQL][STREAMING][MLLIB] Java String t...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17527 **[Test build #75657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75657/testReport)** for PR 17527 at commit [`2ac5843`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110662589 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala --- @@ -360,6 +360,55 @@ class PrefixSpanSuite extends SparkFunSuite with MLl

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110662506 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110662332 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110662125 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110661717 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark pull request #17575: [SPARK-20265][MLlib] Improve Prefix'span pre-proc...

2017-04-10 Thread Syrux
Github user Syrux commented on a diff in the pull request: https://github.com/apache/spark/pull/17575#discussion_r110661386 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala --- @@ -232,6 +200,68 @@ class PrefixSpan private ( object PrefixSpan extends

[GitHub] spark issue #17582: [SPARK-20239][Core] Improve HistoryServer's ACL mechanis...

2017-04-10 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/17582 Sorry but I'm confused by the explanation in the description. I didn't completely follow what problems you are seeing that aren't intended and I don't understand how you are proposing to fix. Ca

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75654/ Test PASSed. ---

[GitHub] spark issue #17330: [SPARK-19993][SQL] Caching logical plans containing subq...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17330 **[Test build #75654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75654/testReport)** for PR 17330 at commit [`22db44a`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17556 **[Test build #3655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3655/testReport)** for PR 17556 at commit [`9ca5750`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread bogdanrdc
Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110646607 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,13 +94,25 @@ private class SharedInMemoryCa

[GitHub] spark issue #17591: [SPARK-20280][CORE] FileStatusCache Weigher integer over...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17591 **[Test build #75663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75663/testReport)** for PR 17591 at commit [`ef8e9e9`](https://github.com/apache/spark/commit/ef

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17592 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17592 **[Test build #75662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75662/testReport)** for PR 17592 at commit [`d486d60`](https://github.com/apache/spark/commit/d4

[GitHub] spark issue #17556: [SPARK-16957][MLlib] Use weighted midpoints for split va...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17556 **[Test build #3655 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3655/testReport)** for PR 17556 at commit [`9ca5750`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #17593: [SPARK-20279][WEB-UI]In web ui,'Only showing 200' should...

2017-04-10 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17593 I'm not sure this is accurate, given how sort order can be changed? maybe not, but it's at least ambiguous, and don't think it adds enough to change this. --- If your project is set up for it, you c

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110642316 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,13 +94,25 @@ private class SharedInMemoryCache

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread bogdanrdc
Github user bogdanrdc commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110639886 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,13 +94,25 @@ private class SharedInMemoryCa

[GitHub] spark pull request #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpen...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17592#discussion_r110639779 --- Diff: core/src/test/scala/org/apache/spark/DebugFilesystem.scala --- @@ -31,21 +30,29 @@ import org.apache.spark.internal.Logging object DebugF

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110639538 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,13 +94,25 @@ private class SharedInMemoryCache

[GitHub] spark issue #17593: [SPARK-20279][WEB-UI]In web ui,'Only showing 200' should...

2017-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17593 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #17591: [SPARK-20280][CORE] FileStatusCache Weigher integ...

2017-04-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17591#discussion_r110638961 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala --- @@ -94,13 +94,25 @@ private class SharedInMemoryCache

[GitHub] spark pull request #17593: [SPARK-20279][WEB-UI]In web ui,'Only showing 200'...

2017-04-10 Thread guoxiaolongzte
GitHub user guoxiaolongzte opened a pull request: https://github.com/apache/spark/pull/17593 [SPARK-20279][WEB-UI]In web ui,'Only showing 200' should be changed to 'only showing last 200'. ## What changes were proposed in this pull request? In web ui,'Only showing 200' shou

[GitHub] spark issue #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams...

2017-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17592 **[Test build #75661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75661/testReport)** for PR 17592 at commit [`19ca5a1`](https://github.com/apache/spark/commit/19

[GitHub] spark pull request #17592: [SPARK-20243][TESTS] DebugFilesystem.assertNoOpen...

2017-04-10 Thread bogdanrdc
GitHub user bogdanrdc opened a pull request: https://github.com/apache/spark/pull/17592 [SPARK-20243][TESTS] DebugFilesystem.assertNoOpenStreams thread race ## What changes were proposed in this pull request? Synchronize access to openStreams map. ## How was this pa

<    1   2   3   4   5   >