[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18258 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77866/ Test PASSed. ---

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18258 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18258 **[Test build #77866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77866/testReport)** for PR 18258 at commit [`e4cfe1c`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #16986: [SPARK-18891][SQL] Support for Scala Map collection type...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16986 ping @michalsenkyr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18009: [SPARK-18891][SQL] Support for specific Java List subtyp...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18009 ping @michalsenkyr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18258 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18258 If there is no regression, I'd remove the flag. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Add `alterTableStats` to store spark...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18248 LGTM except one minor comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18248: [SPARK-21031] [SQL] Add `alterTableStats` to stor...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18248#discussion_r121250769 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -614,9 +594,11 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Add `alterTableStats` to store spark...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18248 **[Test build #77868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77868/testReport)** for PR 18248 at commit [`38d03d7`](https://github.com/apache/spark/commit/38

[GitHub] spark pull request #18248: [SPARK-21031] [SQL] Add `alterTableStats` to stor...

2017-06-09 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18248#discussion_r121250467 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -313,60 +313,70 @@ class StatisticsSuite extends StatisticsCollectio

[GitHub] spark issue #18257: [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalidRange o...

2017-06-09 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/18257 The end result looks good to me. Thanks for fixing it! Although, I'd prefer fixing the actual integer overflow handling in `RangeExec`'s codegen, too. Even though your fix will handle th

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18248 **[Test build #77867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77867/testReport)** for PR 18248 at commit [`2649135`](https://github.com/apache/spark/commit/26

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18258 Sure. Three times for each. Track = F: Aggregate w keys:Best/Avg Time(ms)Rate(M/s) Per Row(ns) Relative -

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18258 Can you run it a few more times to tell? Right now it's a difference of 7% almost --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18258 Is it significant? Seems to me that it's in the variance of different runs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18258 16.8 vs 15.8? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18258 I just ran the existing `AggregateBenchmark` with the new tracking config: Java HotSpot(TM) 64-Bit Server VM 1.8.0_102-b14 on Linux 4.9.27-moby Intel(R) Core(TM) i7-5557U CPU @ 3.1

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18258 Sure. Will update later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18258 Can you test the perf degradation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18258 The `enablePerfMetrics` parameter of `UnsafeFixedWidthAggregationMap` has this comment: * @param enablePerfMetrics if true, performance metrics will be recorded (has minor perf impact)

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18248 @cloud-fan Oh, right, let me try. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18258 Why would the tracking have perf impact? It's just a simple counter increase isn't it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #18257: [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalidRange o...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to aggregat...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18258 **[Test build #77866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77866/testReport)** for PR 18258 at commit [`e4cfe1c`](https://github.com/apache/spark/commit/e4

[GitHub] spark issue #18257: [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalidRange o...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77865/ Test PASSed. ---

[GitHub] spark issue #18257: [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalidRange o...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18257 **[Test build #77865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77865/testReport)** for PR 18257 at commit [`6ab9b6f`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #18258: [SPARK-20953][SQL][WIP] Add hash map metrics to a...

2017-06-09 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18258 [SPARK-20953][SQL][WIP] Add hash map metrics to aggregate ## What changes were proposed in this pull request? This adds the average hash map probe metrics to hash aggregate. A new c

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18150 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18150 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77864/ Test PASSed. ---

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18150 **[Test build #77864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77864/testReport)** for PR 18150 at commit [`78bce79`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18248 `alterTable` can read states from the old table and keep it: https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L564

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18248 I mean how can we keep existing stats? Since we cannot tell whether it's from hive or spark, if we store it as spark's stats, then we come back to the problem. If we don't, then we lost stats if it's

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18248 @cloud-fan How can we tell in `alterTable` whether it's new stats or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18248 `alterTable` won't set new stats but can still keep existing states, can we implement this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18248 @cloud-fan Actually that is my first version. It also has problems: if we generate spark's stats first (through analyze command and `alterTableStats`), then do a regular alter table command, the s

[GitHub] spark issue #18209: [SPARK-20992][Scheduler] Add support for Nomad as a sche...

2017-06-09 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/18209 Given that at Facebook we use our own in-house scheduler, I see why people would want to see their scheduler impls added right in Spark codebase as a first class citizen. Like @srowen said, this

[GitHub] spark issue #18244: [SPARK-20211][SQL] Fix the Precision and Scale of Decima...

2017-06-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18244 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark issue #18251: [SPARK-21033][SQL] fix the potential OOM in UnsafeExtern...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18251 also cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18248 I think the real issue is that, we mistakenly add statistics in `ALTER TABLE`. This is because `ExternalCatalog.alterTable` is heavily used when we wanna change something for a table. I think it w

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18231 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77862/ Test PASSed. ---

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18231 **[Test build #77862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77862/testReport)** for PR 18231 at commit [`5dd0e77`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #18257: [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalidRange o...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18257 **[Test build #77865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77865/testReport)** for PR 18257 at commit [`6ab9b6f`](https://github.com/apache/spark/commit/6a

[GitHub] spark pull request #18257: [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalid...

2017-06-09 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/18257 [SPARK-21044][SPARK-21041][SQL] Add RemoveInvalidRange optimizer ## What changes were proposed in this pull request? This PR aims to add an optimizer remove invalid `Range` operators

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18231 **[Test build #77863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77863/testReport)** for PR 18231 at commit [`1e72eab`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18231 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77863/ Test FAILed. ---

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18231 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18209: [SPARK-20992][Scheduler] Add support for Nomad as a sche...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18209 The next one to add is probably Kubernetes. Even the Spark on Kubernetes is going through this cycle of maintaining a separate project for it first. --- If your project is set up for it, you can repl

[GitHub] spark issue #18228: [SPARK-21007][SQL]Add SQL function - RIGHT && LEFT

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18228 Are these ANSI SQL functions? If it is just some esoteric MySQL function I don't think we should add them. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18236 Why do we want this check? If the user passes in null value, it is ok if it is not found, isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request #18252: [SPARK-17914][SQL] Fix parsing of timestamp strin...

2017-06-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18252#discussion_r121246583 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -32,7 +32,7 @@ import org.apache.spark.unsafe.types.UTF8St

[GitHub] spark pull request #18256: [SPARK-21042][SQL] Document Dataset.union is reso...

2017-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18256 Merging in master/branch-2.2. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18256 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18256 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77861/ Test PASSed. ---

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18256 **[Test build #77861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77861/testReport)** for PR 18256 at commit [`b464adb`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18150 **[Test build #77864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77864/testReport)** for PR 18150 at commit [`78bce79`](https://github.com/apache/spark/commit/78

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18150 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77859/ Test FAILed. ---

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18150 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18150 **[Test build #77859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77859/testReport)** for PR 18150 at commit [`ec89ac1`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18248 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18248 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77860/ Test FAILed. ---

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18248 **[Test build #77860 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77860/testReport)** for PR 18248 at commit [`835b6f2`](https://github.com/apache/spark/commit/8

[GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...

2017-06-09 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/12646#discussion_r121244808 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2651,4 +2652,28 @@ class SQLQuerySuite extends QueryTest with SharedSQLCon

[GitHub] spark issue #18238: [SPARK-21016][core]Improve code fault tolerance for conv...

2017-06-09 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/18238 If a string has a leading or trailing space, it's expected it cannot be converted to a number. Java's string type also follows this convention. --- If your project is set up for it, you can reply

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18231 @vanzin Thanks again for comments :) I refined accordingly, please take another look when you have time. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #18231: [SPARK-20994] Remove reduant characters in OpenBl...

2017-06-09 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r121242495 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private Shuffle

[GitHub] spark issue #18231: [SPARK-20994] Remove reduant characters in OpenBlocks to...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18231 **[Test build #77863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77863/testReport)** for PR 18231 at commit [`1e72eab`](https://github.com/apache/spark/commit/1e

[GitHub] spark issue #18231: [WIP][SPARK-20994] Remove reduant characters in OpenBloc...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18231 **[Test build #77862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77862/testReport)** for PR 18231 at commit [`5dd0e77`](https://github.com/apache/spark/commit/5d

[GitHub] spark pull request #18231: [WIP][SPARK-20994] Remove reduant characters in O...

2017-06-09 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r121241362 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private Shuffle

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-09 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/18199 Left one last comment. Otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request #18199: [SPARK-20979][SS]Add RateSource to generate value...

2017-06-09 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18199#discussion_r121240973 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceSuite.scala --- @@ -0,0 +1,179 @@ +/* + * Licensed to the Apach

[GitHub] spark pull request #18252: [SPARK-17914][SQL] Fix parsing of timestamp strin...

2017-06-09 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18252#discussion_r121240900 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -399,13 +399,13 @@ object DateTimeUtils { digi

[GitHub] spark issue #18255: [SPARK-21038][SQL] Reduce redundant generated init code ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18255 **[Test build #3788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3788/testReport)** for PR 18255 at commit [`de9ce5b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77858/ Test PASSed. ---

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18199: [SPARK-20979][SS]Add RateSource to generate values for t...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18199 **[Test build #77858 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77858/testReport)** for PR 18199 at commit [`d5e7492`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18150 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18150 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77856/ Test PASSed. ---

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18256 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] spark issue #18150: [SPARK-19753][CORE] Un-register all shuffle output on a ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18150 **[Test build #77856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77856/testReport)** for PR 18150 at commit [`810a101`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18256 Thanks! LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark issue #18256: [SPARK-21042][SQL] Document Dataset.union is resolution ...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18256 **[Test build #77861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77861/testReport)** for PR 18256 at commit [`b464adb`](https://github.com/apache/spark/commit/b4

[GitHub] spark pull request #18256: [SPARK-21042][SQL] Document Dataset.union is reso...

2017-06-09 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/18256 [SPARK-21042][SQL] Document Dataset.union is resolution by position ## What changes were proposed in this pull request? Document Dataset.union is resolution by position, not by name, since this ha

[GitHub] spark pull request #17180: [SPARK-19839][Core]release longArray in BytesToBy...

2017-06-09 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/17180#discussion_r121238154 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -358,10 +358,20 @@ public long spill(long numBytes) throws IOExceptio

[GitHub] spark pull request #18231: [WIP][SPARK-20994] Remove reduant characters in O...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r121237553 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private ShuffleMet

[GitHub] spark pull request #18231: [WIP][SPARK-20994] Remove reduant characters in O...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r121237684 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,52 @@ private ShuffleMet

[GitHub] spark pull request #18231: [WIP][SPARK-20994] Remove reduant characters in O...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18231#discussion_r121237874 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -209,4 +190,51 @@ private ShuffleMet

[GitHub] spark pull request #17180: [SPARK-19839][Core]release longArray in BytesToBy...

2017-06-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17180#discussion_r121237843 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -358,10 +358,20 @@ public long spill(long numBytes) throws IOExceptio

[GitHub] spark issue #18252: [SPARK-17914][SQL] Fix parsing of timestamp strings with...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77857/ Test PASSed. ---

[GitHub] spark issue #18252: [SPARK-17914][SQL] Fix parsing of timestamp strings with...

2017-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18252: [SPARK-17914][SQL] Fix parsing of timestamp strings with...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18252 **[Test build #77857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77857/testReport)** for PR 18252 at commit [`4d057c9`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18248: [SPARK-21031] [SQL] Clearly separate spark's stats and h...

2017-06-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18248 **[Test build #77860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77860/testReport)** for PR 18248 at commit [`835b6f2`](https://github.com/apache/spark/commit/83

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r121235695 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala --- @@ -0,0 +1,84 @@ +/*

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r121235739 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala --- @@ -0,0 +1,84 @@ +/*

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r121235242 --- Diff: core/pom.xml --- @@ -357,6 +357,34 @@ org.apache.commons commons-crypto + +

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r121235790 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala --- @@ -0,0 +1,84 @@ +/*

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r121235520 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HiveCredentialProvider.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Sof

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r121235405 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HadoopFSCredentialProvider.scala --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

  1   2   3   >