[GitHub] spark pull request #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17848#discussion_r127635707 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -103,4 +110,19 @@ case class UserDefinedFunction

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79651/ Test PASSed. ---

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18580 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18580 **[Test build #79651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79651/testReport)** for PR 18580 at commit

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18580 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18555 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18555 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79650/ Test PASSed. ---

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18555 **[Test build #79650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79650/testReport)** for PR 18555 at commit

[GitHub] spark issue #17848: [SPARK-20586] [SQL] Add deterministic to ScalaUDF and Ja...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17848 **[Test build #79658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79658/testReport)** for PR 17848 at commit

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18649 **[Test build #79657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79657/testReport)** for PR 18649 at commit

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18649 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18649 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79657/ Test FAILed. ---

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18649 **[Test build #79657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79657/testReport)** for PR 18649 at commit

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18649 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18628: [SPARK-18061][ThriftServer] Add spnego auth support for ...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18628 looks good according to the existing similar code, but I'm not very familiar with this part code of code, will leave it for a few days if someone else has some comments. Also cc

[GitHub] spark pull request #18628: [SPARK-18061][ThriftServer] Add spnego auth suppo...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18628#discussion_r127631011 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala --- @@ -57,6 +59,20 @@ private[hive]

[GitHub] spark issue #18631: [SPARK-21410][CORE] Create less partitions for RangePart...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18631 **[Test build #79656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79656/testReport)** for PR 18631 at commit

[GitHub] spark issue #18631: [SPARK-21410][CORE] Create less partitions for RangePart...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18631 cc @srowen is it ok to do this? e.g. `rdd.sortByKey(numPartitions = 10)`, do we have to return an RDD of 10 partitions even some of them are empty? --- If your project is set up for it, you can

[GitHub] spark issue #18631: [SPARK-21410][CORE] Create less partitions for RangePart...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18631 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18612: [SPARK-21388][ML][PySpark] GBTs inherit from HasStepSize...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18612 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79652/ Test PASSed. ---

[GitHub] spark issue #18612: [SPARK-21388][ML][PySpark] GBTs inherit from HasStepSize...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18612 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18612: [SPARK-21388][ML][PySpark] GBTs inherit from HasStepSize...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18612 **[Test build #79652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79652/testReport)** for PR 18612 at commit

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18615 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18615 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79654/ Test PASSed. ---

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18615 **[Test build #79654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79654/testReport)** for PR 18615 at commit

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18615 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79653/ Test PASSed. ---

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18615 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18615 **[Test build #79653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79653/testReport)** for PR 18615 at commit

[GitHub] spark issue #18624: [SPARK-21389][ML][MLLIB] Optimize ALS recommendForAll by...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18624 **[Test build #79655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79655/testReport)** for PR 18624 at commit

[GitHub] spark issue #18624: [SPARK-21389][ML][MLLIB] Optimize ALS recommendForAll by...

2017-07-16 Thread mpjlu
Github user mpjlu commented on the issue: https://github.com/apache/spark/pull/18624 I have checked the results with the master method, the recommendation results are right. The master TestSuite is too simple, should be updated. I will update it. Thanks. --- If your

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18615 **[Test build #79654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79654/testReport)** for PR 18615 at commit

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18615 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving callable obj...

2017-07-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18615 Thanks @viirya. @holdenk, I happened to find another issue and tried to fix both here together. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #18615: [SPARK-21394][SPARK-21432][PYTHON] Reviving calla...

2017-07-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18615#discussion_r127627470 --- Diff: python/pyspark/sql/functions.py --- @@ -2087,10 +2087,22 @@ def _wrapped(self): """ Wrap this udf with a function and

[GitHub] spark issue #18615: [SPARK-21394][PYTHON] Reviving callable object support i...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18615 **[Test build #79653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79653/testReport)** for PR 18615 at commit

[GitHub] spark issue #18612: [SPARK-21388][ML][PySpark] GBTs inherit from HasStepSize...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18612 **[Test build #79652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79652/testReport)** for PR 18612 at commit

[GitHub] spark pull request #18641: [SPARK-21413][SQL] Fix 64KB JVM bytecode limit pr...

2017-07-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18641#discussion_r127626187 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -273,12 +274,31 @@ case class

[GitHub] spark pull request #18641: [SPARK-21413][SQL] Fix 64KB JVM bytecode limit pr...

2017-07-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18641#discussion_r127626045 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -72,11 +72,11 @@ case class

[GitHub] spark pull request #18641: [SPARK-21413][SQL] Fix 64KB JVM bytecode limit pr...

2017-07-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18641#discussion_r127625999 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -72,11 +72,11 @@ case class

[GitHub] spark pull request #18641: [SPARK-21413][SQL] Fix 64KB JVM bytecode limit pr...

2017-07-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18641#discussion_r127625968 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -273,12 +274,31 @@ case class

[GitHub] spark pull request #18580: [SPARK-21354] [SQL] INPUT FILE related functions ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18580#discussion_r127625865 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala --- @@ -409,6 +409,42 @@ object HiveOnlyCheck extends

[GitHub] spark issue #18580: [SPARK-21354] [SQL] INPUT FILE related functions do not ...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18580 **[Test build #79651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79651/testReport)** for PR 18580 at commit

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13599 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79649/ Test PASSed. ---

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #79649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79649/testReport)** for PR 13599 at commit

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18555 **[Test build #79650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79650/testReport)** for PR 18555 at commit

[GitHub] spark pull request #18646: [SPARK-19810][MINOR][FOLLOW-UP] Follow-ups from S...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18646: [SPARK-19810][MINOR][FOLLOW-UP] Follow-ups from SPARK-19...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18646 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18580: [SPARK-21354] [SQL] INPUT FILE related functions ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18580#discussion_r127621186 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -74,6 +74,15 @@ trait CheckAnalysis extends

[GitHub] spark issue #13599: [SPARK-13587] [PYSPARK] Support virtualenv in pyspark

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13599 **[Test build #79649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79649/testReport)** for PR 13599 at commit

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread debugger87
Github user debugger87 commented on the issue: https://github.com/apache/spark/pull/18649 @cloud-fan Could you please help me to review this PR? Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't r...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18649 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18649: [SPARK-21395][SQL] Spark SQL hive-thriftserver do...

2017-07-16 Thread debugger87
GitHub user debugger87 opened a pull request: https://github.com/apache/spark/pull/18649 [SPARK-21395][SQL] Spark SQL hive-thriftserver doesn't register operation log before execute sql statement ## What changes were proposed in this pull request? - Add a private method

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127614336 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127614328 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for stand-alo...

2017-07-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/18630 @jerryshao > Are you trying to support --packages in standalone cluster? Yes that is my intention as stated in the description. I will proceed with the changes thnx for

[GitHub] spark pull request #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for st...

2017-07-16 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/18630#discussion_r127614213 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala --- @@ -66,4 +75,50 @@ object DriverWrapper { System.exit(-1)

[GitHub] spark pull request #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for st...

2017-07-16 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/18630#discussion_r127614182 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala --- @@ -66,4 +75,50 @@ object DriverWrapper { System.exit(-1)

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127614121 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1186,3 +1186,51 @@ case class

[GitHub] spark pull request #18630: [SPARK-12559][SPARK SUBMIT] fix --packages for st...

2017-07-16 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/18630#discussion_r127613972 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -473,6 +474,12 @@ object SparkSubmit extends CommandLineUtils {

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127613839 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala --- @@ -644,4 +645,37 @@ class

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127613829 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127613753 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1186,3 +1186,51 @@ case class

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18323#discussion_r127613668 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1186,3 +1186,51 @@ case class

[GitHub] spark issue #18637: [SPARK-15526][ML][FOLLOWUP][test-maven] Make JPMML provi...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18637 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18637: [SPARK-15526][ML][FOLLOWUP][test-maven] Make JPMML provi...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18637 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79646/ Test PASSed. ---

[GitHub] spark issue #18637: [SPARK-15526][ML][FOLLOWUP][test-maven] Make JPMML provi...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18637 **[Test build #79646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79646/testReport)** for PR 18637 at commit

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18555 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79648/ Test FAILed. ---

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18555 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18555 **[Test build #79648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79648/testReport)** for PR 18555 at commit

[GitHub] spark pull request #18424: [SPARK-17091] Add rule to convert IN predicate to...

2017-07-16 Thread a10y
Github user a10y commented on a diff in the pull request: https://github.com/apache/spark/pull/18424#discussion_r127611976 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -238,6 +238,14 @@ private[parquet] object

[GitHub] spark issue #18646: [SPARK-19810][MINOR][FOLLOW-UP] Follow-ups from SPARK-19...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18646 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79644/ Test PASSed. ---

[GitHub] spark issue #18646: [SPARK-19810][MINOR][FOLLOW-UP] Follow-ups from SPARK-19...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18646 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18646: [SPARK-19810][MINOR][FOLLOW-UP] Follow-ups from SPARK-19...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18646 **[Test build #79644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79644/testReport)** for PR 18646 at commit

[GitHub] spark pull request #18645: [SPARK-14280][BUILD][WIP] Update change-version.s...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18645#discussion_r127611350 --- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala --- @@ -89,6 +89,14 @@ trait FutureAction[T] extends Future[T] { */ override

[GitHub] spark pull request #18645: [SPARK-14280][BUILD][WIP] Update change-version.s...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18645#discussion_r127611390 --- Diff: sql/catalyst/pom.xml --- @@ -39,6 +39,10 @@ org.scala-lang scala-reflect + --- End diff --

[GitHub] spark pull request #18645: [SPARK-14280][BUILD][WIP] Update change-version.s...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18645#discussion_r127611412 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2537,8 +2537,9 @@ class Dataset[T] private[sql]( * @group action

[GitHub] spark pull request #18645: [SPARK-14280][BUILD][WIP] Update change-version.s...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18645#discussion_r127611421 --- Diff: sql/hive/pom.xml --- @@ -59,13 +59,6 @@ org.apache.spark - spark-sql_${scala.binary.version} --- End

[GitHub] spark pull request #18645: [SPARK-14280][BUILD][WIP] Update change-version.s...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18645#discussion_r127611376 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskContextSuite.scala --- @@ -54,7 +54,10 @@ class TaskContextSuite extends SparkFunSuite with

[GitHub] spark pull request #18645: [SPARK-14280][BUILD][WIP] Update change-version.s...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18645#discussion_r127611395 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala --- @@ -339,39 +335,4 @@ class ScalaReflectionSuite extends

[GitHub] spark pull request #18643: [SPARK-21426] [2.0] [SQL] [TEST] Fix test failure...

2017-07-16 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/18643 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #18643: [SPARK-21426] [2.0] [SQL] [TEST] Fix test failure due to...

2017-07-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18643 Thanks! Merging to 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18648: [SPARK-21428] Set IsolatedClientLoader off while using b...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18648 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18648: [SPARK-21428] Set IsolatedClientLoader off while ...

2017-07-16 Thread yaooqinn
GitHub user yaooqinn opened a pull request: https://github.com/apache/spark/pull/18648 [SPARK-21428] Set IsolatedClientLoader off while using builtin Hive jars for reusing CliSessionState ## What changes were proposed in this pull request? Set isolated to false while using

[GitHub] spark issue #18631: [SPARK-SPARK-21410][CORE] RangePartitioner.numPartitions...

2017-07-16 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18631 Please update the title to: ``` [SPARK-21410][CORE] Create less partitions for RangePartitioner if RDD.count() is less than `partitions` ``` --- If your project is set up for it,

[GitHub] spark issue #18631: [SPARK-SPARK-21410][CORE] RangePartitioner.numPartitions...

2017-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18631 Ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18555: [SPARK-21353][CORE]add checkValue in spark.internal.conf...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18555 **[Test build #79648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79648/testReport)** for PR 18555 at commit

[GitHub] spark issue #18647: [MINOR][PYTHON] Remove obsolete codes for parsing abstra...

2017-07-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18647 cc @davies and @joshrosen, I was looking at the first place that introduced this - https://github.com/apache/spark/commit/880eabec37c69ce4e9594d7babfac291b0f93f50. Could you take a look and

[GitHub] spark issue #18647: [MINOR][PYTHON] Remove obsolete codes for parsing abstra...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18647 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18647: [MINOR][PYTHON] Remove obsolete codes for parsing abstra...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18647 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79647/ Test PASSed. ---

[GitHub] spark issue #18647: [MINOR][PYTHON] Remove obsolete codes for parsing abstra...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18647 **[Test build #79647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79647/testReport)** for PR 18647 at commit

[GitHub] spark pull request #18644: case class should be independent

2017-07-16 Thread piyushknoldus
Github user piyushknoldus closed the pull request at: https://github.com/apache/spark/pull/18644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18647: [MINOR][PYTHON] Remove obsolete codes for parsing abstra...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18647 **[Test build #79647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79647/testReport)** for PR 18647 at commit

[GitHub] spark pull request #18647: [MINOR][PYTHON] Remove obsolete codes for parsing...

2017-07-16 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/18647 [MINOR][PYTHON] Remove obsolete codes for parsing abstract schema strings ## What changes were proposed in this pull request? This PR proposes to remove private functions that look not

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18645 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18645 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79645/ Test FAILed. ---

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18645 **[Test build #79645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79645/testReport)** for PR 18645 at commit

[GitHub] spark issue #18637: [SPARK-15526][ML][FOLLOWUP][test-maven] Make JPMML provi...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18637 **[Test build #79646 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79646/testReport)** for PR 18637 at commit

[GitHub] spark pull request #18637: [SPARK-15526][ML][FOLLOWUP][test-maven] Make JPMM...

2017-07-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18637#discussion_r127608414 --- Diff: pom.xml --- @@ -2511,8 +2523,8 @@

[GitHub] spark issue #18645: [SPARK-14280][BUILD][WIP] Update change-version.sh and p...

2017-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18645 **[Test build #79645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79645/testReport)** for PR 18645 at commit

  1   2   >