Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18664#discussion_r147019262
--- Diff: python/pyspark/serializers.py ---
@@ -224,7 +225,13 @@ def _create_batch(series):
# If a nullable integer series has been promoted to float
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147019065
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83059/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19576
**[Test build #83059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83059/testReport)**
for PR 19576 at commit
[`cba65d1`](https://github.com/apache/spark/commit/c
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147018411
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15770
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15770
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83064/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15770
**[Test build #83064 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83064/testReport)**
for PR 15770 at commit
[`752b685`](https://github.com/apache/spark/commit/7
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147017517
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147017011
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147016710
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147016564
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147016230
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147016051
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147015733
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147015669
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147015428
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147015304
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147015064
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147014681
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147014641
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147014608
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147014477
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/config.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the A
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147013787
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19578
**[Test build #83065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83065/testReport)**
for PR 19578 at commit
[`6c6b138`](https://github.com/apache/spark/commit/6c
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19578
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147013219
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15770
**[Test build #83064 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83064/testReport)**
for PR 15770 at commit
[`752b685`](https://github.com/apache/spark/commit/75
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147012530
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19578
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user henryr opened a pull request:
https://github.com/apache/spark/pull/19578
[SPARK-21983][SQL] Fix Antlr 4.7 deprecation warnings
## What changes were proposed in this pull request?
Fix three deprecation warnings introduced by move to ANTLR 4.7:
* Use Parse
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19577
**[Test build #83063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83063/testReport)**
for PR 19577 at commit
[`cecea8c`](https://github.com/apache/spark/commit/ce
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19577
cc @zsxwing @viirya @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19577
[SPARK-22355][SQL] Dataset.collect is not threadsafe
## What changes were proposed in this pull request?
It's possible that users create a `Dataset`, and call `collect` of this
`Dataset`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83056/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83056/testReport)**
for PR 19568 at commit
[`3431778`](https://github.com/apache/spark/commit/3
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/19439
@thunterdb @WeichenXu123 Let's keep only Array[Byte] for now.
@WeichenXu123 for the origin column. Surely it maybe handy in some
scenarios, but I'm most concerned about the object blending an
Github user Whoosh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19553#discussion_r147008530
--- Diff: core/src/test/scala/org/apache/spark/util/JavaUtils.scala ---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user Whoosh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19553#discussion_r147007902
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -43,6 +43,13 @@ private[spark] object JavaUtils {
override def s
Github user Whoosh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19553#discussion_r147006646
--- Diff: core/src/test/scala/org/apache/spark/util/JavaUtils.scala ---
@@ -0,0 +1,37 @@
+/*
--- End diff --
Yep, done.
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83057/
Test FAILed.
---
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147006050
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19468
**[Test build #83057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83057/testReport)**
for PR 19468 at commit
[`2fb596d`](https://github.com/apache/spark/commit/2
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147005308
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r147004943
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r147004514
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Found
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147003383
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r147002808
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147001912
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r147001869
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r147001738
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147001487
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147001175
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147001086
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147000738
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/config.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the A
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147000572
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/config.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the A
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19560
I can see the value and also the potential extra overhead (more expensive
for object stores), although this does not resolve the root cause.
Before we providing adaptive runtime optimiza
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r147000242
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r14609
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r146999753
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146973714
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146989963
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146984527
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146985776
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146964469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/config.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the A
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146972185
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146976161
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146959181
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146974409
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146963731
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/config.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the A
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146973841
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146979869
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146957225
--- Diff: resource-managers/kubernetes/core/pom.xml ---
@@ -0,0 +1,102 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146979317
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146969639
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146980311
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146961172
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146980745
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0 +1,44
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19122
**[Test build #3961 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3961/testReport)**
for PR 19122 at commit
[`93ab39a`](https://github.com/apache/spark/commit/
Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19381#discussion_r146986798
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -267,6 +268,24 @@ class DecisionTreeClassifier
Github user squito commented on the issue:
https://github.com/apache/spark/pull/19383
btw, for any other potential reviews, I'm going already reviewing the rest
of marcelo's commits in this project (the prs against is own repo here:
https://github.com/vanzin/spark/pulls). In general
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19574
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19574
Mergin to master and back to 2.0.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r146994397
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19574
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83051/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19574
**[Test build #83051 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83051/testReport)**
for PR 19574 at commit
[`f393c05`](https://github.com/apache/spark/commit/f
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19531
This PR is only for refactoring? If not, please add the test cases
cc @bogdanrdc @cloud-fan @juliuszsompolski
---
-
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19531#discussion_r146993530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala
---
@@ -157,64 +154,100 @@ case c
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19558
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/19439#discussion_r146992894
--- Diff: python/pyspark/ml/image.py ---
@@ -0,0 +1,122 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# cont
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19558
LGTM
Tested locally, and it fixed the non-determinism.
Merging with master and branch-2.2
Thanks @WeichenXu123 !
---
--
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146989708
--- Diff: docs/running-on-mesos.md ---
@@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146987092
--- Diff: docs/running-on-mesos.md ---
@@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146991701
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +177,88 @@ private[m
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146991758
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -173,6 +177,88 @@ private[m
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r146988600
--- Diff: docs/running-on-mesos.md ---
@@ -485,39 +485,87 @@ See the [configuration page](configuration.html) for
information on Spark config
101 - 200 of 450 matches
Mail list logo
