Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84207 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84207/testReport)**
for PR 19813 at commit
[`9f848be`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84204 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84204/testReport)**
for PR 19607 at commit
[`f92eae3`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84204/
Test FAILed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19813
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84206/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84207/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84205/testReport)**
for PR 19607 at commit
[`40a9735`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19752
**[Test build #84206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84206/testReport)**
for PR 19752 at commit
[`f4c7896`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84209 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84209/testReport)**
for PR 11994 at commit
[`e94def7`](https://github.com/apache/spark/commit/e9
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19823#discussion_r153127637
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2624,7 +2624,13 @@ class SQLQuerySuite extends QueryTest with
SharedSQLC
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19607
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84208 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84208/testReport)**
for PR 19813 at commit
[`9f848be`](https://github.com/apache/spark/commit/9f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84210 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84210/testReport)**
for PR 19607 at commit
[`40a9735`](https://github.com/apache/spark/commit/40
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153130303
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-de
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19757#discussion_r153130613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -366,10 +366,16 @@ case class CatalogStatistics(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84205/
Test FAILed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153130823
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-de
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19823#discussion_r153131202
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -341,6 +341,12 @@ case class LoadDataCommand(
} else
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153131125
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends Spar
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153132348
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-de
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19813
@cloud-fan @kiszk `ctx.currentVars` and `ctx.INPUT_ROW` are not the only
sources for expression evaluation under wholestage codegen. There are also
eliminated subexpressions and the input rows and va
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19823#discussion_r153135417
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -341,6 +341,12 @@ case class LoadDataCommand(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84211 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84211/testReport)**
for PR 19813 at commit
[`57b1add`](https://github.com/apache/spark/commit/57
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19814
Seems like the job died because of jvm internal issue:
> *** glibc detected *** /usr/java/jdk1.8.0_60/bin/java: double free or
corruption (out): 0x000100038720 ***
Is it p
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19814
Yup, seems unrelated. It's fine. Let me back soon with another look.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153137292
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def _me
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153138373
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-de
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153131921
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/BaseDriverConfigurationStep.scala
---
@@ -0,0 +1,161 @@
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153123413
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigurationStepsOrchestrator.scala
---
@@ -0,0 +1,84
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153098283
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/Client.scala
---
@@ -0,0 +1,219 @@
+/*
+ * Licensed t
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153132562
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverKubernetesCredentialsStep.scala
---
@@ -0,0 +1,24
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153093334
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/Client.scala
---
@@ -0,0 +1,219 @@
+/*
+ * Licensed t
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153092633
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -702,6 +715,18 @@ object SparkSubmit extends CommandLineUtils with
Logging {
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153126963
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
---
@@ -0,0 +1,184 @@
+/*
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153093170
--- Diff: resource-managers/kubernetes/core/pom.xml ---
@@ -0,0 +1,102 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153122738
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the A
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19752
**[Test build #84212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84212/testReport)**
for PR 19752 at commit
[`5adb513`](https://github.com/apache/spark/commit/5a
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19821#discussion_r153140836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -785,13 +785,36 @@ class CodegenContext {
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/19388
I agree with @vanzin - this looks very complicated for a enforcing a fairly
simple constraint.
It would be easier to depend on a AtomicInteger in driver for the id - and
propagate that to execut
Github user ferdonline commented on the issue:
https://github.com/apache/spark/pull/19805
Thanks for you review. I'm working on the changes
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19757
**[Test build #84213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84213/testReport)**
for PR 19757 at commit
[`45ab60b`](https://github.com/apache/spark/commit/45
Github user ferdonline commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153145177
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql](
*/
@Experimen
Github user ferdonline commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153147567
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql](
*/
@Experimen
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84208/testReport)**
for PR 19813 at commit
[`9f848be`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84208/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153160307
--- Diff: python/pyspark/sql/tests.py ---
@@ -1722,6 +1723,83 @@ def test_infer_long_type(self):
self.assertEqual(_infer_type(2**61), LongType()
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84211 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84211/testReport)**
for PR 19813 at commit
[`57b1add`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84211/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
GitHub user victor-wong opened a pull request:
https://github.com/apache/spark/pull/19824
Revert "[SPARK-18905][STREAMING] Fix the issue of removing a failed jobset
from JobScheduler.jobSets"
## What changes were proposed in this pull request?
The code changes in PR(https:/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19824
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11994
**[Test build #84209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84209/testReport)**
for PR 11994 at commit
[`e94def7`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84209/
Test PASSed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153168918
--- Diff: python/pyspark/sql/session.py ---
@@ -444,11 +445,30 @@ def _get_numpy_record_dtype(self, rec):
record_type_list.append((str(c
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153167040
--- Diff: python/pyspark/sql/tests.py ---
@@ -3683,6 +3808,47 @@ def check_records_per_batch(x):
else:
self.spark.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153142283
--- Diff: python/pyspark/sql/types.py ---
@@ -1678,37 +1679,105 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153149080
--- Diff: python/pyspark/sql/tests.py ---
@@ -3192,16 +3255,49 @@ def test_filtered_frame(self):
self.assertEqual(pdf.columns[0], "i")
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153142413
--- Diff: python/pyspark/sql/types.py ---
@@ -1678,37 +1679,105 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84210/testReport)**
for PR 19607 at commit
[`40a9735`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84210/
Test PASSed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r153176050
--- Diff: python/pyspark/sql/session.py ---
@@ -444,11 +445,30 @@ def _get_numpy_record_dtype(self, rec):
record_type_list.append((str(c
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153177002
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -158,111 +178,86 @@ abstract class Ca
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153177401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -158,111 +178,86 @@ abstract class Ca
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19823#discussion_r153177645
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -380,6 +380,12 @@ case class LoadDataCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19757#discussion_r153177909
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -29,21 +30,30 @@ class HiveExplainSuite extends Query
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19752
**[Test build #84212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84212/testReport)**
for PR 19752 at commit
[`5adb513`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153178787
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql](
*/
@Experime
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19752
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84212/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19813
`splitExpressions` is the most common way we use in the codegen framework
to deal with large code. If we can't make it work with whole stage codegen, we
are not making many values.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19821
is it really worth? seems not used in many places and eventually the
if-else will be removed after we make `splitExpression` work with whole stage
codegen
---
--
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153181270
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -158,111 +178,86 @@ abstract class Cas
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19390
@vanzin @srowen Can I get a merge pls?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/19823
Thanks for the comments guys, i am working on it.,will update the PR based
on comments.
---
-
To unsubscribe, e-mail: revie
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/19823
Basically this validation stands good for both cases where scheme can come
as null and not null, i will update the logic as Sean told. Thanks
---
--
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19752#discussion_r153183113
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -158,111 +178,86 @@ abstract class Cas
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19757
**[Test build #84213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84213/testReport)**
for PR 19757 at commit
[`45ab60b`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19757
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84213/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19817
LGTM, merging to master/2.2!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84214/testReport)**
for PR 19811 at commit
[`006b2fd`](https://github.com/apache/spark/commit/00
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19817
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19757#discussion_r153184543
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -29,21 +30,30 @@ class HiveExplainSuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153185397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -173,6 +173,23 @@ class CodegenContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153185862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -111,11 +110,12 @@ private [sql] object G
Github user kiszk closed the pull request at:
https://github.com/apache/spark/pull/19601
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user kiszk reopened a pull request:
https://github.com/apache/spark/pull/19601
[SPARK-22383][SQL] Generate code to directly get value of primitive type
array from ColumnVector for table cache
## What changes were proposed in this pull request?
This PR generates the J
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153186151
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -334,7 +334,7 @@ case class RegExpReplace(
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19601
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19601
**[Test build #84215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84215/testReport)**
for PR 19601 at commit
[`9b6b890`](https://github.com/apache/spark/commit/9b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19814
**[Test build #3992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3992/testReport)**
for PR 19814 at commit
[`821ee19`](https://github.com/apache/spark/commit/8
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19825
[SPARK-22615][SQL] Handle more cases in PropagateEmptyRelation
## What changes were proposed in this pull request?
Currently, in the optimize rule `PropagateEmptyRelation`, the follow
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153187131
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -845,4 +845,24 @@ class CastSuite extends SparkFun
1 - 100 of 489 matches
Mail list logo
