Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175521925
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -657,6 +667,31 @@ class SparkSubmitSuite
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20853#discussion_r175523620
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r175533480
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/20669
Think someone with permissions to merge has to do so here.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20818
**[Test build #4140 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4140/testReport)**
for PR 20818 at commit
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175532438
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20636
ping @gatorsmile and @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20669
I probably won't have time to review this carefully, so if you're happy
with it, don't wait for me.
---
-
To unsubscribe,
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/20669
@vanzin anything other feedback before merging this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20853
Also this is not related to structured streaming, so `[ss]` is wrong. This
is a core change.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88378/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88378/testReport)**
for PR 20850 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r175528895
--- Diff: sql/core/src/test/resources/sql-tests/inputs/interval.sql ---
@@ -0,0 +1,184 @@
+-- Basic tests for intervals
+
+select
+ '1'
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88380 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88380/testReport)**
for PR 20850 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r175528512
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1479,15 +1479,13 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1614/
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r175527998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -408,6 +408,7 @@ object FunctionRegistry {
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20853
nit: pr title should describe the solution, not the problem. e.g. "Respect
URI fragment when resolving globs" is a description of the solution.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r175525822
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -616,18 +616,22 @@ booleanValue
;
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175525056
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -40,29 +37,45 @@
*/
public
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/20852
Apologies for breaking it!
This LGTM
I'll go ahead and merge it to fix the build, but please comment further on
this PR as needed.
---
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/20852
Merging with branch-2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20852#discussion_r175524288
--- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala ---
@@ -119,9 +119,15 @@ trait MLTest extends StreamTest with TempDirectory {
self:
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175522981
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19108#discussion_r175521718
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19108#discussion_r175521761
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19108#discussion_r174977495
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTestSuite.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19108#discussion_r174977489
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTestSuite.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175520457
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r175518159
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,14 +53,10 @@ fi
case "$SPARK_K8S_CMD" in
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r175514291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -408,6 +408,7 @@ object FunctionRegistry {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20853
**[Test build #88379 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88379/testReport)**
for PR 20853 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20853
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88376/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20827
**[Test build #88376 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88376/testReport)**
for PR 20827 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88377/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #88377 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88377/testReport)**
for PR 20433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20701
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88374/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20701
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20701
**[Test build #88374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88374/testReport)**
for PR 20701 at commit
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/20763
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175474010
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -17,17 +17,71 @@
package
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20846
Right, @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20858
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20858
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user mn-mikke opened a pull request:
https://github.com/apache/spark/pull/20858
[SPARK-23736][SQL] Implementation of the concat_arrays function
concatenating multiple array columns into one.
## What changes were proposed in this pull request?
The PR adds a logic for easy
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20818
**[Test build #4140 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4140/testReport)**
for PR 20818 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1613/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88378/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20719
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88375/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20719
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20719
**[Test build #88375 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88375/testReport)**
for PR 20719 at commit
Github user samartinucci commented on the issue:
https://github.com/apache/spark/pull/18666
Do we have a workaround for this? Will this PR get merged?
---
-
To unsubscribe, e-mail:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175445800
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -111,27 +111,27 @@ object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175442491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -85,6 +85,12 @@ private[sql] class JSONOptions(
Github user brad-kaiser commented on the issue:
https://github.com/apache/spark/pull/19041
Hi @squito,
The back and forth communication between CacheRecoveryManager and the
BlockManagerMasterEndpoint is so that we always have an up to date view of what
executors are
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20849#discussion_r175439887
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -85,6 +85,12 @@ private[sql] class JSONOptions(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1612/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1611/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20719
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1610/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20719
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20701
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1609/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20701
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #88377 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88377/testReport)**
for PR 20433 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20719
**[Test build #88375 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88375/testReport)**
for PR 20719 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20701
**[Test build #88374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88374/testReport)**
for PR 20701 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20827
**[Test build #88376 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88376/testReport)**
for PR 20827 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175407382
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -36,8 +90,92 @@
public abstract
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175407178
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -40,29 +37,45 @@
*/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88369/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18982
**[Test build #88369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88369/testReport)**
for PR 18982 at commit
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/20818
@ajbozarth @srowen
Help to review the code.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175397262
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -40,29 +37,45 @@
*/
public
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88370/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20827
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20827
**[Test build #88370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88370/testReport)**
for PR 20827 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175372993
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriter.java
---
@@ -17,17 +17,71 @@
package
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175372362
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -86,11 +86,17 @@ public void grow(int
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175363603
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -86,11 +86,17 @@ public void grow(int
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88371/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20847
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175393443
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -31,24 +31,24 @@
* for each
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20847
**[Test build #88371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88371/testReport)**
for PR 20847 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175393169
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -47,126 +40,119 @@ private void
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175392909
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -86,11 +86,17 @@ public void grow(int
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
@kiszk this is a good start! This is very performance critical code, can
you please extend/update/run the existing `UnsafeProjectionBenchmark`?
---
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r175391993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -111,27 +111,27 @@ object
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88372/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #88372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88372/testReport)**
for PR 20433 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
This test is consistently failed. While I did not change file reader, I am
investigating the reason in my environment.
---
-
To
301 - 400 of 479 matches
Mail list logo
