[GitHub] spark issue #21568: [SPARK-24562][TESTS] Support different configs for same ...

2018-06-15 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21568 @rxin the PR does what was suggested in these 2 comments https://github.com/apache/spark/pull/20023#issuecomment-358306751 and https://github.com/apache/spark/pull/21529#issuecomment-396413144. Bas

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91958/ Test FAILed. ---

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21441 **[Test build #91958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91958/testReport)** for PR 21441 at commit [`66d2437`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #21568: [SPARK-24562][TESTS] Support different configs fo...

2018-06-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21568#discussion_r195895110 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -104,11 +105,34 @@ class SQLQueryTestSuite extends QueryTest with Sh

[GitHub] spark pull request #21568: [SPARK-24562][TESTS] Support different configs fo...

2018-06-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21568#discussion_r195895102 --- Diff: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/decimalArithmeticOperations.sql_spark.sql.decimalOperations.allowPrecisionLoss-fals

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20795 kindly ping @kevinyu98 @dilipbiswal --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #21565: [SPARK-24558][Core]wrong Idle Timeout value is us...

2018-06-15 Thread sandeep-katta
Github user sandeep-katta commented on a diff in the pull request: https://github.com/apache/spark/pull/21565#discussion_r195895035 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #21552: [SPARK-24544][SQL] Print actual failure cause whe...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21552#discussion_r195894982 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21389 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91955/ Test PASSed. ---

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21389 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21389 **[Test build #91955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91955/testReport)** for PR 21389 at commit [`f78334c`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91957/ Test FAILed. ---

[GitHub] spark pull request #21565: [SPARK-24558][Core]wrong Idle Timeout value is us...

2018-06-15 Thread sandeep-katta
Github user sandeep-katta commented on a diff in the pull request: https://github.com/apache/spark/pull/21565#discussion_r195894845 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21441 **[Test build #91957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91957/testReport)** for PR 21441 at commit [`6c86d92`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #21565: [SPARK-24558][Core]wrong Idle Timeout value is us...

2018-06-15 Thread sandeep-katta
Github user sandeep-katta commented on a diff in the pull request: https://github.com/apache/spark/pull/21565#discussion_r195894823 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91964/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a6

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91963/ Test FAILed. ---

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #91963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91963/testReport)** for PR 20636 at commit [`a134091`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #21565: [SPARK-24558][Core]wrong Idle Timeout value is us...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21565#discussion_r195894664 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request #21565: [SPARK-24558][Core]wrong Idle Timeout value is us...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21565#discussion_r195894599 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4128/ Tes

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/233/

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #91963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91963/testReport)** for PR 20636 at commit [`a134091`](https://github.com/apache/spark/commit/a1

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20636 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #21575: [SPARK-24566][CORE] spark.storage.blockManagerSlaveTimeo...

2018-06-15 Thread xueyumusic
Github user xueyumusic commented on the issue: https://github.com/apache/spark/pull/21575 I added the tests, thanks @maropu --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #91962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91962/testReport)** for PR 20636 at commit [`a134091`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91962/ Test FAILed. ---

[GitHub] spark issue #21577: [WIP] [SPARK-24552][core] Correctly identify tasks in ou...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21577 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21577: [WIP] [SPARK-24552][core] Correctly identify tasks in ou...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21577 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91950/ Test PASSed. ---

[GitHub] spark issue #21577: [WIP] [SPARK-24552][core] Correctly identify tasks in ou...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21577 **[Test build #91950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91950/testReport)** for PR 21577 at commit [`d471b74`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4127/ Tes

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/232/

[GitHub] spark pull request #21544: add one supported type missing from the javadoc

2018-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21544 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #91962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91962/testReport)** for PR 20636 at commit [`a134091`](https://github.com/apache/spark/commit/a1

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21549 you can commwnt this line https://github.com/HyukjinKwon/spark/blob/master/dev/run-tests.py#L577 and add `pass` instead. --- --

[GitHub] spark issue #21544: add one supported type missing from the javadoc

2018-06-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21544 Thanks. Merging in master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20636 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #21578: [SPARK-24571][SQL] Support Char literals

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21578 **[Test build #91961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91961/testReport)** for PR 21578 at commit [`4210146`](https://github.com/apache/spark/commit/42

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21549 @cloud-fan, I will take a look tonight (singapore timezone). Please feel free to disable it for now to unblock other PRs if you think so. From a very quick look (it's mobile), I think it needs s

[GitHub] spark issue #21568: [SPARK-24562][TESTS] Support different configs for same ...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21568 IIUC this pr modified code to run a single test file multiple times in `SQLQueryTestSuite` with different configurations. --- - T

[GitHub] spark issue #21578: [SPARK-24571][SQL] Support Char literals

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21578 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21578: [SPARK-24571][SQL] Support Char literals

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21578 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21578: [SPARK-24571][SQL] Support Char literals

2018-06-15 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/21578 [SPARK-24571][SQL] Support Char literals ## What changes were proposed in this pull request? In the PR, I propose to automatically convert a `Literal` with `Char` type to a `Literal` of `S

[GitHub] spark issue #21568: [SPARK-24562][TESTS] Support different configs for same ...

2018-06-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21568 I'm confused by the description. What does this PR actually do? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org F

[GitHub] spark pull request #21568: [SPARK-24562][TESTS] Support different configs fo...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21568#discussion_r195893037 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -104,11 +105,34 @@ class SQLQueryTestSuite extends QueryTest with Shar

[GitHub] spark issue #21574: [SPARK-24478][SQL][followup] Move projection and filter ...

2018-06-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21574 Does this move actually make sense? It'd destroy stats estimation for partition pruning. --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark pull request #21568: [SPARK-24562][TESTS] Support different configs fo...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21568#discussion_r195892983 --- Diff: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/decimalArithmeticOperations.sql_spark.sql.decimalOperations.allowPrecisionLoss-false.

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21549 @HyukjinKwon is it possible that the constant build failure is caused by the java style checker? Other PRs that don't touch java files are fine. --- -

[GitHub] spark issue #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression uses g...

2018-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21276 this is a safe fix, I'm also merging it to 2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21549 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21549 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91960/ Test FAILed. ---

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21549 **[Test build #91960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91960/testReport)** for PR 21549 at commit [`52e706b`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21549 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/231/

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21549 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4126/ Tes

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21549 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21549 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21549 **[Test build #91960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91960/testReport)** for PR 21549 at commit [`52e706b`](https://github.com/apache/spark/commit/52

[GitHub] spark issue #21549: [SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users ...

2018-06-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21549 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-06-15 Thread edwinalu
Github user edwinalu commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r195892287 --- Diff: core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala --- @@ -251,6 +261,222 @@ class EventLoggingListenerSuite extends

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-06-15 Thread edwinalu
Github user edwinalu commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r195892271 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -98,14 +101,53 @@ class ExecutorSummary private[spark]( val removeRea

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-06-15 Thread edwinalu
Github user edwinalu commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r195892263 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -98,14 +101,53 @@ class ExecutorSummary private[spark]( val removeRea

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-06-15 Thread edwinalu
Github user edwinalu commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r195892278 --- Diff: core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala --- @@ -251,6 +261,222 @@ class EventLoggingListenerSuite extends

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 @xueyumusic Can you fix the error first? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional command

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 cc @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91959/ Test FAILed. ---

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91959/testReport)** for PR 21567 at commit [`a8dc241`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91959/testReport)** for PR 21567 at commit [`a8dc241`](https://github.com/apache/spark/commit/a8

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21567 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark

[GitHub] spark pull request #21570: [SPARK-24564][TEST] Add test suite for RecordBina...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21570#discussion_r195891897 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java --- @@ -0,0 +1,255 @@ +/* + * Licensed to

[GitHub] spark pull request #21554: [SPARK-24546][SQL] InsertIntoDataSourceCommand ma...

2018-06-15 Thread zheh12
Github user zheh12 closed the pull request at: https://github.com/apache/spark/pull/21554 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21288: [SPARK-24206][SQL] Improve FilterPushdownBenchmark bench...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21288 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21288: [SPARK-24206][SQL] Improve FilterPushdownBenchmark bench...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21288 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91946/ Test PASSed. ---

[GitHub] spark issue #21288: [SPARK-24206][SQL] Improve FilterPushdownBenchmark bench...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21288 **[Test build #91946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91946/testReport)** for PR 21288 at commit [`4a9cec9`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #21570: [SPARK-24564][TEST] Add test suite for RecordBina...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21570#discussion_r195891774 --- Diff: core/src/test/java/org/apache/spark/memory/TestMemoryConsumer.java --- @@ -43,6 +45,12 @@ void free(long size) { used -= size; ta

[GitHub] spark pull request #21570: [SPARK-24564][TEST] Add test suite for RecordBina...

2018-06-15 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21570#discussion_r195891644 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java --- @@ -0,0 +1,255 @@ +/* + * Licensed to

[GitHub] spark issue #21575: [SPARK-24566][CORE] spark.storage.blockManagerSlaveTimeo...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21575 btw, better to add tests and can you do? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional command

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4125/ Tes

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/230/

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21441 **[Test build #91958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91958/testReport)** for PR 21441 at commit [`66d2437`](https://github.com/apache/spark/commit/66

[GitHub] spark pull request #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to se...

2018-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21441#discussion_r195891280 --- Diff: project/SparkBuild.scala --- @@ -464,7 +464,20 @@ object DockerIntegrationTests { */ object DependencyOverrides { lazy val se

[GitHub] spark pull request #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to se...

2018-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21441#discussion_r195891263 --- Diff: project/SparkBuild.scala --- @@ -464,7 +464,20 @@ object DockerIntegrationTests { */ object DependencyOverrides { lazy val se

[GitHub] spark pull request #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to se...

2018-06-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21441#discussion_r195891199 --- Diff: pom.xml --- @@ -123,7 +123,7 @@ 1.6.0 3.4.6 2.6.0 -org.spark-project.hive +com.github.hyukjinkwon

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91956/ Test FAILed. ---

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21441 **[Test build #91957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91957/testReport)** for PR 21441 at commit [`6c86d92`](https://github.com/apache/spark/commit/6c

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #91956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91956/testReport)** for PR 20636 at commit [`a134091`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/229/

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21441: [DO-NOT-MERGE] Run tests against hadoop-3.1 to see the t...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4124/ Tes

  1   2   3   4   5   6   7   8   >