Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r210492311
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -216,8 +217,7 @@ private[spark] class Executor(
def stop(): Un
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r210492513
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -69,6 +69,11 @@ package object config {
.bytesConf(ByteUnit
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/22110#discussion_r210493260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
---
@@ -73,4 +73,14 @@ object TypeUtils {
}
x.l
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
For 2. and 3., it is harder to say my opinion in the comment. Let me say
short comments at first.
For 2., if I remember correctly, @viirya once wrote the API document in a
JIRA entry. it woul
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22119
CSV is loaded by default, while AVRO is not. So having a backward
compatibility mapping in CSV only still makes sense.
Let's remove the mapping for CSV in 3.0.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21537
If there's a bug, then let's fix in another JIRA. If that's impossible to
fix or sounds super risky and there's something I missed, let's revert.
---
--
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21537
I wouldn't revert this unless there are specific concerns about this. Do
you see any bug by a mixture
of representation `s""` and `code""`?
---
-
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22119
For details, see the discussion in the JIRA
https://issues.apache.org/jira/browse/SPARK-24924
---
-
To unsubscribe, e-mail: r
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22119
If we all agree this databricks mapping is not reasonable, I think it's ok
to have this inconsistency and remove the mapping for CSV in 3.0.
It's weird to make the same mistake just to mak
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22111
Let us hold these codegen PRs until we see the design doc for building IR
for the codegen?
---
-
To unsubscribe, e-mail: revi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22119#discussion_r210491239
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -637,6 +635,12 @@ object DataSource extends Logging
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22098
@shaneknapp, seems this was first introduced in
https://issues.apache.org/jira/browse/SPARK-3076 /
https://github.com/apache/spark/pull/1974 for a good reason fwiw.
One thing I am not s
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22119#discussion_r210491110
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
@@ -503,7 +495,7 @@ class AvroSuite extends QueryTest with SharedSQLC
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #4278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4278/testReport)**
for PR 21889 at commit
[`8d822ee`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21320
**[Test build #4277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4277/testReport)**
for PR 21320 at commit
[`0e5594b`](https://github.com/apache/spark/commit/0
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
Thank for involving me in an important thread. I was busy this morning in
Japan.
I think there are three topics in the thread.
1. Merge or revert this PR
2. Design document
3. IR d
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210490145
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(intersected)
})
+#' i
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210490166
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFrame(excepted)
})
+#' exceptA
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22119
Sorry if I missed some comments somewhere but just for clarification,
should we do it for CSV in 3.0.0? Inconsistency should also be taken into
account. Actually configuration sounds making mor
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210490074
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFrame(excepted)
})
+#' exceptA
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21835#discussion_r210489980
--- Diff: R/pkg/R/functions.R ---
@@ -3320,7 +3321,7 @@ setMethod("explode",
#' @aliases sequence sequence,Column-method
#' @note sequence sinc
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22119
**[Test build #94841 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94841/testReport)**
for PR 22119 at commit
[`656790e`](https://github.com/apache/spark/commit/65
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22119
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22119
@tgravescs @dongjoon-hyun @HyukjinKwon @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For a
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22119#discussion_r210489530
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -637,6 +635,12 @@ object DataSource extends Logg
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22119
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2239/
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20725#discussion_r210489614
--- Diff: python/pyspark/sql/tests.py ---
@@ -4331,13 +4354,22 @@ def test_createDataFrame_fallback_enabled(self):
self.assertEq
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22119
[WIP][SPARK-25129][SQL] Revert mapping com.databricks.spark.avro to
org.apache.spark.sql.avro
## What changes were proposed in this pull request?
In https://issues.apache.org/jira/br
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22117
**[Test build #94840 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94840/testReport)**
for PR 22117 at commit
[`3cad78f`](https://github.com/apache/spark/commit/3c
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488842
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(intersected)
})
+#' i
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488890
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFrame(excepted)
})
+#' exceptA
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22117
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22117
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2238/
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488754
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(intersected)
})
+#' i
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210488641
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFrame(excepted)
})
+#' exceptA
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/22117
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/22112
You are perfectly correct @jiangxb1987, that was a silly mistake on my part
- and not trivial at all !
It should be shuffle dependency we should rely on when traversing the
dependency tree, not
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21320
@mallman, can you close this and put some efforts there in
https://github.com/apache/spark/pull/21889? I see no point of leaving this PR
open.
---
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/22112
> IMO we should traverse the dependency graph and rely on how ShuffledRDD
is configured
A trivial point here - Since `ShuffleDependency` is also a DeveloperAPI,
it's possible for users
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22115
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/22112
I am not sure what the definition of `isIdempotent` here is.
For example, from MapPartitionsRDD :
```
override private[spark] def isIdempotent = {
if (inputOrderSensitive) {
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22115
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22118
@speful looks mistakenly open. mind closing this please?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
F
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22095
@mccheah btw, please add a comment (say "merged to master") after you merge
a PR - just a convention in this project. FYI. thx.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2237/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22031
**[Test build #94839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94839/testReport)**
for PR 22031 at commit
[`16516ec`](https://github.com/apache/spark/commit/16
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22031
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94837/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22009
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22009
**[Test build #94837 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94837/testReport)**
for PR 22009 at commit
[`0318b4b`](https://github.com/apache/spark/commit/0
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21860
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22118
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22118
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22118
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20725
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94838/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20725
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
GitHub user speful opened a pull request:
https://github.com/apache/spark/pull/22118
Branch 2.2
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch wa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20725
**[Test build #94838 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94838/testReport)**
for PR 20725 at commit
[`461c326`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22117
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94834/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22117
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22117
**[Test build #94834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94834/testReport)**
for PR 22117 at commit
[`3cad78f`](https://github.com/apache/spark/commit/3
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20725
This is working now, and BinaryType support is conditional on pyarrow
0.10.0 or higher being used. @HyukjinKwon @cloud-fan what are your thoughts on
getting this in for Spark 2.4? I think it wou
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20725
**[Test build #94838 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94838/testReport)**
for PR 20725 at commit
[`461c326`](https://github.com/apache/spark/commit/46
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20725
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21537
We are fully swamped by the hotfix and regressions of 2.3 release and the
new features that are targeting to 2.4. We should post some comments in this PR
earlier.
Designing an IR for ou
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20725
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2236/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21860
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21860
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94835/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #94835 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94835/testReport)**
for PR 21860 at commit
[`6ff46d9`](https://github.com/apache/spark/commit/6
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94833/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22031
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22031
**[Test build #94833 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94833/testReport)**
for PR 22031 at commit
[`0342ed9`](https://github.com/apache/spark/commit/0
Github user raofu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22113#discussion_r210473687
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileOperator.scala ---
@@ -70,7 +70,7 @@ private[hive] object OrcFileOperator extends Loggi
Github user raofu closed the pull request at:
https://github.com/apache/spark/pull/22113
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94831/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22115
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22115
**[Test build #94831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94831/testReport)**
for PR 22115 at commit
[`089c31f`](https://github.com/apache/spark/commit/0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210469510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class ArrayAggregat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210469494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class ArrayAggregat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210471011
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,177 @@ class DataFrameFunctionsSuite extends QueryT
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210469472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class ArrayAggregat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210470513
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class ArrayAggregat
Github user deshanxiao commented on the issue:
https://github.com/apache/spark/pull/22109
@vanzin Sorry..SPARK-22850 has fix the problem. Maybe I will track the
executor lose problem next. Thank you! @vanzin @squito
---
-
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -442,3 +442,91 @@ case class ArrayAggregat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467721
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class HigherOrderFu
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467959
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class HigherOrderFu
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210468814
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -51,3 +51,12 @@ select exists(ys, y -> y > 30) as v from nested;
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210468640
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,76 @@ class DataFrameFunctionsSuite extends QueryTe
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210466854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -687,3 +687,89 @@ case class MapZipWith(le
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467535
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class HigherOrderFu
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r210468884
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -246,6 +245,16 @@ class BisectingKMeans private (
new
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22116
Huh OK I thought I looked and this had been fixed. Good catch. Also there's
an instance in `cloud-integration.md`, worth fixing too.
---
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r210468639
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -246,6 +245,16 @@ class BisectingKMeans private (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r210468107
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -246,6 +245,16 @@ class BisectingKMeans private (
new
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas Kindly reminder.
@zsxwing Could you take a quick look at this and share your thought? I
think the patch is ready to merge, but blocked with slightly conflict of view
so more voices wou
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r210467653
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -246,6 +245,16 @@ class BisectingKMeans private (
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21733
@tdas Kindly reminder.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: re
Github user bomeng commented on the issue:
https://github.com/apache/spark/pull/22115
I have already done the global search. That is the only place needs change.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spar
1 - 100 of 540 matches
Mail list logo
