Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r217953294
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1803,6 +1803,18 @@ test_that("string operators", {
collect(select(df4,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22418#discussion_r217952724
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -50,6 +55,66 @@ abstract class OrcSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22439
**[Test build #96120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96120/testReport)**
for PR 22439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22439
[SPARK-25444][SQL] Refactor GenArrayData.genCodeToCreateArrayData method
## What changes were proposed in this pull request?
This PR makes `GenArrayData.genCodeToCreateArrayData` method
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22408
LGTM. I think the last piece is the migration guide, to explain what
changed from 2.3 to 2.4
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22418#discussion_r217949342
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -50,6 +55,66 @@ abstract class OrcSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22438
**[Test build #96119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96119/testReport)**
for PR 22438 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22438
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22438
cc @vanzin @felixcheung @srowen @jerryshao
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22438
[SPARK-25443][INFRA] fix issues when building docs with release scripts in
docker
## What changes were proposed in this pull request?
These 2 changes are required to build the docs for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22437
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22437
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22428
The performance issue was introduced by repeating query plan analysis,
which is resolved in the current master if I am not mistaken - if you're in
doubt, I would suggest to do a quick
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96115/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22435
**[Test build #96115 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96115/testReport)**
for PR 22435 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22437
**[Test build #96118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96118/testReport)**
for PR 22437 at commit
Github user goungoun commented on the issue:
https://github.com/apache/spark/pull/22428
@HyukjinKwon , thanks for your review. Actually, that is the reason that I
open this pull request. I think it is better to giving reusable option to users
than repeating too much of same code in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22418
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22418
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96113/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22418
**[Test build #96113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96113/testReport)**
for PR 22418 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22436
Thanks for the fix! I'm not familiar with part though, let's ping @vanzin
@felixcheung @jerryshao
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22437
**[Test build #96117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96117/testReport)**
for PR 22437 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22437
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22437
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22437
[SPARK-25431][SQL][EXAMPLES] Fix function examples and the example results.
## What changes were proposed in this pull request?
There are some mistakes in examples of newly added functions.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22437
cc @dongjoon-hyun @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22436
**[Test build #96116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96116/testReport)**
for PR 22436 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22395
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22395
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96114/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22436
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22395
**[Test build #96114 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96114/testReport)**
for PR 22395 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22436
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22436
CC @cloud-fan This one doesn't block 2.4.0 but would be nice to have.
Certainly if there's a second RC.
---
-
To unsubscribe,
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22436
[SPARK-24654][BUILD][FOLLOWUP] Update, fix LICENSE and NOTICE, and
specialize for source vs binary
## What changes were proposed in this pull request?
Fix location of licenses-binary in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/7
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96112/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/7
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/7
**[Test build #96112 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96112/testReport)**
for PR 7 at commit
Github user suryag10 commented on the issue:
https://github.com/apache/spark/pull/22433
> I'm wondering, is there some reason this isn't supported in cluster mode
for yarn & mesos? Or put another way, what is the rationale for k8s being added
as an exception to this rule?
I
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22395#discussion_r217942351
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -143,16 +143,14 @@ class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22432
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22432
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
Yeah I noticed that. I think we should leave it, and, if somehow RC1
passes, we'll mark this as fixed for a later release.
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21677
> So, are you heading main-method style with separate BM output files?
Yes. So it's not reverting this PR, since writing BM result to a file is
good. But we should update these BMs to use
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22231
Note that, RC1 was cut before merging this PR, which means, this patch is
not available in 2.4.0. I hit some problems running the release scripts and
spent quite a lot of time to fix them, so the
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21860
cc @maropu @kiszk @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22428
Can we simply call the API multiple times? I think we haven't usually added
such aliases for an API unless there's strong argument for it.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22428#discussion_r217937566
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2300,6 +2300,37 @@ class Dataset[T] private[sql](
}
}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18304
CSV's `lineSep` is not added yet. The problem here is specific to CSV - we
are os-dependent on the newline separator by Univocity's which is not the case
in Jackson and which can be worked
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22395#discussion_r217935398
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -143,16 +143,14 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22435
**[Test build #96115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96115/testReport)**
for PR 22435 at commit
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22435#discussion_r217934875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala
---
@@ -83,4 +83,20 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22395
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22395
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22395
**[Test build #96114 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96114/testReport)**
for PR 22395 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22395
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22418
**[Test build #96113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96113/testReport)**
for PR 22418 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22418
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22418
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22418
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22435#discussion_r217933342
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala
---
@@ -83,4 +83,20 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/7
**[Test build #96112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96112/testReport)**
for PR 7 at commit
Github user phegstrom commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r217930978
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1803,6 +1803,18 @@ test_that("string operators", {
collect(select(df4,
Github user phegstrom commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r217930893
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1803,6 +1803,10 @@ test_that("string operators", {
collect(select(df4,
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r217928631
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -469,7 +470,17 @@ abstract class TreeNode[BaseType <:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r217928428
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -250,5 +254,36 @@ class QueryExecution(val sparkSession:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r217928334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -250,5 +254,36 @@ class QueryExecution(val sparkSession:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r217928262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -469,7 +470,17 @@ abstract class TreeNode[BaseType <:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22396#discussion_r217926918
--- Diff: docs/sql-programming-guide.md ---
@@ -1897,7 +1897,8 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- In
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96109/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96111/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #96109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96109/testReport)**
for PR 22429 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22435
**[Test build #96111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96111/testReport)**
for PR 22435 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22393
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
thx. merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22432
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22432
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96108/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22432
**[Test build #96108 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96108/testReport)**
for PR 22432 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22396
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96110/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22396
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22396
**[Test build #96110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96110/testReport)**
for PR 22396 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22343
Thank YOU for your PR and open discussion on this, @seancxmao . Let's see
in another PRs.
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21677
Yes. @cloud-fan . We can embrace that concept to all the other main-method
style benchmark. Previously, we do the manual copy to put the result into
the nearest place to the corresponding BM
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22427#discussion_r217923482
--- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt ---
@@ -2,737 +2,669 @@
Pushdown for many distinct value case
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/22433
> As this script is common start point for all the resource
managers(k8s/yarn/mesos/standalone/local), i guess changing this to fit for all
the cases has a value add, instead of doing at each
Github user jacobdr commented on the issue:
https://github.com/apache/spark/pull/22433
> a DNS-1123 subdomain must consist of lower case alphanumeric characters,
'-' or '.'
Your changes to the name handling donât comply with this, so agree with
@mridulm you should move
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22434
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96107/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22434
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22434
**[Test build #96107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96107/testReport)**
for PR 22434 at commit
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22396#discussion_r217920696
--- Diff: docs/sql-programming-guide.md ---
@@ -1898,6 +1898,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
-
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22396#discussion_r217920417
--- Diff: docs/sql-programming-guide.md ---
@@ -1898,6 +1898,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22435
**[Test build #96111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96111/testReport)**
for PR 22435 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22435
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 139 matches
Mail list logo
