[GitHub] spark pull request #22442: [SPARK-25447][SQL] Support JSON options by schema...

2018-09-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22442#discussion_r218545335 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3611,6 +3611,20 @@ object functions { */ def schema_of_json(e:

[GitHub] spark issue #22305: [WIP][SPARK-24561][SQL][Python] User-defined window aggr...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22305 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96184/ Test FAILed. ---

[GitHub] spark issue #22305: [WIP][SPARK-24561][SQL][Python] User-defined window aggr...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22305 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22305: [WIP][SPARK-24561][SQL][Python] User-defined window aggr...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22305 **[Test build #96184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96184/testReport)** for PR 22305 at commit

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22451 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22451 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22451 **[Test build #96191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96191/testReport)** for PR 22451 at commit

[GitHub] spark pull request #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22451#discussion_r218538423 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/execution/benchmark/AvroWriteBenchmark.scala --- @@ -0,0 +1,39 @@ +/* + *

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-18 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/22355 LGTM as well. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchm...

2018-09-18 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22443#discussion_r218535655 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -17,29 +17,28 @@ package

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218535402 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2214,6 +2214,24 @@ object functions { */ def

[GitHub] spark issue #21950: [SPARK-24914][SQL][WIP] Add configuration to avoid OOM d...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21950 **[Test build #96190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96190/testReport)** for PR 21950 at commit

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218534147 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -96,3 +96,9 @@ select positive('-1.11'), positive(-1.11), negative('-1.11'),

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218508374 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218466733 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218533001 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218465153 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218468244 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218533702 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218462401 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218467664 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218465817 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +163,21 @@ public TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218490559 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +163,21 @@ public TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218494508 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java --- @@ -24,15 +24,27 @@ import

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218463768 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218466397 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218524063 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1245,3 +1245,65 @@ case class BRound(child:

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218525420 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala --- @@ -644,4 +644,31 @@ class

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218531021 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1245,3 +1245,65 @@ case class BRound(child:

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218525567 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala --- @@ -644,4 +644,31 @@ class

[GitHub] spark pull request #22399: [SPARK-25408] Move to mode ideomatic Java8

2018-09-18 Thread Fokko
Github user Fokko commented on a diff in the pull request: https://github.com/apache/spark/pull/22399#discussion_r218532105 --- Diff: common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java --- @@ -143,37 +143,38 @@ public void

[GitHub] spark pull request #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22451#discussion_r218530749 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/execution/benchmark/AvroWriteBenchmark.scala --- @@ -0,0 +1,39 @@ +/* + *

[GitHub] spark pull request #22414: [SPARK-25424][SQL] Window duration and slide dura...

2018-09-18 Thread raghavgautam
Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/spark/pull/22414#discussion_r218530222 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -122,6 +123,51 @@ class TimeWindowSuite

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22451 HI, @gengliangwang . Since this aims to refactor, could you check #22443 to be consistent? > Refactor DataSourceWriteBenchmark and add write benchmark for AVRO. ---

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-18 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22429 Tests failed on `PythonForeachWriterSuite`. Waiting for https://github.com/apache/spark/pull/22452 --- - To unsubscribe,

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22451 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22451 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96182/ Test FAILed. ---

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22451 **[Test build #96182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96182/testReport)** for PR 22451 at commit

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22429 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96178/ Test FAILed. ---

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22429 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22429 **[Test build #96178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96178/testReport)** for PR 22429 at commit

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96180/ Test FAILed. ---

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22450 **[Test build #96180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96180/testReport)** for PR 22450 at commit

[GitHub] spark pull request #22448: [SPARK-25417][SQL] Improve findTightestCommonType...

2018-09-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22448#discussion_r218513387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -106,6 +108,22 @@ object TypeCoercion {

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22452 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22452 **[Test build #96189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96189/testReport)** for PR 22452 at commit

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22452 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22452 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22453 **[Test build #96187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96187/testReport)** for PR 22453 at commit

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96187/ Test PASSed. ---

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22453 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96188/testReport)** for PR 22454 at commit

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22452 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22444: [SPARK-25409][Core]Speed up Spark History loading via in...

2018-09-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22444 > so any server restart results in hours of downtime, just from scanning. Well, that's why 2.3 supports caching things on disk. Also, 2.4 has SPARK-6951 which should make this a lot faster

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22452 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22452 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96183/ Test FAILed. ---

[GitHub] spark issue #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterSuite

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22452 **[Test build #96183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96183/testReport)** for PR 22452 at commit

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22453 **[Test build #96187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96187/testReport)** for PR 22453 at commit

[GitHub] spark pull request #22449: [SPARK-22666][ML][FOLLOW-UP] Return a correctly f...

2018-09-18 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/22449#discussion_r218498363 --- Diff: mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala --- @@ -85,7 +85,9 @@ private[image] class ImageFileFormat extends

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22454 thanks, the code looks much simpler! I'll test it out tomorrow --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22454#discussion_r218497767 --- Diff: dev/create-release/release-build.sh --- @@ -446,6 +432,8 @@ if [[ "$1" == "publish-release" ]]; then # Clean-up Zinc nailgun process

[GitHub] spark issue #22453: [SPARK-20937][DOCS] Describe spark.sql.parquet.writeLega...

2018-09-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22453 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22452: [SPARK-25456][SQL][TEST] Fix PythonForeachWriterS...

2018-09-18 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22452#discussion_r218496943 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/python/PythonForeachWriterSuite.scala --- @@ -75,15 +78,20 @@ class

[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22454#discussion_r218496294 --- Diff: dev/create-release/release-build.sh --- @@ -305,16 +290,17 @@ if [[ "$1" == "package" ]]; then for key in ${!BINARY_PKGS_ARGS[@]}; do

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22454 @cloud-fan @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96186/testReport)** for PR 22454 at commit

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22454: [[SPARK-25445][BUILD][FOLLOWUP] Clean up release-build.s...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96185/testReport)** for PR 22454 at commit

[GitHub] spark pull request #22446: [SPARK-19550][DOC][FOLLOW-UP] Update tuning.md to...

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22446 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22454: [[SPARK-25445][BUILD][FOLLOWUP] Clean up release-build.s...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22454: [[SPARK-25445][BUILD][FOLLOWUP] Clean up release-build.s...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22165 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96176/ Test FAILed. ---

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22165 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22441: [SPARK-25445][BUILD] the release script should be...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22441#discussion_r218486554 --- Diff: dev/create-release/release-build.sh --- @@ -111,13 +111,17 @@ fi # different versions of Scala are supported. BASE_PROFILES="-Pmesos

[GitHub] spark issue #22165: [SPARK-25017][Core] Add test suite for BarrierCoordinato...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22165 **[Test build #96176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96176/testReport)** for PR 22165 at commit

[GitHub] spark issue #22446: [SPARK-19550][DOC][FOLLOW-UP] Update tuning.md to use JD...

2018-09-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22446 Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22454: [[SPARK-25445][BUILD][FOLLOWUP] Clean up release-...

2018-09-18 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22454 [[SPARK-25445][BUILD][FOLLOWUP] Clean up release-build.sh ## What changes were proposed in this pull request? This is a follow up for #22441. The code changes should make the

[GitHub] spark issue #22446: [SPARK-19550][DOC][FOLLOW-UP] Update tuning.md to use JD...

2018-09-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22446 Yeah, there's no 'latest' link though. The JDK is pretty stable so a link to Java 8 when we're on Java 9 isn't going to be an issue. ---

[GitHub] spark pull request #22441: [SPARK-25445][BUILD] the release script should be...

2018-09-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22441#discussion_r218481751 --- Diff: dev/create-release/release-build.sh --- @@ -111,13 +111,17 @@ fi # different versions of Scala are supported. BASE_PROFILES="-Pmesos

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218476955 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218476788 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218479034 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + *

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218479200 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + *

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218478615 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + *

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218479401 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + *

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218478292 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeValidatorSuite.scala --- @@ -0,0 +1,150 @@ +/* + *

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218477062 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -140,10 +140,19 @@ private[yarn] class

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218477315 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -35,18 +36,22 @@ import

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218478229 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeValidatorSuite.scala --- @@ -0,0 +1,150 @@ +/* + *

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218477920 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeHelperSuite.scala --- @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96177/ Test FAILed. ---

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-09-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18544 **[Test build #96177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96177/testReport)** for PR 18544 at commit

[GitHub] spark pull request #22441: [SPARK-25445][BUILD] the release script should be...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22441#discussion_r218471225 --- Diff: dev/create-release/release-build.sh --- @@ -414,15 +437,15 @@ if [[ "$1" == "publish-release" ]]; then -DskipTests $PUBLISH_PROFILES

[GitHub] spark pull request #22441: [SPARK-25445][BUILD] the release script should be...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22441#discussion_r218470455 --- Diff: dev/create-release/release-build.sh --- @@ -111,13 +111,17 @@ fi # different versions of Scala are supported. BASE_PROFILES="-Pmesos

[GitHub] spark issue #22444: [SPARK-25409][Core]Speed up Spark History loading via in...

2018-09-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22444 > history server startup needs to go through all these logs before being usable, so any server restart results in hours of downtime, just from scanning. I don't think this is true. The first

<    1   2   3   4   5   6   >