Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22788
@cloud-fan I like the idea of using JSON, but that will also change the
definition of string format. Do we just use JSON for nested case so the
existing data source doesn't have to be changed?
---
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22797
@cloud-fan OK.. thanks a LOT.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22797
yea, just a special rule instead of a general agg function rewrite
framework.
---
-
To unsubscribe, e-mail: reviews-unsubscr..
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22788
Yea I think so, we can even use JSON to be safer. e.g. for `a.b.c.d`, we
can encode it as a json array [a,b,c,d]. At data source side, use a json parser
to read it back.
---
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r227243187
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -770,8 +776,17 @@ case class SchemaOfJson(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22755
**[Test build #97908 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97908/testReport)**
for PR 22755 at commit
[`b16dc5c`](https://github.com/apache/spark/commit/b1
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22788
@cloud-fan @dongjoon-hyun instead of changing `Filter` API, do you think
using proper escaped char like this PR in
https://github.com/apache/spark/pull/22573 is a good approach?
---
--
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22797
@cloud-fan Sure.. Let me give that a try. Thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22799
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22799
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r227239707
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -770,8 +776,17 @@ case class SchemaOfJson(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r227239024
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -770,8 +776,17 @@ case class SchemaOfJson(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r22723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -49,10 +51,54 @@ class Interpre
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97891/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r227237973
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -770,8 +776,17 @@ case class SchemaOfJson(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22468
**[Test build #97891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97891/testReport)**
for PR 22468 at commit
[`9d7b519`](https://github.com/apache/spark/commit/9
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22787
Thanks @HyukjinKwon @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22797
Hi @dilipbiswal sorry for the back and forth, can you try one more
approach? Basically we want to evaluate how the simplest logical rewrite looks
like.
We can create unevaluatable EVERY
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22730
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22730
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4396/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22775
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22666
**[Test build #97907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97907/testReport)**
for PR 22666 at commit
[`49bac0e`](https://github.com/apache/spark/commit/49
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22730
**[Test build #97906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97906/testReport)**
for PR 22730 at commit
[`41f02f4`](https://github.com/apache/spark/commit/41
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4395/
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227236021
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22666
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22775
**[Test build #97905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97905/testReport)**
for PR 22775 at commit
[`dbf9cab`](https://github.com/apache/spark/commit/db
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22730
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22219
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22790
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4394/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22219
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97893/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22775
@cloud-fan, mind taking a look please?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comm
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22219
**[Test build #97893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97893/testReport)**
for PR 22219 at commit
[`136a4f9`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22790
**[Test build #97904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97904/testReport)**
for PR 22790 at commit
[`77902bc`](https://github.com/apache/spark/commit/77
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22754
**[Test build #97903 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97903/testReport)**
for PR 22754 at commit
[`6f8404b`](https://github.com/apache/spark/commit/6f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22754
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4393/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22754
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/22754
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22787
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20433
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97890/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20433
**[Test build #97890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97890/testReport)**
for PR 20433 at commit
[`554c122`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22799
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97892/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22799
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22799
**[Test build #97892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97892/testReport)**
for PR 22799 at commit
[`65be98b`](https://github.com/apache/spark/commit/6
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22787
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97900/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22801
**[Test build #97900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97900/testReport)**
for PR 22801 at commit
[`1bd23a4`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22801
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97902/testReport)**
for PR 22512 at commit
[`45e65e5`](https://github.com/apache/spark/commit/45
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22790#discussion_r227229331
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -126,7 +126,7 @@ object BisectingKMeansModel extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4392/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97901/testReport)**
for PR 22512 at commit
[`b8c5a17`](https://github.com/apache/spark/commit/b8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4391/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22801
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4390/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22723
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97888/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22723
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22723
**[Test build #97888 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97888/testReport)**
for PR 22723 at commit
[`b80bf66`](https://github.com/apache/spark/commit/b
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227226902
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -140,6 +141,14 @@ class SQLQueryTestSuite extends QueryTest with
Share
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22801
**[Test build #97900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97900/testReport)**
for PR 22801 at commit
[`1bd23a4`](https://github.com/apache/spark/commit/1b
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22801#discussion_r227226704
--- Diff: docs/sql-data-sources-load-save-functions.md ---
@@ -82,6 +82,50 @@ To load a CSV file you can use:
+The extra options
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22801
[SPARK-25656][DOC][EXAMPLE] Add a doc and examples about extra data source
options
## What changes were proposed in this pull request?
Our current doc does not explain how we are pas
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22512
ok, I'll add tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227224209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -49,10 +51,54 @@ class Interpreted
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227224030
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala
---
@@ -49,10 +51,54 @@ class Interpreted
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22754
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22754
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97887/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22754
**[Test build #97887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97887/testReport)**
for PR 22754 at commit
[`6f8404b`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #97899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97899/testReport)**
for PR 22612 at commit
[`7f7ed2b`](https://github.com/apache/spark/commit/7f
Github user rezasafi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r22741
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -95,10 +135,29 @@ private[spark] object ExecutorMetricType {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #97898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97898/testReport)**
for PR 22612 at commit
[`a3f2c9b`](https://github.com/apache/spark/commit/a3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22204
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22204
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97894/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22204
**[Test build #97894 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97894/testReport)**
for PR 22204 at commit
[`d5bff88`](https://github.com/apache/spark/commit/d
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22800
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22800
thanks, merging to master/2.4!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97884/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22787
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22787
**[Test build #97884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97884/testReport)**
for PR 22787 at commit
[`c04ea64`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97885/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22749
**[Test build #97885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97885/testReport)**
for PR 22749 at commit
[`400f878`](https://github.com/apache/spark/commit/4
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22797
cc @cloud-fan @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22755
**[Test build #97897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97897/testReport)**
for PR 22755 at commit
[`0d75328`](https://github.com/apache/spark/commit/0d
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r227215773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
---
@@ -122,19 +122,22 @@ class ExistenceJoinSuite extends S
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22755
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22784
Sorry for my mistake. My keyboard '4' sometimes has a trouble.
> I think, INT_MAX is 2147483647, so n ~= sqrt(2*2147483647) = 65536.
---
--
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227215135
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227214593
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22778#discussion_r227214404
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteSubquerySuite.scala
---
@@ -33,23 +34,44 @@ class RewriteSubquerySuite
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/22675
LGTM, this is great to have!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/22675#discussion_r227214199
--- Diff: docs/ml-datasource.md ---
@@ -0,0 +1,113 @@
+---
+layout: global
+title: Data sources
+displayTitle: Data sources
+---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4389/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21632
**[Test build #97896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97896/testReport)**
for PR 21632 at commit
[`bca2eaf`](https://github.com/apache/spark/commit/bc
1 - 100 of 968 matches
Mail list logo
