[GitHub] [spark] HeartSaVioR commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

HeartSaVioR commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439904675 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2541,7 +2542,20 @@ class Dataset[T] private[sql]( def

[GitHub] [spark] SparkQA commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numDropppedRowsByWatermark"

SparkQA commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643872713 **[Test build #124015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124015/testReport)** for PR 28828 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28810: [SPARK-31705][SQL][FOLLOWUP] Avoid the unnecessary CNF computation for full-outer joins

cloud-fan commented on a change in pull request #28810: URL: https://github.com/apache/spark/pull/28810#discussion_r439904681 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1334,13 +1340,13 @@ object

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

HeartSaVioR commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439904302 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r439904191 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -552,28 +553,34 @@ class HiveQuerySuite extends

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r439904225 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -552,28 +553,34 @@ class HiveQuerySuite extends

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r439903993 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -207,7 +208,7 @@ class HiveQuerySuite extends

[GitHub] [spark] maropu commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

maropu commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439904040 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2541,7 +2542,20 @@ class Dataset[T] private[sql]( def

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r439903944 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -180,7 +180,8 @@ class HiveQuerySuite extends

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

HeartSaVioR commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439903851 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

HeartSaVioR commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439903851 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] HeartSaVioR commented on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

HeartSaVioR commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643870176 Let's use `[SS]` instead as it's specific to SS issue. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28829: [WIP][SQL] Benchmark the EXCEPTION rebase mode

AmplabJenkins removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643869925 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numDropppedRowsByWatermark"

AmplabJenkins removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643869857 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

cloud-fan commented on a change in pull request #28807: URL: https://github.com/apache/spark/pull/28807#discussion_r439902886 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala ## @@ -388,12 +391,24 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numDropppedRowsByWatermark"

AmplabJenkins removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643869852 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on a change in pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

cloud-fan commented on a change in pull request #28807: URL: https://github.com/apache/spark/pull/28807#discussion_r439902678 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala ## @@ -388,12 +391,24 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

AmplabJenkins removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-643869892 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28829: [WIP][SQL] Benchmark the EXCEPTION rebase mode

AmplabJenkins removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643869919 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28829: [WIP][SQL] Benchmark the EXCEPTION rebase mode

AmplabJenkins commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643869919 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

AmplabJenkins commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-643869892 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numDropppedRowsByWatermark"

SparkQA removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643830855 **[Test build #124017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124017/testReport)** for PR 28828 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numDropppedRowsByWatermark"

AmplabJenkins commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643869852 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28829: [WIP][SQL] Benchmark the EXCEPTION rebase mode

SparkQA removed a comment on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643828884 **[Test build #124016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124016/testReport)** for PR 28829 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

SparkQA removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-643823823 **[Test build #124012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124012/testReport)** for PR 27066 at commit

[GitHub] [spark] SparkQA commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numDropppedRowsByWatermark"

SparkQA commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643869596 **[Test build #124017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124017/testReport)** for PR 28828 at commit

[GitHub] [spark] TJX2014 commented on pull request #28814: [SPARK-31968][SQL]Duplicate partition columns check when writing data

TJX2014 commented on pull request #28814: URL: https://github.com/apache/spark/pull/28814#issuecomment-643869358 > @TJX2014, can you leave one arbitrary comment in the JIRA to show your JIRA account?Committers should know your JIRA account so they can assign the ticket to you.

[GitHub] [spark] cloud-fan commented on a change in pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

cloud-fan commented on a change in pull request #28807: URL: https://github.com/apache/spark/pull/28807#discussion_r439902095 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala ## @@ -388,12 +391,24 @@ class

[GitHub] [spark] SparkQA commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

SparkQA commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-643869318 **[Test build #124012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124012/testReport)** for PR 27066 at commit

[GitHub] [spark] TJX2014 commented on pull request #28814: [SPARK-31968][SQL]Duplicate partition columns check when writing data

TJX2014 commented on pull request #28814: URL: https://github.com/apache/spark/pull/28814#issuecomment-643869446 > @TJX2014 . I mean your JIRA account ID. I need to assign [SPARK-31968](https://issues.apache.org/jira/browse/SPARK-31968) to you. :) Thanks, I am JinxinTang.

[GitHub] [spark] SparkQA commented on pull request #28829: [WIP][SQL] Benchmark the EXCEPTION rebase mode

SparkQA commented on pull request #28829: URL: https://github.com/apache/spark/pull/28829#issuecomment-643869353 **[Test build #124016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124016/testReport)** for PR 28829 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

dongjoon-hyun commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439901669 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2541,7 +2542,20 @@ class Dataset[T] private[sql]( def

[GitHub] [spark] dilipbiswal commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

dilipbiswal commented on a change in pull request #28825: URL: https://github.com/apache/spark/pull/28825#discussion_r439901179 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins removed a comment on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643867625 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

maropu commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439900371 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] AmplabJenkins commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643867625 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

SparkQA commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643867351 **[Test build #124025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124025/testReport)** for PR 28786 at commit

[GitHub] [spark] huaxingao commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

huaxingao commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643866868 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

SparkQA commented on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-643865812 **[Test build #124024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124024/testReport)** for PR 28821 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

AmplabJenkins commented on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-643864583 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins removed a comment on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643864454 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

AmplabJenkins removed a comment on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-643864583 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

dongjoon-hyun commented on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-643864421 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

SparkQA removed a comment on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643852583 **[Test build #124018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124018/testReport)** for PR 28786 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643864449 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins removed a comment on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643864449 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

SparkQA commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643864268 **[Test build #124018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124018/testReport)** for PR 28786 at commit

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

dongjoon-hyun edited a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643861808 Thank you for making a fix swiftly, @maropu . cc @dbtsai and @holdenk This is an automated

[GitHub] [spark] HyukjinKwon closed pull request #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing

HyukjinKwon closed pull request #24525: URL: https://github.com/apache/spark/pull/24525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing

HyukjinKwon commented on pull request #24525: URL: https://github.com/apache/spark/pull/24525#issuecomment-643863406 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

AmplabJenkins removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-643863164 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] xuanyuanking commented on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

xuanyuanking commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643863071 Yes, this incompatible bug is found by a WIP validation logic. I will reply the details and reference the PR soon. Dongjoon Hyun 于2020年6月15日 周一09:54写道： >

[GitHub] [spark] AmplabJenkins commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

AmplabJenkins commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-643863164 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

SparkQA commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-643862941 **[Test build #124023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124023/testReport)** for PR 28781 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

dongjoon-hyun commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439896619 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] dongjoon-hyun commented on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

dongjoon-hyun commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643861808 Thank you for making a swift fix, @maropu . cc @dbtsai and @holdenk This is an automated message from

[GitHub] [spark] zhengruifeng commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

zhengruifeng commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643860921 @srowen I do't feel strongly about it. LGTM This is an automated message from the Apache Git Service.

[GitHub] [spark] dongjoon-hyun commented on pull request #26901: [SPARK-29152][CORE][2.4] Executor Plugin shutdown when dynamic allocation is enabled

dongjoon-hyun commented on pull request #26901: URL: https://github.com/apache/spark/pull/26901#issuecomment-643860589 Sorry again, @iRakson . I fully understand you spent lots of time to make this contribution and the failed test cases passed individually and locally. However, we cannot

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

AmplabJenkins removed a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643860279 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

AmplabJenkins commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643860279 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

SparkQA commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-643860056 **[Test build #124022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124022/testReport)** for PR 27019 at commit

[GitHub] [spark] sarutak commented on pull request #28823: [SPARK-31983][WEBUI][3.0] Fix sorting for duration column in structured streaming tab

sarutak commented on pull request #28823: URL: https://github.com/apache/spark/pull/28823#issuecomment-643859358 LGTM. Merged to `branch-3.0`. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] sarutak closed pull request #28823: [SPARK-31983][WEBUI][3.0] Fix sorting for duration column in structured streaming tab

sarutak closed pull request #28823: URL: https://github.com/apache/spark/pull/28823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #26901: [SPARK-29152][CORE][2.4] Executor Plugin shutdown when dynamic allocation is enabled

dongjoon-hyun edited a comment on pull request #26901: URL: https://github.com/apache/spark/pull/26901#issuecomment-643853361 Unfortunately, this seems to break all `branch-2.4` Jenkins jobs again. -

[GitHub] [spark] maropu commented on a change in pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

maropu commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r439892041 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ## @@ -2548,6 +2548,21 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] maropu commented on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

maropu commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643856341 cc: @xuanyuanking @HeartSaVioR @srowen @gatorsmile This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643855961 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

AmplabJenkins commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643855929 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643855961 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

AmplabJenkins removed a comment on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643855929 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643855623 **[Test build #124021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124021/testReport)** for PR 28710 at commit

[GitHub] [spark] maropu commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

maropu commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-643855656 Probably, I think its better to assign this refactoring to a new JIRA id. This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

SparkQA commented on pull request #28830: URL: https://github.com/apache/spark/pull/28830#issuecomment-643855612 **[Test build #124020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124020/testReport)** for PR 28830 at commit

[GitHub] [spark] maropu commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

maropu commented on a change in pull request #28825: URL: https://github.com/apache/spark/pull/28825#discussion_r439890770 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest with

[GitHub] [spark] dongjoon-hyun commented on pull request #26901: [SPARK-29152][CORE][2.4] Executor Plugin shutdown when dynamic allocation is enabled

dongjoon-hyun commented on pull request #26901: URL: https://github.com/apache/spark/pull/26901#issuecomment-643855155 The situation is the same. There are OOM errors. ``` java.lang.OutOfMemoryError: OOM while handling another exception at

[GitHub] [spark] maropu opened a new pull request #28830: [SPARK-31990][SQL] Preserves the input order of colNames in dropDuplicates

maropu opened a new pull request #28830: URL: https://github.com/apache/spark/pull/28830 ### What changes were proposed in this pull request? This PR intends to provide a hot-fix for a bug in `Dataset.dropDuplicates`; we must preserve the input order of `colNames` for

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #26901: [SPARK-29152][CORE][2.4] Executor Plugin shutdown when dynamic allocation is enabled

dongjoon-hyun edited a comment on pull request #26901: URL: https://github.com/apache/spark/pull/26901#issuecomment-643855155 The situation is the same. There are OOM errors. -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643854260 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

HyukjinKwon commented on a change in pull request #28825: URL: https://github.com/apache/spark/pull/28825#discussion_r439889900 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] AmplabJenkins commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

AmplabJenkins commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643854260 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

AmplabJenkins removed a comment on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-643853892 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

SparkQA commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643854058 **[Test build #124019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124019/testReport)** for PR 28826 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

AmplabJenkins commented on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-643853892 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

SparkQA removed a comment on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-643826770 **[Test build #124014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124014/testReport)** for PR 28616 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #26901: [SPARK-29152][CORE][2.4] Executor Plugin shutdown when dynamic allocation is enabled

dongjoon-hyun commented on pull request #26901: URL: https://github.com/apache/spark/pull/26901#issuecomment-643853361 Unfortunately, this seems to break all `branch-2.4` Jenkins jobs again. -

[GitHub] [spark] SparkQA commented on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

SparkQA commented on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-643853412 **[Test build #124014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124014/testReport)** for PR 28616 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643786098 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins removed a comment on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643852845 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

AmplabJenkins commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643852845 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

HyukjinKwon commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643852790 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] SparkQA commented on pull request #28786: [SPARK-31925][ML] Summary.totalIterations greater than maxIters

SparkQA commented on pull request #28786: URL: https://github.com/apache/spark/pull/28786#issuecomment-643852583 **[Test build #124018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124018/testReport)** for PR 28786 at commit

[GitHub] [spark] github-actions[bot] closed pull request #27053: [WIP][SPARK-27495][Core][YARN][k8s] Stage Level Scheduling code for reference

github-actions[bot] closed pull request #27053: URL: https://github.com/apache/spark/pull/27053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] github-actions[bot] closed pull request #27375: [SPARK-30664][Web UI] Add optional metrics to all-stages page

github-actions[bot] closed pull request #27375: URL: https://github.com/apache/spark/pull/27375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

AmplabJenkins removed a comment on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-643840923 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

AmplabJenkins commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-643840923 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

SparkQA commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-643840558 **[Test build #124011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124011/testReport)** for PR 28825 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

SparkQA removed a comment on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-643809409 **[Test build #124011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124011/testReport)** for PR 28825 at commit

[GitHub] [spark] maropu commented on pull request #28826: [SPARK-31988] - schema pruning may discard attribute metadata

maropu commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643837728 Could you add some tests first? Thanks! This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] maropu commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

maropu commented on a change in pull request #28825: URL: https://github.com/apache/spark/pull/28825#discussion_r439878832 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest with

[GitHub] [spark] maropu commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…

maropu commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-643837389 For log readability, could you truncate the error messages in the PR description? Also, please add output messages after this PR applied?

<    1   2   3   4   5   >