[GitHub] [spark] SparkQA commented on pull request #28840: [SPARK-31999][SQL] Add refresh function command

SparkQA commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-645981415 **[Test build #124207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124207/testReport)** for PR 28840 at commit [`643969c`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645978800 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns having at

HeartSaVioR edited a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-645973967 Please go through the generated code for "before the patch". It's not just isNull - compiler just found it in prior. All variables children defines during codegen can

[GitHub] [spark] AmplabJenkins removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645978780 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645978780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

SparkQA commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645978330 **[Test build #124214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124214/testReport)** for PR 23531 at commit [`607aa4d`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

SparkQA removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645924795 **[Test build #124214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124214/testReport)** for PR 23531 at commit [`607aa4d`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28857: [Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

AmplabJenkins removed a comment on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-645974948 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.

AmplabJenkins removed a comment on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-645976532 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28857: [Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

AmplabJenkins commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-645976374 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.

AmplabJenkins commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-645976532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28857: Generate spark streaming test jar with maven plugin maven-jar-plugin

AmplabJenkins commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-645974948 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.

SparkQA commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-645974205 **[Test build #124204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124204/testReport)** for PR 28825 at commit [`c3bb548`](https://github.co

[GitHub] [spark] wankunde opened a new pull request #28857: Generate spark streaming test jar with maven plugin maven-jar-plugin

wankunde opened a new pull request #28857: URL: https://github.com/apache/spark/pull/28857 ### What changes were proposed in this pull request? Generate spark streaming test jar with maven plugin maven-jar-plugin ### Why are the changes needed? When I compile streaming m

[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.

SparkQA removed a comment on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-645828638 **[Test build #124204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124204/testReport)** for PR 28825 at commit [`c3bb548`](https://gi

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns having at

HeartSaVioR edited a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-645973967 Please go through the generated code for "before the patch". It's not just isNull - compiler just found it in prior. All variables children defines during codegen can

[GitHub] [spark] HeartSaVioR commented on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns having at least

HeartSaVioR commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-645973967 It's not just isNull - compiler just found it in prior. All variables children defines during codegen can be missing. --

[GitHub] [spark] cloud-fan commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

cloud-fan commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442175114 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2623,8 +2623,16 @@ object Sequenc

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442173317 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -178,59 +171,56 @@ object DateTimeUtils { *

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442172493 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -1064,14 +1065,32 @@ case class ScalaUDF(

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442171478 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -1064,14 +1065,32 @@ case class ScalaUDF(

[GitHub] [spark] MaxGekk commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

MaxGekk commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442170704 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -178,59 +171,56 @@ object DateTimeUtils { *

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442169768 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -1047,8 +1048,8 @@ case class ScalaUDF(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-645966895 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442169198 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -103,17 +102,19 @@ case class ScalaUDF( }

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-645966895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442168705 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -103,17 +102,19 @@ case class ScalaUDF( }

[GitHub] [spark] SparkQA removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

SparkQA removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-645828639 **[Test build #124205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124205/testReport)** for PR 28123 at commit [`e231268`](https://gi

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442167797 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ## @@ -103,17 +102,19 @@ case class ScalaUDF( }

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-645965970 **[Test build #124205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124205/testReport)** for PR 28123 at commit [`e231268`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442166883 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2847,6 +2848,45 @@ class Analyzer( } }

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28840: [SPARK-31999][SQL] Add refresh function command

AmplabJenkins removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-645960380 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28840: [SPARK-31999][SQL] Add refresh function command

AmplabJenkins commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-645960380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28840: [SPARK-31999][SQL] Add refresh function command

SparkQA removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-645825373 **[Test build #124201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124201/testReport)** for PR 28840 at commit [`1241bde`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28840: [SPARK-31999][SQL] Add refresh function command

SparkQA commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-645959536 **[Test build #124201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124201/testReport)** for PR 28840 at commit [`1241bde`](https://github.co

[GitHub] [spark] cloud-fan commented on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns having at least on

cloud-fan commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-645959510 If we only need to pass the `isNull` in the parameters, maybe we can use `boolean[]` so that the number of children doesn't matter? --

[GitHub] [spark] TJX2014 commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

TJX2014 commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-645958671 @cloud-fan @maropu This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442158124 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -810,36 +793,36 @@ object DateTimeUtils { }

[GitHub] [spark] juliuszsompolski commented on a change in pull request #26446: [SPARK-29393][SQL] Add `make_interval` function

juliuszsompolski commented on a change in pull request #26446: URL: https://github.com/apache/spark/pull/26446#discussion_r442157522 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala ## @@ -153,3 +153,107 @@ case clas

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442156815 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -178,59 +171,56 @@ object DateTimeUtils { *

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442156815 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -178,59 +171,56 @@ object DateTimeUtils { *

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442154988 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -178,59 +171,56 @@ object DateTimeUtils { *

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442154637 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -178,59 +171,56 @@ object DateTimeUtils { *

[GitHub] [spark] TJX2014 commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442154371 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2623,8 +2623,16 @@ object Sequence

[GitHub] [spark] cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

cloud-fan commented on a change in pull request #27617: URL: https://github.com/apache/spark/pull/27617#discussion_r442153462 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -42,49 +42,42 @@ import org.apache.spark.unsafe.

[GitHub] [spark] cloud-fan commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

cloud-fan commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r442150993 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,132 @@ +/* + * Licens

[GitHub] [spark] cloud-fan commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

cloud-fan commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r442150335 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,132 @@ +/* + * Licens

[GitHub] [spark] TJX2014 commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442148485 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2635,7 +2643,7 @@ object Sequence {

[GitHub] [spark] liucht-inspur commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons

liucht-inspur commented on pull request #28855: URL: https://github.com/apache/spark/pull/28855#issuecomment-645945188 > Hi @liucht-inspur , sorry but `branch-2.3` is no longer maintained so please close this PR? > You can see our versioning policy [here](https://spark.apache.org/versio

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

AmplabJenkins removed a comment on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-645943652 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

AmplabJenkins commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-645944138 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

AmplabJenkins commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-645943652 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] TJX2014 opened a new pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

TJX2014 opened a new pull request #28856: URL: https://github.com/apache/spark/pull/28856 ### What changes were proposed in this pull request? Add a unit test. Logical bug fix in `org.apache.spark.sql.catalyst.expressions.Sequence.TemporalSequenceImpl` ### Why are the changes n

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645941396 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645941396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645940901 **[Test build #124215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124215/testReport)** for PR 28835 at commit [`d5341ea`](https://github.com

[GitHub] [spark] HeartSaVioR commented on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns having at least

HeartSaVioR commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-645937769 Thanks for the suggestion! Based on suggestion, I've experimented with option 2, but with two arrays to copy `isNull` and `value` respectively, because the number of c

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns having at

HeartSaVioR edited a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-645937769 Thanks for the suggestion! Based on suggestion, I've experimented with option 2, but with two arrays to copy `isNull` and `value` respectively, because the numb

[GitHub] [spark] AmplabJenkins removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645925358 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645925358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

SparkQA commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645924795 **[Test build #124214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124214/testReport)** for PR 23531 at commit [`607aa4d`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-645922053 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-645922053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

SparkQA removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-645836180 **[Test build #124206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124206/testReport)** for PR 28710 at commit [`c76d591`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-645921043 **[Test build #124206 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124206/testReport)** for PR 28710 at commit [`c76d591`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645916119 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

yaooqinn commented on a change in pull request #28835: URL: https://github.com/apache/spark/pull/28835#discussion_r442111594 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala ## @@ -69,23 +89,42 @@ trait SharedTh

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645916119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645825372 **[Test build #124202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124202/testReport)** for PR 28835 at commit [`5ce343a`](https://gi

[GitHub] [spark] yaooqinn commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

yaooqinn commented on a change in pull request #28835: URL: https://github.com/apache/spark/pull/28835#discussion_r442110126 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala ## @@ -114,10 +134,29 @@ private[thri

[GitHub] [spark] SparkQA commented on pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-645914919 **[Test build #124202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124202/testReport)** for PR 28835 at commit [`5ce343a`](https://github.co

[GitHub] [spark] juliuszsompolski commented on a change in pull request #28835: [WIP][SPARK-31926][TESTS][FOLLOWUP] Fix concurrency issue for ThriftCLIService to getPortNumber

juliuszsompolski commented on a change in pull request #28835: URL: https://github.com/apache/spark/pull/28835#discussion_r442106655 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala ## @@ -114,10 +134,29 @@ priv

[GitHub] [spark] AmplabJenkins removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645911636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] AmplabJenkins commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645911631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

SparkQA commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645911575 **[Test build #124213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124213/testReport)** for PR 23531 at commit [`fc7b04a`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645911631 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

SparkQA removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645901979 **[Test build #124213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124213/testReport)** for PR 23531 at commit [`fc7b04a`](https://gi

[GitHub] [spark] SparkQA commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

SparkQA commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645901979 **[Test build #124213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124213/testReport)** for PR 23531 at commit [`fc7b04a`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins removed a comment on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645898508 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

AmplabJenkins commented on pull request #23531: URL: https://github.com/apache/spark/pull/23531#issuecomment-645898508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] attilapiros commented on a change in pull request #28848: [SPARK-32003][CORE] Unregister outputs for executor on fetch failure …

attilapiros commented on a change in pull request #28848: URL: https://github.com/apache/spark/pull/28848#discussion_r442079384 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -540,6 +540,43 @@ class DAGSchedulerSuite extends SparkFun

[GitHub] [spark] AngersZhuuuu commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

AngersZh commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-645882347 Yea, have a common SQL standard is important. Everyone has a different level of knowledge about SQL. This pr is useful for people who use Teradata and want to migrate S

[GitHub] [spark] bart-samwel commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

bart-samwel commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-645877735 > Got the point, may be this is why Teradata add a QUALIFY clause to support direct filter by window function. Yeah, and I'm not saying that it isn't useful in some ca

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28831: [SPARK-31993][SQL] Evaluate children code whenever needed in both varargCounts/varargBuilds for 'concat_ws' with columns havi

HeartSaVioR commented on a change in pull request #28831: URL: https://github.com/apache/spark/pull/28831#discussion_r442065192 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -123,26 +123,41 @@ case class Conca

[GitHub] [spark] AngersZhuuuu commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

AngersZh commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-645872712 > @AngersZh This is problematic because the `WHERE` clause comes _before_ the `GROUP BY` clause, but window functions (and the `SELECT`) are evaluated _after_ the GROUP

[GitHub] [spark] bart-samwel commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

bart-samwel commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-645871329 @AngersZh This is problematic because the `WHERE` clause comes *before* the `GROUP BY` clause, but window functions (and the `SELECT`) are evaluated *after* the GROUP BY

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

AmplabJenkins removed a comment on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-645866077 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124

[GitHub] [spark] SparkQA removed a comment on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

SparkQA removed a comment on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-645850639 **[Test build #124209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124209/testReport)** for PR 28804 at commit [`2b3704b`](https://gi

[GitHub] [spark] AngersZhuuuu commented on pull request #28836: [SPARK-31561][SQL] Add QUALIFY Clause

AngersZh commented on pull request #28836: URL: https://github.com/apache/spark/pull/28836#issuecomment-645865809 @bart-samwel @HyukjinKwon @gatorsmile One confuse, why we can't support window function in Filter condition? Support SQL like this can make some SQL more readable

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

AmplabJenkins removed a comment on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-645866064 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

AmplabJenkins commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-645866064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

SparkQA commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-645866010 **[Test build #124209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124209/testReport)** for PR 28804 at commit [`2b3704b`](https://github.co

[GitHub] [spark] sarutak commented on pull request #28855: [SPARK-31871][CORE][WEBUI][2.3] History page and Executors tab page show the correct sort icons

sarutak commented on pull request #28855: URL: https://github.com/apache/spark/pull/28855#issuecomment-645864667 Hi @liucht-inspur , sorry but `branch-2.3` is no longer maintained so please close this PR? You can see our versioning policy [here](https://spark.apache.org/versioning-polic

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

AmplabJenkins removed a comment on pull request #28645: URL: https://github.com/apache/spark/pull/28645#issuecomment-645862512 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

AmplabJenkins removed a comment on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-645862552 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

AmplabJenkins commented on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-645862552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

AmplabJenkins commented on pull request #28645: URL: https://github.com/apache/spark/pull/28645#issuecomment-645862512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] Ngone51 commented on pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

Ngone51 commented on pull request #28645: URL: https://github.com/apache/spark/pull/28645#issuecomment-645862058 Hi all, sorry for the delay. I've updated PR according to your suggestions. Please take another look, thanks! T

[GitHub] [spark] maropu commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.

maropu commented on pull request #28825: URL: https://github.com/apache/spark/pull/28825#issuecomment-645861578 LGTM. Pending Jenkins. Thanks, @dilipbiswal ! This is an automated message from the Apache Git Service. To respon

[GitHub] [spark] SparkQA commented on pull request #28853: [SPARK-32019][SQL] Add spark.sql.files.minPartitionNum config

SparkQA commented on pull request #28853: URL: https://github.com/apache/spark/pull/28853#issuecomment-645861803 **[Test build #124211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124211/testReport)** for PR 28853 at commit [`8f9b1c1`](https://github.com

<    2   3   4   5   6   7   8   >