[GitHub] [spark] cloud-fan commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

cloud-fan commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512451640 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala ## @@ -171,18 +178,42 @@ trait WindowExecBase extends

[GitHub] [spark] cloud-fan commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

cloud-fan commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512451428 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala ## @@ -58,7 +58,7 @@ import org.apache.spark.sql.types.{Ca

[GitHub] [spark] cloud-fan commented on a change in pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

cloud-fan commented on a change in pull request #29800: URL: https://github.com/apache/spark/pull/29800#discussion_r512450768 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -355,6 +344,36 @@ abstract class Offs

[GitHub] [spark] HeartSaVioR edited a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

HeartSaVioR edited a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717022097 Sorry but your latest change doesn't actually lock properly. Long is immutable, and you always replace the object when you do the calculation and assign to the field,

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717023200 > Sorry but your latest change doesn't actually lock properly. Long is immutable, and you always replace the object when you do the calculation and assign to the field, whi

[GitHub] [spark] HeartSaVioR edited a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

HeartSaVioR edited a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717022097 Sorry but your latest change doesn't actually lock properly. Long is immutable, and you always replace the object when you do the calculation and assign to the field,

[GitHub] [spark] HeartSaVioR commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

HeartSaVioR commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717022097 Sorry but your latest change doesn't actually lock properly. Long is immutable, and you always replace the object when you do the calculation, which is used as a lock. Your

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717019830 > Hmmm. Every update to `chunkSent` and `chunkBeingSent` will compete for the lock on object `totalChunksBeingTransferred` We reduce many race condition on `streams`

[GitHub] [spark] SparkQA commented on pull request #29800: [SPARK-32934][SQL] Improve the performance for NTH_VALUE and reactor the OffsetWindowFunction

SparkQA commented on pull request #29800: URL: https://github.com/apache/spark/pull/29800#issuecomment-717017189 **[Test build #130318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130318/testReport)** for PR 29800 at commit [`cde6170`](https://github.com

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh edited a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717016273 > Hmmm. Every update to `chunkSent` and `chunkBeingSent` will compete for the lock on object `totalChunksBeingTransferred` if we add the `synchronize(totalChunksBein

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717016273 > Hmmm. Every update to `chunkSent` and `chunkBeingSent` will compete for the lock on object `totalChunksBeingTransferred` if we add the `synchronize(totalChunksBeingTransf

[GitHub] [spark] SparkQA commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

SparkQA commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717013857 **[Test build #130316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130316/testReport)** for PR 30139 at commit [`a32d6f3`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-717013900 **[Test build #130317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130317/testReport)** for PR 29882 at commit [`df9b54f`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717013113 > Yes we should ensure the streamState and the totalChunksBeingTransfered are updated synchronically. Other than that the PR looks good! How about current change? Don

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh commented on a change in pull request #30139: URL: https://github.com/apache/spark/pull/30139#discussion_r512439581 ## File path: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java ## @@ -43,6 +43,7 @@ private fina

[GitHub] [spark] otterc commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

otterc commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717008775 > > This should have a considerable impact on the performance when there are multiple open streams because updates of different streams would lock on a single object `totalChunks

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh edited a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717004690 > This should have a considerable impact on the performance when there are multiple open streams because updates of different streams would lock on a single object `

[GitHub] [spark] AngersZhuuuu commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

AngersZh commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717004690 > This should have a considerable impact on the performance when there are multiple open streams because updates of different streams would lock on a single object `totalCh

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-717003726 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-717003715 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-717003715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716943464 **[Test build #130310 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130310/testReport)** for PR 29882 at commit [`8d021f2`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-717003382 **[Test build #130310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130310/testReport)** for PR 29882 at commit [`8d021f2`](https://github.co

[GitHub] [spark] otterc edited a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

otterc edited a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717001727 > IMO, we can add a lock to keep strong consistence of value `totalChunksBeingTransferred`, such as > ![image](https://user-images.githubusercontent.com/46485123/971268

[GitHub] [spark] otterc edited a comment on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

otterc edited a comment on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717001727 > IMO, we can add a lock to keep strong consistence of value `totalChunksBeingTransferred`, such as > ![image](https://user-images.githubusercontent.com/46485123/971268

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AmplabJenkins removed a comment on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-717001693 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] otterc commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

otterc commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-717001727 > IMO, we can add a lock to keep strong consistence of value `totalChunksBeingTransferred`, such as > ![image](https://user-images.githubusercontent.com/46485123/97126839-

[GitHub] [spark] AmplabJenkins commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

AmplabJenkins commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-717001693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

SparkQA removed a comment on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-716919084 **[Test build #130305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130305/testReport)** for PR 30145 at commit [`5cbe261`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716993407 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less th

AmplabJenkins removed a comment on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716994456 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] SparkQA commented on pull request #30145: [SPARK-33233][SQL]CUBE/ROLLUP/GROUPING SETS support GROUP BY ordinal

SparkQA commented on pull request #30145: URL: https://github.com/apache/spark/pull/30145#issuecomment-717000940 **[Test build #130305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130305/testReport)** for PR 30145 at commit [`5cbe261`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716993401 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716957289 **[Test build #130313 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130313/testReport)** for PR 29882 at commit [`4b1fac4`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

AmplabJenkins removed a comment on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716991805 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less th

AmplabJenkins removed a comment on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716991999 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

SparkQA removed a comment on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716941185 **[Test build #130309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130309/testReport)** for PR 30126 at commit [`d8d78c7`](https://gi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30155: [SPARK-33231][CORE] Make pod allocation executor timeouts configurable

dongjoon-hyun commented on a change in pull request #30155: URL: https://github.com/apache/spark/pull/30155#discussion_r512430454 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala ## @@ -227,6 +227,14 @@ private[spark] obje

[GitHub] [spark] jiangxb1987 commented on a change in pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

jiangxb1987 commented on a change in pull request #30139: URL: https://github.com/apache/spark/pull/30139#discussion_r512428514 ## File path: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java ## @@ -43,6 +43,7 @@ private final

[GitHub] [spark] jiangxb1987 commented on pull request #30139: [SPARK-31069][CORE] high cpu caused by chunksBeingTransferred in external shuffle service

jiangxb1987 commented on pull request #30139: URL: https://github.com/apache/spark/pull/30139#issuecomment-716996105 Yes we should ensure the streamState and the totalChunksBeingTransfered are updated synchronically. Other than that the PR looks good! -

[GitHub] [spark] otterc commented on a change in pull request #30062: [SPARK-32916][SHUFFLE] Implementation of shuffle service that leverages push-based shuffle in YARN deployment mode

otterc commented on a change in pull request #30062: URL: https://github.com/apache/spark/pull/30062#discussion_r512427399 ## File path: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java ## @@ -94,6 +95,9 @@ static final String STOP_ON_

[GitHub] [spark] baohe-zhang commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

baohe-zhang commented on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716994448 Thanks for the review! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716994436 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34917/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schem

AmplabJenkins commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716994452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716993401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716993220 **[Test build #130313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130313/testReport)** for PR 29882 at commit [`4b1fac4`](https://github.co

[GitHub] [spark] HeartSaVioR closed pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

HeartSaVioR closed pull request #30126: URL: https://github.com/apache/spark/pull/30126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] HeartSaVioR commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

HeartSaVioR commented on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716992502 Thanks for your contribution! Merged into master. This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schem

AmplabJenkins commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716991999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716991989 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34916/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

AmplabJenkins commented on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716991805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

SparkQA commented on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716990746 **[Test build #130309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130309/testReport)** for PR 30126 at commit [`d8d78c7`](https://github.co

[GitHub] [spark] huaxingao commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

huaxingao commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-716987003 cc @cloud-fan @maropu @MaxGekk @ScrapCodes This is an automated message from the Apache Git Service. To respo

[GitHub] [spark] huaxingao commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

huaxingao commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r512420953 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -123,8 +123,14 @@ class JDBCTable

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716985469 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34917/ -

[GitHub] [spark] brkyvz commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2

brkyvz commented on a change in pull request #28027: URL: https://github.com/apache/spark/pull/28027#discussion_r512364187 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -880,6 +880,12 @@ case class Subqu

[GitHub] [spark] HyukjinKwon closed pull request #30149: [SPARK-33243][PYTHON][BUILD] Add numpydoc into documentation dependency

HyukjinKwon closed pull request #30149: URL: https://github.com/apache/spark/pull/30149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] HyukjinKwon commented on pull request #30149: [SPARK-33243][PYTHON][BUILD] Add numpydoc into documentation dependency

HyukjinKwon commented on pull request #30149: URL: https://github.com/apache/spark/pull/30149#issuecomment-716983027 Thank you guys. Merged to master. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716980240 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34916/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716976768 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716976768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716976751 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34915/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716971469 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] AmplabJenkins commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716971465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716971453 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34914/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716971465 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716970441 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34915/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

AmplabJenkins removed a comment on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-716969855 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716970169 **[Test build #130315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130315/testReport)** for PR 30156 at commit [`8a18234`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

AmplabJenkins commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-716969855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

SparkQA removed a comment on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-716923554 **[Test build #130306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130306/testReport)** for PR 30154 at commit [`edf98d0`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

SparkQA commented on pull request #30154: URL: https://github.com/apache/spark/pull/30154#issuecomment-716969187 **[Test build #130306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130306/testReport)** for PR 30154 at commit [`edf98d0`](https://github.co

[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then

AngersZh edited a comment on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716948446 > @AngersZh, shall we add a note in the migration guide as well? Yea， update later Updated ping @HyukjinKwon -

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716968009 **[Test build #130314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130314/testReport)** for PR 30156 at commit [`710a672`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

AmplabJenkins removed a comment on pull request #30097: URL: https://github.com/apache/spark/pull/30097#issuecomment-716966266 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

AmplabJenkins commented on pull request #30097: URL: https://github.com/apache/spark/pull/30097#issuecomment-716966266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

SparkQA commented on pull request #30097: URL: https://github.com/apache/spark/pull/30097#issuecomment-716966253 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34913/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716964540 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716964755 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34914/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins removed a comment on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716964537 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

AmplabJenkins commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716964537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716964525 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34912/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

AmplabJenkins removed a comment on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716962002 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r512385606 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -27,7 +27,8 @@ import org.apache.spark.sq

[GitHub] [spark] SparkQA commented on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

SparkQA commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716944717 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34909/ -

[GitHub] [spark] SparkQA commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

SparkQA commented on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716961983 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34911/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30126: [SPARK-33215][WEBUI] Speed up event log download by skipping UI rebuild

AmplabJenkins commented on pull request #30126: URL: https://github.com/apache/spark/pull/30126#issuecomment-716962002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less th

AmplabJenkins removed a comment on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716959526 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schema size

SparkQA commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716959519 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34910/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30156: [SPARK-33248][SQL] Add a configuration to control the legacy behavior of whether need to pad null value when value size less then schem

AmplabJenkins commented on pull request #30156: URL: https://github.com/apache/spark/pull/30156#issuecomment-716959526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716950593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716950585 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716950585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

SparkQA commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716950572 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34909/ ---

[GitHub] [spark] SparkQA commented on pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

SparkQA commented on pull request #30097: URL: https://github.com/apache/spark/pull/30097#issuecomment-716958410 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34913/ -

[GitHub] [spark] SparkQA commented on pull request #29882: [SPARK-33008][SQL] Division by zero on divide-like operations returns incorrect result

SparkQA commented on pull request #29882: URL: https://github.com/apache/spark/pull/29882#issuecomment-716950296 **[Test build #130312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130312/testReport)** for PR 29882 at commit [`14c45e9`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716949776 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716949779 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130

[GitHub] [spark] SparkQA removed a comment on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

SparkQA removed a comment on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716929003 **[Test build #130307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130307/testReport)** for PR 28938 at commit [`e1ae2e7`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28938: [WIP][SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

AmplabJenkins commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-716949776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

  1   2   3   4   5   6   7   8   >