[GitHub] spark issue #18888: [Spark-17025][ML][Python] Persistence for Pipelines with...

2017-08-11 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/1 @jkbradley Quick reminder to merge this since the tests have passed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132597367 --- Diff: python/pyspark/ml/pipeline.py --- @@ -242,3 +327,65 @@ def _to_java(self): JavaParams._new_java_obj

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Pipelin...

2017-08-10 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r132595823 --- Diff: python/pyspark/ml/tests.py --- @@ -1142,6 +1142,35 @@ def test_nested_pipeline_persistence(self): except OSError

[GitHub] spark issue #18888: [Spark-17025][ML][Python] Persistence for Pipelines with...

2017-08-08 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/1 @jkbradley @MrBago @WeichenXu123 Can you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #18888: [Spark-17025][ML][Python] Persistence for Custom ...

2017-08-08 Thread ajaysaini725
GitHub user ajaysaini725 opened a pull request: https://github.com/apache/spark/pull/1 [Spark-17025][ML][Python] Persistence for Custom Python-only Pipelines ## What changes were proposed in this pull request? Implemented a Python-only persistence framework for

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-07 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131781393 --- Diff: python/pyspark/ml/tests.py --- @@ -1158,6 +1165,33 @@ def test_decisiontree_regressor(self): except OSError

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-02 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131028435 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -375,6 +375,18 @@ def copy(self, extra=None): that._defaultParamMap

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-02 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r131017418 --- Diff: python/pyspark/ml/util.py --- @@ -61,32 +66,82 @@ def _randomUID(cls): @inherit_doc -class MLWriter(object): +class

[GitHub] spark pull request #18746: [ML][Python] Implemented UnaryTransformer in Pyth...

2017-08-01 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r130775557 --- Diff: python/pyspark/ml/base.py --- @@ -116,3 +121,44 @@ class Model(Transformer): """ __metacl

[GitHub] spark pull request #18746: [ML][Python] Implemented UnaryTransformer in Pyth...

2017-08-01 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18746#discussion_r130775517 --- Diff: python/pyspark/ml/base.py --- @@ -116,3 +121,44 @@ class Model(Transformer): """ __metacl

[GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...

2017-08-01 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18742#discussion_r130741050 --- Diff: python/pyspark/ml/util.py --- @@ -283,3 +289,124 @@ def numFeatures(self): Returns the number of features the model was trained

[GitHub] spark issue #18746: Implemented UnaryTransformer in Python

2017-07-26 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18746 @jkbradley @thunterdb @MrBago Could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #18746: Implemented UnaryTransformer in Python

2017-07-26 Thread ajaysaini725
GitHub user ajaysaini725 opened a pull request: https://github.com/apache/spark/pull/18746 Implemented UnaryTransformer in Python ## What changes were proposed in this pull request? Implemented UnaryTransformer in Python (Please fill in changes proposed in this fix

[GitHub] spark issue #18742: Python persistence helper functions

2017-07-26 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18742 @jkbradley @thunterdb @MrBago Could you please review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #18742: Python persistence helper functions

2017-07-26 Thread ajaysaini725
GitHub user ajaysaini725 opened a pull request: https://github.com/apache/spark/pull/18742 Python persistence helper functions ## What changes were proposed in this pull request? Added DefaultParamsWriteable, DefaultParamsReadable, DefaultParamsWriter, and

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-07-14 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r127558107 --- Diff: python/pyspark/ml/tests.py --- @@ -1229,11 +1229,30 @@ def test_output_columns(self): (2.0

[GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...

2017-07-14 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18281#discussion_r127557890 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala --- @@ -101,6 +101,50 @@ class OneVsRestSuite extends

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-07-07 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18281 @BryanCutler @MLnick @jkbradley I pushed another update based on comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #18428: [Spark-21221][ML] CrossValidator and TrainValidat...

2017-07-06 Thread ajaysaini725
Github user ajaysaini725 commented on a diff in the pull request: https://github.com/apache/spark/pull/18428#discussion_r126014344 --- Diff: python/pyspark/ml/classification.py --- @@ -1630,8 +1614,52 @@ def _to_java(self): _java_obj.setPredictionCol

[GitHub] spark issue #18428: [ML] CrossValidator and TrainValidationSplit Persist Nes...

2017-06-26 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18428 @jkbradley @thunterdb Could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #18428: [ML] CrossValidator and TrainValidationSplit Pers...

2017-06-26 Thread ajaysaini725
GitHub user ajaysaini725 opened a pull request: https://github.com/apache/spark/pull/18428 [ML] CrossValidator and TrainValidationSplit Persist Nested Estimators ## What changes were proposed in this pull request? Added functionality for CrossValidator and

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-23 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18281 Also @BryanCutler just pushed an updated PR based on your comments. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-23 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18281 @BryanCutler What is the point of having the function getExectionContext() take a parameter maxThreads? Isn't it just supposed to use the parallelism parameter when determining what exec

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-22 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18281 @BryanCutler Could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-22 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18281 Quick comment about my update. As per a discussion earlier I had the OneVsRest class extend the trait ParallelismParam because the parallelism parameter is only relevant to the training of

[GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-06-12 Thread ajaysaini725
Github user ajaysaini725 commented on the issue: https://github.com/apache/spark/pull/18281 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18281: Added tunable parallelism to the pyspark implemen...

2017-06-12 Thread ajaysaini725
GitHub user ajaysaini725 opened a pull request: https://github.com/apache/spark/pull/18281 Added tunable parallelism to the pyspark implementation of one vs. re… …st classification. Added a parallelism parameter to the scala implementation of one vs. rest for python persistence