Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12488#issuecomment-213318725
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12569#discussion_r60704478
--- Diff: docs/programming-guide.md ---
@@ -1328,12 +1328,18 @@ value of the broadcast variable (e.g. if the
variable is shipped to a new node l
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60703167
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60702856
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60702234
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -51,11 +88,8 @@ private[spark] object Signaling extends Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60701708
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60701640
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60701416
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60700835
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -51,11 +88,8 @@ private[spark] object Signaling extends Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60700632
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -51,11 +88,8 @@ private[spark] object Signaling extends Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12605#discussion_r60700548
--- Diff: core/src/main/scala/org/apache/spark/util/SignalUtils.scala ---
@@ -31,14 +31,51 @@ import org.apache.spark.internal.Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60700147
--- Diff: core/src/main/scala/org/apache/spark/util/Signaling.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60700120
--- Diff: core/src/main/scala/org/apache/spark/util/SignalLogger.scala ---
@@ -17,44 +17,20 @@
package org.apache.spark.util
-import
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r6064
--- Diff: core/src/main/scala/org/apache/spark/util/Signaling.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60700056
--- Diff: core/src/main/scala/org/apache/spark/util/SignalLogger.scala ---
@@ -17,44 +17,20 @@
package org.apache.spark.util
-import
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60699904
--- Diff: core/src/main/scala/org/apache/spark/util/SignalLogger.scala ---
@@ -17,44 +17,20 @@
package org.apache.spark.util
-import
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213185109
Fair enough, test:compile is alright too. I would just avoid compile:compile
On Apr 21, 2016 5:48 PM, "Reynold Xin" <notificati...@github.com> wrot
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213176921
Hmm, maybe you need to add the project or config too? As in "set
lintOnCompile in project in Config := true"? Sbt isn't too friendly when
setting command li
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213159613
As a follow up to @vanzin's comment:
> It'd be nice if you could disable or enable the checks inside an existing
sbt session, instead of having to exit
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213157715
Thanks for looking into this, I constantly forget to run the style checker.
Since you change the dependencies of `compile`, it would be great to still
have
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60668996
--- Diff: core/src/main/scala/org/apache/spark/util/Signaling.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60668957
--- Diff: core/src/main/scala/org/apache/spark/util/Signaling.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60626992
--- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60625828
--- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60536594
--- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12557#issuecomment-212781850
Test failure is from hive, seems unrelated.
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12557#discussion_r60535063
--- Diff: repl/src/main/scala/org/apache/spark/repl/Signaling.scala ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12524#issuecomment-212754822
is this related to #12436 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/12557
Allow interrupting tasks in repl with Ctrl+C
## What changes were proposed in this pull request?
Improve signal handling to allow interrupting running tasks from the REPL
(with Ctrl+C
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/8216#issuecomment-212604610
Should signal handling really be implemented in a JobWaiter? I'm afraid
that implementing it there could have unwanted consequences for non-shell
operation: Imagine
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/8216#issuecomment-212014322
That would indeed be a cool feature to have! I'll give it a shot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12149#issuecomment-205608996
I think it should be good to merge then, we can always revisit the code in
case macro support should ever be implemented
---
If your project is set up for it, you
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12149#issuecomment-205420812
just a nitpick: I think "Use Scala reflection for UD**T**s" would be a
better title (I also always mix both of them up ;))
---
If your project is set up f
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12149#issuecomment-205419739
As far as I know, macros currently aren't used for catalyst reflection and
as you point out, would likely fail anyway for user defined types.
The question
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11681#issuecomment-204177309
FYI, I have two PRs pending to get the genjavadoc changes merged into
upstream. I haven't had any feedback yet so if anyone wants to have a look
please do typesafehub
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11808#issuecomment-198169176
Is this meant to be a PR? Looking at the code, it seems more like a wok
progress.
Mind closing and reopening once its ready?
---
If your project is set up
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11789#issuecomment-198110568
> 1.49 is the number I found with this cast issue, there may be more.
This is a fundamentally related to binary representation, lots of decimal
numb
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11708#issuecomment-197495548
it's due to the way arrays are handled in option types (as classes). I'm
working on a fix
---
If your project is set up for it, you can reply to this email and have
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11708#issuecomment-197596487
@rxin, your patch should work on top of this commit now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11808#issuecomment-198177937
Ok, but it seems somewhat premature to open a PR. Maybe you could add a
[WIP] into the title?
---
If your project is set up for it, you can reply to this email
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11797#issuecomment-198144488
I agree there are discrepancies between the intended meaning of annotations
and access modifiers, however my reaction would be to keep everything private
and make
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11708#issuecomment-197191785
Update: there is actually an issue, please see updates description
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11708#discussion_r56289475
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
---
@@ -152,6 +152,8 @@ class
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11708#discussion_r56289468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -476,7 +476,7 @@ object ScalaReflection extends
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/11708
[SPARK-13118][SQL] Regression test for package objects
## What changes were proposed in this pull request?
Add regression test for Dataset's handling of classes defined in package
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55908688
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195208607
It can also be that jenkins is busy. If the test doesn't start in a couple
of hours it would probably be best to contact one of the committers, maybe Sean
Owen since
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195207520
Jenkins has been behaving weirdly lately (at least for me). Lets try again
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195207537
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195012502
Looks good to me now. Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-194050736
@rxin Looks like finally everything passed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55442441
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55438396
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11588#issuecomment-193987942
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/11588
[SPARK-7286] [SQL] Deprecate !== in favour of =!=
*This PR replaces #9925 which had issues with CI. **Please see the original
PR for any previous discussions.***
## What changes were
Github user jodersky closed the pull request at:
https://github.com/apache/spark/pull/9925
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193985859
Closing this PR, will reopen a new one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193955460
Jenkins now seems to be stuck on a build :(
@rxin, should I close this PR and create a new one, would this fix the
Jenkins response issues?
---
If your project
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11547#issuecomment-193521102
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11547#issuecomment-193517578
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11547#discussion_r55284873
--- Diff: examples/src/main/python/ml/train_validation_split.py ---
@@ -0,0 +1,68 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11560#issuecomment-193480541
LGTM, a quick grep for jblas showed that every last reference to it is now
gone.
---
If your project is set up for it, you can reply to this email and have your
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11379#issuecomment-193477066
Seems unrelated and works locally. Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55278991
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55278924
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-193470576
You create TaskMetrics twice (see my code comments). I'm not sure of the
actual impact, but it looks as though a duplicate is not needed.
---
If your project is set
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11379#issuecomment-193432458
It was actually a missing comma in an sbt file (MimaExcludes.scala in
project/). Arguably a syntax error can be considered bad style ;)
---
If your project is set up
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11379#issuecomment-193410049
Whoops! Thanks for reminding me about the usefulness of testing, jenkins :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11379#issuecomment-193405399
Latest commit only fixes a conflict in MiMa exclusion rules. Retesting
should not be needed.
---
If your project is set up for it, you can reply to this email
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-193398954
@JoshRosen, sorry to bother you again. Jenkins is ignoring my requests,
could it be that I'm not white-listed anymore?
---
If your project is set up for it, you can
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192557030
Another use of !== had managed to slip in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192557039
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192541637
Thanks! Do you know what was the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192533968
@JoshRosen, do you know why Jenkins isn't building this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192379806
What's up with jenkins? retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-192013276
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191989183
alright
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191984303
Seems that some tests have added !== in the mean-time, I'll update the
references
---
If your project is set up for it, you can reply to this email and have your
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191926912
Btw, a general question, do you want me to squash commits as I ammend them
to PRs?
---
If your project is set up for it, you can reply to this email and have your
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-191926014
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/10760#issuecomment-189043337
cc @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/9925#issuecomment-189042474
Is this still under consideration? I have no problem closing the issue if
you think it's not a good enough solution.
---
If your project is set up for it, you can
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11379#discussion_r54185547
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala ---
@@ -50,11 +50,8 @@ abstract class UserDefinedType[UserType
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11379#discussion_r54185320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/UserDefinedType.scala ---
@@ -50,11 +50,8 @@ abstract class UserDefinedType[UserType
GitHub user jodersky opened a pull request:
https://github.com/apache/spark/pull/11379
[SPARK-11011][SQL] Narrow type of UDT serialization
## What changes were proposed in this pull request?
Narrow down the parameter type of `UserDefinedType#serialize()`. Currently
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r52958711
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/XXH64Suite.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r52956164
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/XXH64Suite.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11209#discussion_r52956130
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/XXH64Suite.java
---
@@ -0,0 +1,159 @@
+/*
+ * Licensed
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11098#discussion_r52355246
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -516,7 +517,7 @@ private[spark] object Utils extends Logging
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52230832
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52230982
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52214076
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52214655
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -39,7 +39,7 @@ case class UnsubscribeReceiver
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-181538552
Agreed, I also just compared it with the SynchronizedQueue sources and
behaviour should be identical. looks good
---
If your project is set up for it, you can reply
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52214846
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/10984#issuecomment-181524146
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52213895
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -18,7 +18,7 @@
// scalastyle:off println
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/3#discussion_r52237857
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/ActorWordCount.scala
---
@@ -63,11 +63,11 @@ class FeederActor extends Actor
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/3#issuecomment-181612945
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11098#issuecomment-181114099
Ack. Do you want me to reword my commits too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
101 - 200 of 278 matches
Mail list logo
