Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64552539
--- Diff:
core/src/test/scala/org/apache/spark/ui/storage/StorageTabSuite.scala ---
@@ -179,6 +179,25 @@ class StorageTabSuite extends SparkFunSuite
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64545642
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64448718
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64446719
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64365075
--- Diff:
core/src/test/scala/org/apache/spark/ui/storage/StorageTabSuite.scala ---
@@ -179,6 +179,25 @@ class StorageTabSuite extends SparkFunSuite
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64364913
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64354687
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener
GitHub user lgieron opened a pull request:
https://github.com/apache/spark/pull/13264
SPARK-9044 Fix "Storage" tab in UI so that it reflects RDD name change.
## What changes were proposed in this pull request?
1. Making 'name' field of RDDInfo muta
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/11396#discussion_r54350209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -992,6 +992,9 @@ case class FormatNumber(x
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/11396#discussion_r54350183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -992,6 +992,9 @@ case class FormatNumber(x
Github user lgieron commented on the pull request:
https://github.com/apache/spark/pull/11396#issuecomment-189874904
@zsxwing Can you please make Jenkins rerun the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lgieron commented on a diff in the pull request:
https://github.com/apache/spark/pull/11396#discussion_r54339929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -992,6 +992,9 @@ case class FormatNumber(x
Github user lgieron commented on the pull request:
https://github.com/apache/spark/pull/11396#issuecomment-189729808
@srowen The build failed due to unrelated test failing
(https://issues.apache.org/jira/browse/SPARK-13530). The fix was committed to
master an hour ago and now
Github user lgieron commented on the pull request:
https://github.com/apache/spark/pull/11396#issuecomment-189419086
@srowen I've cleaned up the code as per your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lgieron commented on the pull request:
https://github.com/apache/spark/pull/11396#issuecomment-189414225
@srowen I went through all other uses of `DecimalFormat` and `NumberFormat`
across all subprojects - they all look correct.
---
If your project is set up for it, you
Github user lgieron commented on the pull request:
https://github.com/apache/spark/pull/11396#issuecomment-189393407
@zsxwing This class is the backend for `format_number` SQL function, which
is supposed to be locale-independent.
---
If your project is set up for it, you can reply
Github user lgieron commented on the pull request:
https://github.com/apache/spark/pull/11396#issuecomment-189384716
@zsxwing My understanding is that FormatNumber is used in SQL parser, hence
it should conform to the language standard (which only permits dot as a
separator
GitHub user lgieron opened a pull request:
https://github.com/apache/spark/pull/11396
[SPARK-13515] Make FormatNumber work irrespective of locale.
## What changes were proposed in this pull request?
Change in class FormatNumber to make it work irrespective of locale
18 matches
Mail list logo
