Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13604
I'd prefer change `SparkSession.range`'s return type to `Dataset[Row]` for
better consistency, also there's an annoying nullability issue regarding to
`Dataset[java.lang.Long]` (boxed types
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13496
LGTM, merging to master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/12836
@NarineK @shivaram Sorry for the late reply. Overriding `stringArgs` is the
correct solution for this issue.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13592
[SPARK-15863][SQL][DOC] Initial SQL programming guide update for Spark 2.0
## What changes were proposed in this pull request?
Initial SQL programming guide update for Spark 2.0
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13535
LGTM, merging to master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13529
Merging to master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13529
@cloud-fan I think we can also disable `EmbedSerializerInFilter` now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13529
LGTM except for a minor comment, and pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13529#discussion_r65991558
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TypedFilterOptimizationSuite.scala
---
@@ -57,7 +57,9 @@ class
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13535
The PR description says the verbosity mark affects output of "physical
plan", but actually only aggregate operators are affected. Please correct the
PR description and add that expl
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13535#discussion_r65987602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -190,6 +190,9 @@ abstract class Expression
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13529
@rxin By "ignore" did you mean remove the rule from the batch but keep the
code lines of the rule?
---
If your project is set up for it, you can reply to this email and have your
re
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13535#discussion_r65986824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -201,24 +201,26 @@ class QueryExecution(val sparkSession
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13529#discussion_r65986359
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1961,11 +1961,11 @@ class Dataset[T] private[sql
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13529#discussion_r65986406
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1961,11 +1961,11 @@ class Dataset[T] private[sql
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13401
LGTM, merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13469
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13474
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13469
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13269
So there will be a follow-up for replacing `BoundReference` in serializer
expressions with `GetColumnByOrdinal`, right?
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13469#discussion_r65751003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -519,7 +519,7 @@ case class
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13474
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13269
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13469
Let's wait for #13269 first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13474
Let's wait for #13269 first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13463
LGTM, merging to master and branch-2.0. Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13470
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13269
Just rebased this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13485
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13485#discussion_r65644479
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -582,6 +582,11 @@ object ScalaReflection extends
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13474
LGTM, but shall we merge #13269 first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13469
LGTM except for minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13469#discussion_r65643574
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -519,7 +519,7 @@ case class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13469#discussion_r65643583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -675,7 +675,7 @@ case class AssertNotNull
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13469#discussion_r65643344
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -52,8 +52,15 @@ object ExpressionEncoder
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13470
... pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13470
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13485
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/11632
Shall we close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65638928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1884,10 +1884,63 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65638864
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1884,10 +1884,63 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65639249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -191,6 +189,26 @@ case class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65637841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1884,10 +1884,63 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65637799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1884,10 +1884,63 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65636002
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,20 @@ abstract class TreeNode[BaseType
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13471
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13455
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13451
@andrewor14 Could you please help sign off this one? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65613435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
---
@@ -57,7 +57,13 @@ case class LocalRelation
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65612485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala
---
@@ -84,39 +84,12 @@ class ListingFileCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65612284
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala
---
@@ -84,39 +84,12 @@ class ListingFileCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13463#discussion_r65611847
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala
---
@@ -84,39 +84,12 @@ class ListingFileCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65610289
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13471
LGTM except for minor naming issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65609750
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/LocalTableScanExec.scala
---
@@ -48,6 +48,14 @@ private[sql] case class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13471#discussion_r65609589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
---
@@ -57,7 +57,13 @@ case class LocalRelation
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65604769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65604658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65596454
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13470#discussion_r65595938
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -427,13 +427,21 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65492813
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1884,10 +1884,62 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65492290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1884,10 +1884,62 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65485798
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala
---
@@ -208,7 +209,7 @@ object Encoders {
BoundReference(0
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13290
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r65460601
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoders.scala
---
@@ -208,7 +209,7 @@ object Encoders {
BoundReference(0
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13425
LGTM, merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13450
Merging to branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13270
Merging to master and branch-2.0.
@xwu0226 @yhuai Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13455
[SPARK-15719][SQL] Disables writing Parquet summary files by default
## What changes were proposed in this pull request?
This PR disables writing Parquet summary files by default (i.e
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13433
LGTM except for two minor issues, and pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13433#discussion_r65450866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -467,9 +470,11 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13433#discussion_r65450329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,9 +424,12 @@ abstract class TreeNode[BaseType
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13450
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13280
I'm working on verifying the regression using the micro benchmark I did
before. Sorry for the troubles.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13431
Thanks for the review! Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13431#discussion_r65305773
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala
---
@@ -96,16 +96,23 @@ class TextFileFormat
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13431
[SPARK-14343][SQL] Proper column pruning for text data source
## What changes were proposed in this pull request?
Text data source ignores requested schema, and may give wrong result
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13290
LGTM except for a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13290#discussion_r65283090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1448,6 +1450,38 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13290#discussion_r65278189
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1448,6 +1450,38 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13290#discussion_r65278045
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1448,6 +1450,38 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r65271869
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -368,14 +371,27 @@ private[hive] class HiveClientImpl
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r65271411
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -368,14 +371,27 @@ private[hive] class HiveClientImpl
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r65271233
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -147,7 +152,41 @@ private[spark] class HiveExternalCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r65270931
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -68,12 +72,13 @@ private[spark] class HiveExternalCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r65123201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -212,11 +212,46 @@ class SessionCatalog
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13362#issuecomment-222419209
Merging to master and branch-2.0. Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13280#issuecomment-77051
Great, I'm merging this to master and branch-2.0. Thanks for working on
this!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64975446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregate.scala
---
@@ -760,16 +760,29 @@ case class TungstenAggregate
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64975380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregateExec.scala
---
@@ -101,11 +101,23 @@ case class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64975341
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -201,24 +201,26 @@ class QueryExecution(val sparkSession
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,23 +424,50 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974784
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,23 +424,50 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,23 +424,50 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974366
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,23 +424,50 @@ abstract class TreeNode[BaseType
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -424,23 +424,50 @@ abstract class TreeNode[BaseType
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13363#issuecomment-67371
Seems that the examples listed in the PR description is inconsistent with
the actual changes? For example, PR description says `count(1)(Partial)` while
the actual
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64974098
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -126,7 +126,14 @@ private[sql] case
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/12952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12952#issuecomment-62951
While investigating and fixing this issue, hit several other Dataset /
encoder issues along the way, which are included in this umbrella ticket:
[SPARK-15631][1
601 - 700 of 5176 matches
Mail list logo
