Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2397#issuecomment-56001847
Updated as per comments. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17711807
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,20 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17707447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,20 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17659871
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,20 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2397#issuecomment-55806308
Changed the behavior from eager to lazy caching. And also updated the
description.
---
If your project is set up for it, you can reply to this email and have your
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2397#issuecomment-55729953
Making lazy cache seems to be a good idea.As ```SQLContext.cacheTable```,
```CACHE TABLE ``` are both lazy so It is better to make ```CACHE TABLE
AS SELECT ..``` also
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17594549
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -229,7 +229,13 @@ private[hive] object HiveQl {
SetCommand
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17594424
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -229,7 +229,13 @@ private[hive] object HiveQl {
SetCommand
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2397#discussion_r17593929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -183,9 +183,17 @@ class SqlParser extends StandardTokenParsers
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2390#issuecomment-55574756
As there is a confusion in rebasing, I have created a new pull request
https://github.com/apache/spark/pull/2397 rebased with master and also fixed
the review
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2381#issuecomment-55574730
As there is a confusion in rebasing, I have created a new pull request
https://github.com/apache/spark/pull/2397 rebased with master and also fixed
the review
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2397
[SPARK-2594][SQL] Add CACHE TABLE AS SELECT ...
This feature allows user to add cache table from the select query.
Example : ADD CACHE TABLE AS SELECT * FROM TEST_TABLE.
Spark takes this
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17529073
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -243,14 +244,12 @@ private[hive] object HiveQl {
} else if
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17529035
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -233,7 +234,7 @@ private[hive] object HiveQl {
} else if
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17529002
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -214,6 +214,7 @@ private[hive] object HiveQl {
*/
def getAst
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17528949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,24 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17528957
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -119,4 +119,20 @@ class CachedTableSuite extends QueryTest
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17528937
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,24 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17528911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -181,6 +182,12 @@ class SqlParser extends StandardTokenParsers
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17528919
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,24 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2381#discussion_r17528900
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -181,6 +182,12 @@ class SqlParser extends StandardTokenParsers
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -127,6 +127,7 @@ class SqlParser extends StandardTokenParsers
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528618
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -229,11 +230,17 @@ private[hive] object HiveQl
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528625
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -1097,7 +1109,7 @@ private[hive] object HiveQl {
case
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528605
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -214,6 +214,7 @@ private[hive] object HiveQl {
*/
def getAst
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528600
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -119,4 +119,16 @@ class CachedTableSuite extends QueryTest
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528595
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -166,3 +166,22 @@ case class DescribeCommand(child: SparkPlan
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528508
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -305,6 +305,8 @@ private[sql] abstract class SparkStrategies
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528493
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -181,11 +182,25 @@ class SqlParser extends StandardTokenParsers
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/commands.scala
---
@@ -75,3 +75,8 @@ case class DescribeCommand
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/spark/pull/2390#discussion_r17528496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -181,11 +182,25 @@ class SqlParser extends StandardTokenParsers
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2390
[SPARK-2594][SQL] Add CACHE TABLE AS SELECT ... (Updated as per
review comments)
Updated as per the review comments of Admin.
Previous pull request is https://github.com/apache/spark/pull
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2381
[SPARK-2594][SQL] Add CACHE TABLE AS SELECT ...
This feature allows user to add cache table from the select query.
Example : ADD CACHE TABLE AS SELECT * FROM TEST_TABLE.
Spark takes
101 - 133 of 133 matches
Mail list logo
