Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r233649612
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -69,97 +72,191
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r233643587
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -144,6 +144,10
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23031
All entries are already captured in the `ConfigEntry` object, so are all
these changes really needed?
You could warn if anybody tries to update something that's
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233630560
--- Diff:
core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233629662
--- Diff:
core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233628422
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233629692
--- Diff:
core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala
---
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233627918
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233627534
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233637694
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233626891
--- Diff: core/pom.xml ---
@@ -408,6 +408,19 @@
provided
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r233628054
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22867
Merging to master / 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r233591350
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DelegationTokenFeatureStep.scala
---
@@ -0,0 +1,114
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r233578429
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DelegationTokenFeatureStep.scala
---
@@ -0,0 +1,114
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233577372
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -30,6 +30,10 @@ set -e
# If there is no passwd entry
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233549712
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -30,6 +30,10 @@ set -e
# If there is no passwd entry
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233545844
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -30,6 +30,10 @@ set -e
# If there is no passwd entry
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233545303
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -30,6 +30,10 @@ set -e
# If there is no passwd entry
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r233541147
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkPod.scala
---
@@ -18,7 +18,30 @@ package
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22911
To address the comments I had to change a whole bunch of things; mainly
because I noticed that the client and cluster paths were really different, when
they should for the most part be similar
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22867
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233529869
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -30,6 +30,10 @@ set -e
# If there is no passwd entry
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23029
Since you're here do you want to add `@Documented` to `Private` too?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22504
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r233266609
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStepSuite.scala
---
@@ -0,0 +1,68
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23026
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23019
(The log files did show up though. Yay!)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23009
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23009
Setting that property should not affect Scala code in any way.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23017#discussion_r233215367
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -30,6 +30,10 @@ set -e
# If there is no passwd entry
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22504
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r233210145
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStepSuite.scala
---
@@ -0,0 +1,68
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r233168980
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStepSuite.scala
---
@@ -0,0 +1,68
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r233174157
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStepSuite.scala
---
@@ -0,0 +1,68
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23019
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23019
[SPARK-26025][k8s] Speed up docker image build on dev repo.
The "build context" for a docker image - basically the whole contents of the
current directory where "docker" is i
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22915#discussion_r232114559
--- Diff: docs/security.md ---
@@ -798,6 +782,50 @@ achieved by setting
`spark.kubernetes.hadoop.configMapName` to a pre-existing Co
local:///opt
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22959
Thanks Rob. @mccheah @liyinan926
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22982
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22982
ok to test
Please use the standard PR title format used by Spark.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22909
Ok, I'm merging this to master since there doesn't seem do be any negative
feedback.
---
-
To unsubscribe, e-mail: reviews
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22909
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r231591033
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22926
Is this a problem in master at all?
The data is serialized with `JacksonMessageWriter`, which seems to be
configured properly:
```
private[v1] class JacksonMessageWriter extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r231348306
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -123,7
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r231346067
--- Diff: docs/configuration.md ---
@@ -266,6 +266,40 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r231346390
--- Diff: docs/configuration.md ---
@@ -266,6 +266,40 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r231346161
--- Diff: docs/configuration.md ---
@@ -266,6 +266,40 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r231346117
--- Diff: docs/configuration.md ---
@@ -266,6 +266,40 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r231346507
--- Diff: docs/configuration.md ---
@@ -266,6 +266,40 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r231346593
--- Diff: docs/monitoring.md ---
@@ -202,6 +202,28 @@ Security options for the Spark History Server are
covered more detail in the
applications
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22867#discussion_r231292508
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala
---
@@ -136,7 +139,7 @@ class
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22867
I think the reason your original attempt didn't work is because of how you
wrote the code.
private val tmpDir = "file:///" + System.getProperty("java.io.tmpdir")
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22909
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22911#discussion_r231256397
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -123,7
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r231252803
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22882
Merging to master. I'll remove the "WIP" during merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/22959
[SPARK-25876][k8s] Simplify kubernetes configuration types.
There are a few issues with the current configuration types used in
the kubernetes backend:
- they use type parameters
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22928
I don't like stashing everything in `package.scala`; I'm ok-ish with moving
them under the `internal.config` package, but it would be better to keep them
in separate source files
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22931
This is what make-distribution.sh uses, perhaps do the same here?
(It also has a slight advantage of not hardcoding the version of the
plugin.)
```
SCALA_VERSION=$("
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22917
Merging to master / 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230491208
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -96,22 +96,6 @@ case "$SPARK_K8
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230464353
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -1033,6 +1102,7 @@ private[history] case class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230463338
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -812,18 +821,74 @@ private[history] class FsHistoryProvider
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230465268
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230466789
--- Diff: docs/configuration.md ---
@@ -266,6 +266,41 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230463888
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -812,18 +821,74 @@ private[history] class FsHistoryProvider
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230467097
--- Diff: docs/configuration.md ---
@@ -266,6 +266,41 @@ of the most common options to set are:
Only has effect in Spark standalone mode or Mesos
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230466226
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -413,6 +417,66 @@ class FsHistoryProviderSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r230465790
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -413,6 +417,66 @@ class FsHistoryProviderSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230438567
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,134
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230438469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22915#discussion_r230417748
--- Diff: docs/security.md ---
@@ -798,6 +782,50 @@ achieved by setting
`spark.kubernetes.hadoop.configMapName` to a pre-existing Co
local:///opt
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230255203
--- Diff:
resource-managers/kubernetes/docker/src/test/hadoop/conf/yarn-site.xml ---
@@ -0,0 +1,26
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22608
> Think we want different images for each
You don't need to, right? You can have a single image with all the stuff
needed. That would also make setting up the test faster (less ima
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230227737
--- Diff: dev/make-distribution.sh ---
@@ -191,7 +191,8 @@ fi
# Only create and copy the dockerfiles directory if the kubernetes
artifacts were built
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230228691
--- Diff:
resource-managers/kubernetes/docker/src/test/scripts/run-kerberos-test.sh ---
@@ -0,0 +1,40 @@
+#!/usr/bin/env bash
+#
+# Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230228286
--- Diff:
resource-managers/kubernetes/docker/src/test/scripts/populate-data.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+#
+# Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22608#discussion_r230227288
--- Diff: bin/docker-image-tool.sh ---
@@ -53,7 +53,7 @@ function build {
# contain a lot of duplicated jars with the main Spark directory
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22919
This is weird. The most obvious downside is that there's no way to get the
new `-i` functionality in case anyone needs it. A blurb in `--help` or even a
release note explaining the changed behavior
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230223616
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/KubernetesFeaturesTestUtils.scala
---
@@ -63,4 +63,54
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230221109
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230223300
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230223467
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230223525
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230223741
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/KubernetesFeaturesTestUtils.scala
---
@@ -63,4 +63,54
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230223780
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/KubernetesFeaturesTestUtils.scala
---
@@ -63,4 +63,54
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230222736
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22760#discussion_r230222388
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtilSuite.scala
---
@@ -0,0
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230169913
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22909
BTW this is what it looks like (just to show it works):
```
> test
[ lots of output from compiling stuff]
[warn]
/work/apache/spark/repl/src/main/scala/org/apache/spark/r
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22909
sbt is kind of dark magic. read the right passages and things work.
sometimes.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22917
LGTM but the title still doesn't parse for me.
Maybe "Avoid converting incoming encrypted blocks to byte bu
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22915#discussion_r230140235
--- Diff: docs/security.md ---
@@ -798,6 +782,50 @@ achieved by setting
`spark.kubernetes.hadoop.configMapName` to a pre-existing Co
local:///opt
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230137873
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230131792
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230131315
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230130484
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -47,10 +48,24
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230130812
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137
201 - 300 of 11074 matches
Mail list logo
