[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AngersZh commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r453473254 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -199,7 +199,7 @@ abstract class SparkStrategies

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-09 Thread GitBox
AngersZh commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r452597570 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala ## @@ -43,6 +43,22 @@ object

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-09 Thread GitBox
AngersZh commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r452587775 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala ## @@ -43,6 +43,22 @@ object

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-09 Thread GitBox
AngersZh commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r452587223 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala ## @@ -43,6 +43,22 @@ object

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-09 Thread GitBox
AngersZh commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r452576902 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala ## @@ -43,6 +43,22 @@ object

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-09 Thread GitBox
AngersZh commented on a change in pull request #29035: URL: https://github.com/apache/spark/pull/29035#discussion_r452576320 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala ## @@ -570,4 +596,22 @@ class JoinHintSuite extends PlanTest with