[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r877653817 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -228,4 +244,18 @@ protected String visitSQLFunction(String

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r876791321 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -228,4 +244,18 @@ protected String visitSQLFunction(String

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r875431663 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ## @@ -251,6 +251,11 @@ abstract class JdbcDialect extends Serializable with Logging{

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r875441003 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ## @@ -251,6 +251,11 @@ abstract class JdbcDialect extends Serializable with Logging{

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r875431663 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ## @@ -251,6 +251,11 @@ abstract class JdbcDialect extends Serializable with Logging{

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r875431114 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ## @@ -251,6 +251,11 @@ abstract class JdbcDialect extends Serializable with Logging{

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r870106681 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect { case _ =>

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r869102745 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect { case _ =>

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r869102745 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect { case _ =>

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r869102745 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect { case _ =>

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r868717854 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect { case _ =>

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r867659472 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala: ## @@ -41,6 +41,11 @@ private object H2Dialect extends JdbcDialect { case _ =>

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r866488060 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +201,43 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r866469267 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +201,43 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r866465041 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +201,61 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r865701509 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -223,23 +223,23 @@ class V2ExpressionBuilder( case trim: StringTrim

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r861560267 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -228,4 +241,37 @@ protected String visitSQLFunction(String

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r858377708 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -148,6 +148,54 @@ *Since version: 3.3.0 * *

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r858331998 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -148,6 +148,42 @@ *Since version: 3.3.0 * *

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r858328429 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -228,4 +241,37 @@ protected String visitSQLFunction(String

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r858159139 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857489142 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857488503 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -41,6 +42,11 @@ public String build(Expression expr) { } else

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857487526 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857486955 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -28,16 +28,26 @@ */ @Evolving public class Trim implements Expression,

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857341263 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857341263 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL] DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857338952 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857208452 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +200,46 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857208341 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +200,46 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857208110 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -228,4 +238,21 @@ protected String visitSQLFunction(String

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857207831 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -102,13 +102,23 @@ public String build(Expression expr) {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857207590 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -102,13 +102,23 @@ public String build(Expression expr) {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857207398 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -102,13 +102,23 @@ public String build(Expression expr) {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857078057 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -102,6 +102,12 @@ public String build(Expression expr) {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857077093 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +200,49 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857076505 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -102,6 +102,12 @@ public String build(Expression expr) {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857076113 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -200,6 +200,49 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

beliefer commented on code in PR #36330: URL: https://github.com/apache/spark/pull/36330#discussion_r857075007 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ## @@ -148,6 +148,42 @@ *Since version: 3.3.0 * *