[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r433122526 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala ## @@ -85,13 +85,13 @@ class UnivocityParser( // W

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429181079 ## File path: sql/core/src/test/resources/sql-tests/results/datetime.sql.out ## @@ -750,3 +750,164 @@ select to_timestamp("2019 10:10:10", " hh:mm:s

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429180213 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -117,6 +117,33 @@ trait DateTimeFormat

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429178959 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -119,13 +119,8 @@ The count of pattern letters determines the format. spark-sql> select to_csv

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429178682 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -63,9 +63,9 @@ Spark uses pattern letters in the following table for date and timestamp parsing

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429178345 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -30,25 +30,25 @@ Spark uses pattern letters in the following table for date and timestamp parsing

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429116529 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -26,44 +26,128 @@ There are several common scenarios for datetime usage in Spark: - Datetime func

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429071977 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -33,6 +34,8 @@ sealed trait DateFormatter extend

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429071489 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -86,6 +86,33 @@ trait DateTimeFormatte

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429070818 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -33,6 +34,8 @@ sealed trait DateFormatter extend

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428759386 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -86,6 +86,25 @@ trait DateTimeFormatte

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428758919 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -40,7 +41,11 @@ class Iso8601DateFormatter( e

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428615629 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -40,7 +43,23 @@ class Iso8601DateFormatter( e

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428605898 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-corrected.sql ## @@ -0,0 +1,2 @@ +--SET spark.sql.legacy.timeParserPolicy=CORRECTED

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428604480 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -61,8 +64,23 @@ class Iso8601TimestampForma

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r428603874 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -77,14 +96,14 @@ trait LegacyDateFormatter exten

[GitHub] [spark] cloud-fan commented on a change in pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r427944925 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -122,3 +122,13 @@ select to_timestamp("2019-10-06T10:11:12'12", "-MM-