[GitHub] [spark] cloud-fan commented on a change in pull request #29220: [SPARK-32424][SQL] Fix silent data change for timestamp parsing if overflow happens

cloud-fan commented on a change in pull request #29220: URL: https://github.com/apache/spark/pull/29220#discussion_r460640661 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-parsing-invalid.sql ## @@ -1,5 +1,13 @@ --- TESTS FOR DATETIME PARSING FUNCTIONS W

[GitHub] [spark] cloud-fan commented on a change in pull request #29220: [SPARK-32424][SQL] Fix silent data change for timestamp parsing if overflow happens

cloud-fan commented on a change in pull request #29220: URL: https://github.com/apache/spark/pull/29220#discussion_r460640850 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-parsing.sql ## @@ -1,5 +1,33 @@ --- TESTS FOR DATETIME PARSING FUNCTIONS --- +--

[GitHub] [spark] cloud-fan commented on a change in pull request #29220: [SPARK-32424][SQL] Fix silent data change for timestamp parsing if overflow happens

cloud-fan commented on a change in pull request #29220: URL: https://github.com/apache/spark/pull/29220#discussion_r460089650 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-parsing.sql ## @@ -1,5 +1,18 @@ --- TESTS FOR DATETIME PARSING FUNCTIONS --- +--

[GitHub] [spark] cloud-fan commented on a change in pull request #29220: [SPARK-32424][SQL] Fix silent data change for timestamp parsing if overflow happens

cloud-fan commented on a change in pull request #29220: URL: https://github.com/apache/spark/pull/29220#discussion_r460089355 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-parsing-invalid.sql ## @@ -1,5 +1,14 @@ --- TESTS FOR DATETIME PARSING FUNCTIONS W

[GitHub] [spark] cloud-fan commented on a change in pull request #29220: [SPARK-32424][SQL] Fix silent data change for timestamp parsing if overflow happens

cloud-fan commented on a change in pull request #29220: URL: https://github.com/apache/spark/pull/29220#discussion_r460088732 ## File path: sql/core/src/test/resources/sql-tests/results/datetime-formatting-legacy.sql.out ## @@ -32,17 +32,17 @@ struct -- !query -select col

[GitHub] [spark] cloud-fan commented on a change in pull request #29220: [SPARK-32424][SQL] Fix silent data change for timestamp parsing if overflow happens

cloud-fan commented on a change in pull request #29220: URL: https://github.com/apache/spark/pull/29220#discussion_r459932783 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime-parsing.sql ## @@ -1,5 +1,68 @@ --- TESTS FOR DATETIME PARSING FUNCTIONS --- +--