[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603407499 ## File path: sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out ## @@ -275,6 +245,24 @@ NULL 201235000 NULL 2013780

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603341821 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-analytics.sql ## @@ -18,12 +18,19 @@ AS courseSales(course, year, earnings); -- ROLL

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603341499 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-analytics.sql ## @@ -18,9 +18,11 @@ AS courseSales(course, year, earnings); -- ROLLU

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603339351 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupingAnalyticsSuite.scala ## @@ -41,61 +41,64 @@ class Resol

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603336541 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -653,14 +616,9 @@ class Analyzer(override val cat

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603297317 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,40 +42,53 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603295175 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,40 +42,53 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603176835 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,60 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r603176515 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,60 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602136302 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -39,47 +40,98 @@ trait GroupingSet extends Exp

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602135754 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -907,29 +907,64 @@ class AstBuilder extends SqlBa

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602129583 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -907,29 +907,64 @@ class AstBuilder extends SqlBa

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602128904 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -907,29 +907,64 @@ class AstBuilder extends SqlBa

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602127568 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -907,29 +907,64 @@ class AstBuilder extends SqlBa

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602125687 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -907,29 +907,64 @@ class AstBuilder extends SqlBa

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602123580 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,55 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602122261 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,55 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602121498 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,55 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602039086 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r602038960 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601294900 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601292060 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601291321 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601287015 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601254568 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -32,7 +32,7 @@ When a FILTER clause is attached to an aggregate function, only the matchi

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601240887 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -32,7 +32,7 @@ When a FILTER clause is attached to an aggregate function, only the matchi

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601237679 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601234435 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601232220 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601230361 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,42 +42,44 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601229471 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -32,7 +32,7 @@ When a FILTER clause is attached to an aggregate function, only the matchi

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601152883 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601151630 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601154251 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601150341 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601148662 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -50,34 +65,28 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE bo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601147150 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,6 +42,21 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE boo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601146756 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -32,7 +32,7 @@ When a FILTER clause is attached to an aggregate function, only the matchi

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601143106 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,6 +42,21 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE boo

[GitHub] [spark] cloud-fan commented on a change in pull request #30212: [SPARK-33308][SQL] Refactor current grouping analytics

cloud-fan commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r601143106 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -42,6 +42,21 @@ aggregate_name ( [ DISTINCT ] expression [ , ... ] ) [ FILTER ( WHERE boo