[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-25 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530134316 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -361,11 +379,38 @@ object ViewHelper { } } +

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530133325 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -361,11 +364,34 @@ object ViewHelper { } } +

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530134316 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -361,11 +379,38 @@ object ViewHelper { } } +

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530133390 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ## @@ -414,6 +433,8 @@ object CatalogTable { val

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530133325 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ## @@ -361,11 +364,34 @@ object ViewHelper { } } +

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530130202 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -748,4 +748,30 @@ abstract class SQLViewSuite extends

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530130052 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala ## @@ -771,22 +771,24 @@ class AnalysisSuite

[GitHub] [spark] luluorta commented on a change in pull request #30289: [SPARK-33141][SQL] Capture SQL configs when creating permanent views

2020-11-24 Thread GitBox
luluorta commented on a change in pull request #30289: URL: https://github.com/apache/spark/pull/30289#discussion_r530129632 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -132,9 +132,11 @@ object AnalysisContext { */