[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432201354 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,8 @@ case class CreateTableLikeCommand(

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432202932 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class AlterTableSetLocationCommand( o

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432203235 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2708,23 @@ class HiveDDLSuite checkAnsw

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-29 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432794003 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2704,26 @@ class HiveDDLSuite checkAnsw

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-29 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432793971 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2704,26 @@ class HiveDDLSuite checkAnsw

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-29 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432794399 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -22,6 +22,9 @@ license: | ### Description The `CREATE TABLE` statement defines a new t

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-29 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432794744 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,15 @@ case class CreateTableLikeCommand(

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-29 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432794003 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2704,26 @@ class HiveDDLSuite checkAnsw

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-31 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432941526 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -57,6 +57,7 @@ CREATE TABLE [IF NOT EXISTS] table_identifier LIKE source_table_identifier

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-31 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432941526 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -57,6 +57,7 @@ CREATE TABLE [IF NOT EXISTS] table_identifier LIKE source_table_identifier

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448065211 ## File path: docs/sql-ref-syntax-ddl-create-table-like.md ## @@ -57,6 +57,8 @@ CREATE TABLE [IF NOT EXISTS] table_identifier LIKE source_table_identifier

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448065805 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -55,7 +55,8 @@ import org.apache.spark.sql.util.SchemaUtil

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-06-30 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r448066069 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,26 @@ case class CreateTableLikeCommand(