Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14842
Merging to master. Thanks for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14842
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
@hvanhovell @ericl Please see if anything else I miss. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65279/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65279/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65279/consoleFull)**
for PR 14842 at commit
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
@ericl Thanks so much for the detailed review and suggestions. I will fix
the last comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14842
A few more minor comments but otherwise the prefix parts look good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65212/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65212/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65212/consoleFull)**
for PR 14842 at commit
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
Retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65196/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65196 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65196/consoleFull)**
for PR 14842 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65198/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65198 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65198/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65198 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65198/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65196 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65196/consoleFull)**
for PR 14842 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65187/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65187/consoleFull)**
for PR 14842 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65179/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65179/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65187/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #65179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65179/consoleFull)**
for PR 14842 at commit
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/14842
Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14842
@ericl could you take a look to changes made to PrefixSort?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64742/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #64742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64742/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #64742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64742/consoleFull)**
for PR 14842 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64670/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #64670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64670/consoleFull)**
for PR 14842 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #64670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64670/consoleFull)**
for PR 14842 at commit
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
I see what you mean. Let me try your approach. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14842
Ok, so ASCENDING and DESCENDING have different NULLS behavior:
- ASCENDING: NULLS FIRST
- DESCENDING: NULLS LAST
I really like to avoid `nulls` being passed around and I also like
Github user xwu0226 commented on the issue:
https://github.com/apache/spark/pull/14842
@hvanhovell Thank you so much for reviewing and providing the suggestions.
I will separate this into 2 PRs.
For the question of why we need 3 types of NULL ordering, I was thinking
that the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14842
@xwu0226 I glanced over it and this looks like the right approach.
One a high level I would break this up in two separate PRs: one to add
`NULLS FIRST`/`NULLS LAST` sorting to the unsafe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64514/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14842
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14842
**[Test build #64514 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64514/consoleFull)**
for PR 14842 at commit
47 matches
Mail list logo
