Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77828087
[Test build #28387 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28387/consoleFull)
for PR 4916 at commit
[`6705b98`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77828099
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77818222
[Test build #28387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28387/consoleFull)
for PR 4916 at commit
[`6705b98`](https://githu
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r26021043
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77781120
@srowen I'm fine with the line either way and it shouldn't really matter.
As I described above the problem of master_instance_type being different from
slaves is a diffe
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r26010428
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77750513
I'll wait another day in case the consensus is that this line should indeed
change, but it sounds like it is likely fine as is.
---
If your project is set up for it, you
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r26000373
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77710036
@srowen This change doesn't remove any existing functionality as far as I
can see. As @nchammas said if you stopped instances of a certain type you can
only get the same
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25999599
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25999086
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25997522
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25997245
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
cluster
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77696556
I guess I'm trying to figure out if this change subtracts existing
functionality. That's potentially controversial and what I would hesitate over.
If it merely do
Github user thvasilo commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77696081
> Is the argument that this should not be allowed any longer? or am I
mistaken and it was never allowed?
I am also not sure about this, it would be cool to allow
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77688219
I understand the goal to be:
- If I do specify an instance type T on restart, launch instance type T and
configure for T regardless of previous instance type
-
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77609870
Ah, I see. Thank you for the clarification. I would add this into the PR
body, since that becomes part of the commit message if this PR gets merged.
---
If your project
Github user thvasilo commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77581802
@nchammas The instances do come up with the correct type, the problem is
more the one described [here]
(https://issues.apache.org/jira/browse/SPARK-5838?focusedComme
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77570226
[Test build #28342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28342/consoleFull)
for PR 4916 at commit
[`a3d29fe`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77570242
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77567240
I also tried to change the instance type when starting a stopped cluster.
That didn't work, and the instances were brought up with their original
instance types.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77564954
@thvasilo can you clarify what flow you are seeing this behavior for? I
can't reproduce the issue you're reporting.
Here's what I tried:
1. Launch a clu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77558169
[Test build #28342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28342/consoleFull)
for PR 4916 at commit
[`a3d29fe`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77557606
[Test build #28341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28341/consoleFull)
for PR 4916 at commit
[`7b32429`](https://gith
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77557369
You can click through to the result of the Jenkins build to see the error:
```
PEP 8 checks failed.
./ec2/spark_ec2.py:1262:1: W293 blank line contains whit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77557612
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77557500
[Test build #28341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28341/consoleFull)
for PR 4916 at commit
[`7b32429`](https://githu
Github user thvasilo commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77557251
Removed trailing whitespace, was that the style problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77555918
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77555808
[Test build #28339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28339/consoleFull)
for PR 4916 at commit
[`3ebd52a`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77555917
[Test build #28339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28339/consoleFull)
for PR 4916 at commit
[`3ebd52a`](https://gith
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77555403
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25939525
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
cluster
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25937157
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25883042
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
cluster
Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25882813
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
clust
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4916#discussion_r25882335
--- Diff: ec2/spark_ec2.py ---
@@ -1259,6 +1259,15 @@ def real_main():
cluster_instances=(master_nodes + slave_nodes),
cluster
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4916#issuecomment-77407514
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user thvasilo opened a pull request:
https://github.com/apache/spark/pull/4916
[EC2] [SPARK-6188] Instance types can be mislabeled when re-starting
cluster with default arguments
As described in https://issues.apache.org/jira/browse/SPARK-6188 and
discovered in https://issue
40 matches
Mail list logo
