Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149691655
@dbtsai Sorry. I forgot to link here.
https://issues.apache.org/jira/plugins/servlet/mobile#issue/SPARK-11207
---
If your project is set up for it, you can reply to
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149671660
@Lewuathe Can you create the JIRA with detail? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149385034
@dbtsai Thank you so much for long time catching up and reviewing again.
I'll create another follow-up JIRA of this.
---
If your project is set up for it, you can r
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149295691
Thanks. Merged into master.
Please submit another PR to address the minor issues in the comment. We
would like to see that when solver is `auto`, the `normal` so
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42402047
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42402026
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401980
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401879
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401838
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401790
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends SparkF
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149155400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149155399
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149155084
**[Test build #43921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43921/consoleFull)**
for PR 8884 at commit
[`c121e10`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149145144
**[Test build #43921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43921/consoleFull)**
for PR 8884 at commit
[`c121e10`](https://gith
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149143395
@dbtsai Oh. Thanks I updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149141604
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149141582
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149131660
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149131663
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149131593
**[Test build #43920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43920/consoleFull)**
for PR 8884 at commit
[`159f817`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149127703
**[Test build #43920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43920/consoleFull)**
for PR 8884 at commit
[`159f817`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149126342
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149126356
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42339576
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends Spar
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42339518
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends SparkF
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42338873
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends Spar
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42328431
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42327619
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42327468
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends SparkF
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149009216
@dbtsai Thank you so much again. Could check this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149007582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149007581
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149007547
[Test build #43897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43897/console)
for PR 8884 at commit
[`d996cd9`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149005489
[Test build #43897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43897/consoleFull)
for PR 8884 at commit
[`d996cd9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149005130
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149005126
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148769776
@Lewuathe
They should be the same, but there is no test proving it.
Since in
```scala
test("linear regression with weighted samples"){
`
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148691353
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148691174
[Test build #43839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43839/console)
for PR 8884 at commit
[`c8d0ec9`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148691355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148680732
[Test build #43839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43839/consoleFull)
for PR 8884 at commit
[`c8d0ec9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148679490
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148679505
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148679109
> Please add a test for this. If they are in fact returning different
solution, then throw exception saying that weighted LiR doesn't support normal
mode
@dbts
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148657383
@dbtsai Thank you for polite reviewing! I'll update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148321601
I'll be able to merge this PR once the following two issues are addressed,
1) Have a test to verify that `L1` with normal will throw
`IllegalArugmentExcpetion`. I
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148227686
@dbtsai Thanks again. Could check it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147928871
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147928870
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147928769
[Test build #43700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43700/console)
for PR 8884 at commit
[`23a8ab1`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147919705
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147919701
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147919639
[Test build #43699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43699/console)
for PR 8884 at commit
[`ea5f195`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147915090
[Test build #43700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43700/consoleFull)
for PR 8884 at commit
[`23a8ab1`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147912959
[Test build #43699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43699/consoleFull)
for PR 8884 at commit
[`ea5f195`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147911717
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147911630
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147910843
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147910824
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41899983
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41899604
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147726704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147726706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147726522
[Test build #43643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43643/console)
for PR 8884 at commit
[`8583f4a`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147714575
[Test build #43643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43643/consoleFull)
for PR 8884 at commit
[`8583f4a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147712151
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147712183
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Lewuathe commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147712068
@dbtsai Thank you so much for reviewing many times. Could check it again,
please?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41863564
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends Spar
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41860463
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends Spar
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41856633
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41856388
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147546487
@Lewuathe LGTM except those minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811297
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811201
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811137
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811124
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811141
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r4184
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811067
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811080
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811015
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810986
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810586
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810438
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810413
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810342
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810212
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends SparkF
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810042
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810020
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41809540
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41809032
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808876
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808787
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808590
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808061
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41807118
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -73,7 +73,9 @@ private[shared] object SharedParamsCodeGen {
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41806842
--- Diff: R/pkg/R/mllib.R ---
@@ -45,12 +45,13 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
#'}
setMethod("glm
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41806848
--- Diff: R/pkg/R/mllib.R ---
@@ -45,12 +45,13 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
#'}
setMethod("glm
1 - 100 of 215 matches
Mail list logo
