Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-159347482
@srowen @vanzin @holdenk Thanks for reviewing and merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-159346447
Ah, yeah, fell through the cracks. Merging to master / 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-159203558
@vanzin are you OK with this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158338205
@vanzin Thanks for reviewing, I addressed your comment. Please take a look
again.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158369660
**[Test build #46410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46410/consoleFull)**
for PR 9812 at commit
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158377559
Failed tests seems not related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158338829
**[Test build #46410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46410/consoleFull)**
for PR 9812 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45451124
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158369725
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158369724
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158498889
**[Test build #46427 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46427/consoleFull)**
for PR 9812 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158496116
yeah, pyspark tests are super flaky lately. but it never hurts: retest this
please
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158525959
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158525957
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-158525778
**[Test build #46427 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46427/consoleFull)**
for PR 9812 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45419592
--- Diff:
repl/src/test/scala/org/apache/spark/repl/ExecutorClassLoaderSuite.scala ---
@@ -99,6 +107,32 @@ class ExecutorClassLoaderSuite
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45419464
--- Diff:
repl/src/test/scala/org/apache/spark/repl/ExecutorClassLoaderSuite.scala ---
@@ -54,6 +60,8 @@ class ExecutorClassLoaderSuite
url1 =
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45419865
--- Diff:
repl/src/test/scala/org/apache/spark/repl/ExecutorClassLoaderSuite.scala ---
@@ -99,6 +107,32 @@ class ExecutorClassLoaderSuite
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45419921
--- Diff:
repl/src/test/scala/org/apache/spark/repl/ExecutorClassLoaderSuite.scala ---
@@ -99,6 +107,32 @@ class ExecutorClassLoaderSuite
}
}
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/spark/pull/9812
[SPARK-11818][REPL] Fix ExecutorClassLoader to lookup resources from â¦
â¦parent class loader
Without patch, two additional tests of ExecutorClassLoaderSuite fails.
-
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157758507
Jenkins, please test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45225492
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45225563
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -159,6 +159,16 @@ private[spark] object TestUtils {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157752759
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45288354
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45288990
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157928946
**[Test build #46272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46272/consoleFull)**
for PR 9812 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157929112
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45286660
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45288748
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45285698
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157929110
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157905917
**[Test build #46272 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46272/consoleFull)**
for PR 9812 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9812#issuecomment-157904703
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45281630
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45260904
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -159,6 +159,16 @@ private[spark] object TestUtils {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45261349
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
38 matches
Mail list logo