Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162286394
@felixcheung @sun-rui Thank you! Based on your comments, I did the changes.
Please review the changes. : )
---
If your project is set up for it, you can
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162328075
@felixcheung I am not sure if we need to add a test case for `sample`.
Normally, using a specific seed is the common way to verify the result of
`sample`. The
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162317352
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162317319
**[Test build #47236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47236/consoleFull)**
for PR 10160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162317351
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162286420
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162289399
looks good! could you think of the best way to add a test for not setting
seed?
hmm.. perhaps the loop I use in #9549?
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162313901
**[Test build #47236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47236/consoleFull)**
for PR 10160 at commit
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46767022
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,25 +677,44 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46766729
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,25 +677,44 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46766732
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,25 +677,44 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162233127
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162233128
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/10160
[SPARK-12158] [R] [SQL] Fix 'sample' functions that break R unit test cases
The existing sample functions miss the parameter 'seed', however, the
corresponding function interface in `generics`
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162231986
**[Test build #47230 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47230/consoleFull)**
for PR 10160 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162233087
**[Test build #47230 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47230/consoleFull)**
for PR 10160 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162241856
@davies Could you take a look at this PR? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162242902
cc @sun-rui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
18 matches
Mail list logo
