[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-170072468 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169963672 **[Test build #49017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49017/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169997391 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169997385 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169996917 **[Test build #49017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49017/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-07 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r49139498 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -57,8 +57,8 @@ trait

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r49080896 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -57,8 +57,8 @@ trait ExpressionEvalHelper

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169683705 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-07 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169828910 @srowen I am confused, did you send me this message for this PR? It somehow does not show up in github, and I do not see the jenkins run that failed: ```

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169829727 @thunterdb It's here on Github: https://github.com/apache/spark/pull/10570#discussion_r49080896 Right above is the result of the last run, which failed.

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169281764 **[Test build #48848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48848/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169281772 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169281770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169279737 **[Test build #48848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48848/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169277879 (Nevermind -- I backed out the `commons-codec` change for now.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169322620 **[Test build #48857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48857/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169362292 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169361992 **[Test build #48857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48857/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169362293 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48987891 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -57,8 +57,8 @@ trait ExpressionEvalHelper

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48987974 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala --- @@ -206,7 +206,7 @@ abstract class QueryTest extends PlanTest { val

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169424618 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169424622 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48983200 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -57,8 +57,8 @@ trait

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48983231 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -275,8 +275,8 @@ trait

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169396527 @srowen thanks a lot for the cleanup! Just two comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48983461 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala --- @@ -206,7 +206,7 @@ abstract class QueryTest extends PlanTest { val

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48983495 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala --- @@ -231,7 +231,7 @@ abstract class QueryTest extends PlanTest { val

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r49018866 --- Diff: mllib/src/test/java/org/apache/spark/mllib/regression/JavaIsotonicRegressionSuite.java --- @@ -81,10 +81,10 @@ public void

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r49019215 --- Diff: mllib/src/test/java/org/apache/spark/mllib/regression/JavaIsotonicRegressionSuite.java --- @@ -81,10 +81,10 @@ public void

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169450056 It's not hard to rebase this, as the number of lines changed is actually small. I don't see a value in splitting it as it will still mean as many rebases. --- If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169449477 cc @jkbradley @srowen I have some concerns about the number of files being touched by this PR, it may be hard to merge without an ever-present conflict

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r49014766 --- Diff: mllib/src/test/java/org/apache/spark/mllib/regression/JavaIsotonicRegressionSuite.java --- @@ -81,10 +81,10 @@ public void

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-06 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169474278 That's the only item I see. Thanks very much for doing these cleanups! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169084717 @JoshRosen you might be able to help here. The Spark build passed, but the MiMa failed due to a compilation error. The change that tripped this uses an API call in

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169087013 **[Test build #48777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48777/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169090188 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169090190 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-169090132 **[Test build #48777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48777/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168981740 **[Test build #48762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48762/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168985619 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168985593 **[Test build #48762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48762/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168985620 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/10570 [SPARK-12618] [CORE] [STREAMING] [SQL] Clean up build warnings: 2.0.0 edition Fix most build warnings: mostly deprecated API usages. I'll annotate some of the changes below. CC @rxin who is

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48713977 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -177,35 +177,55 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10570#discussion_r48714048 --- Diff: extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisStreamSuite.scala --- @@ -137,8 +137,8 @@ abstract class

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168622367 **[Test build #48648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48648/consoleFull)** for PR 10570 at commit

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168679244 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168679242 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-168679052 **[Test build #48648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48648/consoleFull)** for PR 10570 at commit