Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-207186805
Merging with master
@holdenk @hhbyyh Thanks for taking a look!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-207080727
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-207080730
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-207080356
**[Test build #55234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55234/consoleFull)**
for PR 12166 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-207046853
**[Test build #55234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55234/consoleFull)**
for PR 12166 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-207046111
Fixed merge conflicts in MimaExcludes.scala by rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-206564100
**[Test build #2760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2760/consoleFull)**
for PR 12166 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-206508811
**[Test build #2760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2760/consoleFull)**
for PR 12166 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-206087743
**[Test build #2757 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2757/consoleFull)**
for PR 12166 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-206050511
It looks like the MiMa tests were spurious (Spark core)
I'll make a follow-up JIRA for Python
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-206050630
**[Test build #2757 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2757/consoleFull)**
for PR 12166 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-206006902
This change looks good to me pending tests/MiMa & possibly user
verification - we should also either add a follow up JIRA for the Python API or
add it in this PR.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205978307
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205978310
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205978280
**[Test build #55013 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55013/consoleFull)**
for PR 12166 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205974236
**[Test build #55013 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55013/consoleFull)**
for PR 12166 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205954399
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205954395
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205954120
**[Test build #55001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55001/consoleFull)**
for PR 12166 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205914706
**[Test build #55001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55001/consoleFull)**
for PR 12166 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12166#discussion_r58582117
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -619,6 +651,31 @@ class DistributedLDAModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12166#discussion_r58582132
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -758,6 +816,10 @@ class LDA @Since("1.6.0") (
@Since("1.6.0")
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205913961
Updated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12166#discussion_r58582125
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -258,7 +265,30 @@ private[clustering] trait LDAParams extends Params
with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205643719
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205643720
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205643607
**[Test build #54939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54939/consoleFull)**
for PR 12166 at commit
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12166#discussion_r58485037
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -758,6 +816,10 @@ class LDA @Since("1.6.0") (
@Since("1.6.0")
def
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12166#discussion_r58483718
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -258,7 +265,30 @@ private[clustering] trait LDAParams extends Params
with
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12166#discussion_r58483636
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -619,6 +651,31 @@ class DistributedLDAModel private[ml] (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205621463
**[Test build #54939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54939/consoleFull)**
for PR 12166 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205621012
@hhbyyh @holdenk Would you mind taking a look please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12166#issuecomment-205620748
OK should be good to go now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
34 matches
Mail list logo
