Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193595238
Merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193548355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193548354
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193547869
**[Test build #52612 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52612/consoleFull)**
for PR 11274 at commit
[`f431170`](https://g
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193534012
sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193523843
@nongli I had updated the doc and commit message (PR description), once it
pass the tests, I will merge this into master.
---
If your project is set up for it, you can
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55296297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55296284
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193512076
**[Test build #52612 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52612/consoleFull)**
for PR 11274 at commit
[`f431170`](https://gi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55294609
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -39,15 +39,26 @@ case class Project(projectList: Seq[NamedExpress
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55293764
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala
---
@@ -279,17 +277,21 @@ case class BroadcastHashJoin(
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193508198
Patch looks good. Just a few documentation suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55293072
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala
---
@@ -279,17 +277,21 @@ case class BroadcastHashJoin(
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55292723
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55292388
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55292326
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-193496493
@davies can you update the gist with the new output?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55117053
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -186,30 +184,37 @@ private[sql] case class PhysicalRDD(
|
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192600787
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192600788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192600735
**[Test build #52507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52507/consoleFull)**
for PR 11274 at commit
[`ffc9d8c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192579677
**[Test build #52507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52507/consoleFull)**
for PR 11274 at commit
[`ffc9d8c`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192527766
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192527735
**[Test build #52495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52495/consoleFull)**
for PR 11274 at commit
[`76ca6c6`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192527769
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-192523025
**[Test build #52495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52495/consoleFull)**
for PR 11274 at commit
[`76ca6c6`](https://gi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55102849
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -116,6 +119,39 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55080654
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -39,15 +39,26 @@ case class Project(projectList: Seq[NamedExpress
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55080224
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -116,6 +119,39 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55079840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -116,6 +119,39 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11274#discussion_r55079563
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -116,6 +119,39 @@ trait CodegenSupport extends SparkPlan {
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190934557
@nongli This one seems important for us now, could you start to review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190614317
**[Test build #2594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2594/consoleFull)**
for PR 11274 at commit
[`ca8fe0f`](https://
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190613610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190613609
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190613104
**[Test build #52224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52224/consoleFull)**
for PR 11274 at commit
[`1a1452e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190611034
**[Test build #2595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2595/consoleFull)**
for PR 11274 at commit
[`ca8fe0f`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190577409
**[Test build #52224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52224/consoleFull)**
for PR 11274 at commit
[`1a1452e`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190576044
**[Test build #2595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2595/consoleFull)**
for PR 11274 at commit
[`ca8fe0f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-190575463
**[Test build #2594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2594/consoleFull)**
for PR 11274 at commit
[`ca8fe0f`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188708767
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188708763
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188707686
**[Test build #51948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51948/consoleFull)**
for PR 11274 at commit
[`ca8fe0f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188667766
**[Test build #51948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51948/consoleFull)**
for PR 11274 at commit
[`ca8fe0f`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188557058
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188557056
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188556559
**[Test build #51912 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51912/consoleFull)**
for PR 11274 at commit
[`ef9e8f3`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-188532949
**[Test build #51912 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51912/consoleFull)**
for PR 11274 at commit
[`ef9e8f3`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187989294
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187989297
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187989144
**[Test build #51814 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51814/consoleFull)**
for PR 11274 at commit
[`4faf5f9`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187987044
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187987043
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187965655
**[Test build #51814 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51814/consoleFull)**
for PR 11274 at commit
[`4faf5f9`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187416765
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187416766
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187416645
**[Test build #51668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51668/consoleFull)**
for PR 11274 at commit
[`0cf8ad0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187413790
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187413792
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187409708
This PR make codegen harder to understand (easy to be wrong), the
performance improvements is not that much currently (maybe because the
generated part does not take a m
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-187401114
**[Test build #51668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51668/consoleFull)**
for PR 11274 at commit
[`0cf8ad0`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186387843
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186387846
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186387535
**[Test build #51569 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51569/consoleFull)**
for PR 11274 at commit
[`c92e457`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186368352
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186368198
**[Test build #51564 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51564/consoleFull)**
for PR 11274 at commit
[`8fd2ceb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186360274
**[Test build #51569 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51569/consoleFull)**
for PR 11274 at commit
[`c92e457`](https://gi
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186356444
This is generated code for Q55:
```
select i_brand_id brand_id, i_brand brand,
sum(ss_ext_sales_price) ext_price
from date_dim, store_sales, item
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186345723
**[Test build #51564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51564/consoleFull)**
for PR 11274 at commit
[`8fd2ceb`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186344255
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11274#issuecomment-186344261
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
72 matches
Mail list logo
