[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-221153219 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-221153222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-05-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-221153068 **[Test build #59168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59168/consoleFull)** for PR 11673 at commit [`004b19d`](https://g

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-05-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-221133792 **[Test build #59168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59168/consoleFull)** for PR 11673 at commit [`004b19d`](https://gi

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197818877 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197898733 **[Test build #53426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53426/consoleFull)** for PR 11673 at commit [`004b19d`](https://g

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11673#discussion_r56599894 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1450,7 +1450,9 @@ object CleanupAliases extends Rule[L

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197792870 hi @marmbrus , yes your idea makes sense, we should use `Alias` to produce new attributes if we can. Except leaf nodes, there are some special cases we still need to

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197899144 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197899147 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197818629 **[Test build #53415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53415/consoleFull)** for PR 11673 at commit [`cae7b52`](https://g

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11673#discussion_r56599961 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1450,7 +1450,9 @@ object CleanupAliases extends Rule[L

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197788236 **[Test build #53415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53415/consoleFull)** for PR 11673 at commit [`cae7b52`](https://gi

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197860828 **[Test build #53426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53426/consoleFull)** for PR 11673 at commit [`004b19d`](https://gi

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-197818879 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11673#discussion_r56538531 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1450,7 +1450,9 @@ object CleanupAliases extends Rule[Lo

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196436520 After thinking about it more, I wonder if `missingInput` was really the right way to handle this problem. Another option (that is used in every other operator

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196234027 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196230191 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196230190 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196229872 **[Test build #53057 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53057/consoleFull)** for PR 11673 at commit [`af6a0bf`](https://g

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196190295 **[Test build #53057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53057/consoleFull)** for PR 11673 at commit [`af6a0bf`](https://gi

[GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...

2016-03-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11673#issuecomment-196188463 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this