Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206110555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206110534
merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206110552
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206110316
**[Test build #55079 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55079/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206107326
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206107327
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206107113
**[Test build #55076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55076/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206104505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206104497
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206103496
**[Test build #55075 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55075/consoleFull)**
for PR 12087 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58646052
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58645473
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58645093
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206087250
**[Test build #55079 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55079/consoleFull)**
for PR 12087 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58643806
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58643655
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58643564
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58643458
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206082392
**[Test build #55076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55076/consoleFull)**
for PR 12087 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58643155
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-206078584
**[Test build #55075 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55075/consoleFull)**
for PR 12087 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58622864
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58582999
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58577527
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58576642
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58575785
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58575623
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205881415
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205881421
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205880601
**[Test build #54990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54990/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205850589
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205850592
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205850563
**[Test build #54992 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54992/consoleFull)**
for PR 12087 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205848733
benchmark added, the result is included in the benchmark code. I also ran
this benchmark against master branch, the result is:
```
Java HotSpot(TM) 64-Bit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205847599
**[Test build #54992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54992/consoleFull)**
for PR 12087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205840164
**[Test build #54990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54990/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205839287
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205839240
**[Test build #54989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54989/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205839291
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205836476
**[Test build #54989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54989/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205698943
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205698938
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205698073
**[Test build #54960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54960/consoleFull)**
for PR 12087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205662071
**[Test build #54960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54960/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205645123
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205645121
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205644973
**[Test build #54943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54943/consoleFull)**
for PR 12087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205622811
**[Test build #54943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54943/consoleFull)**
for PR 12087 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205606263
@davies , yea, no need of subexpression elimination for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205405453
LGTM. This implementation does not require common subexpression
elimination, right?
---
If your project is set up for it, you can reply to this email and have your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58412963
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1893,8 +1898,13 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58412927
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1882,7 +1882,12 @@ class Dataset[T] private[sql](
* @since 1.6.0
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58412559
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
@@ -68,6 +71,69 @@ case class MapPartitions(
}
/**
+
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58410362
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
@@ -68,6 +71,69 @@ case class MapPartitions(
}
/**
+ *
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205238640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205238639
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205238407
**[Test build #54842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54842/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205215640
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205215642
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205215326
**[Test build #54839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54839/consoleFull)**
for PR 12087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205205570
**[Test build #54842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54842/consoleFull)**
for PR 12087 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205197106
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205197104
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205196954
**[Test build #54833 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54833/consoleFull)**
for PR 12087 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205182866
**[Test build #54839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54839/consoleFull)**
for PR 12087 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58333430
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
@@ -68,6 +71,64 @@ case class MapPartitions(
}
/**
+ *
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58333412
--- Diff:
core/src/main/java/org/apache/spark/api/java/function/MapFunction.java ---
@@ -23,5 +23,5 @@
* Base interface for a map function used in
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12087#issuecomment-205158396
**[Test build #54833 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54833/consoleFull)**
for PR 12087 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12087#discussion_r58332876
--- Diff:
core/src/main/java/org/apache/spark/api/java/function/MapFunction.java ---
@@ -23,5 +23,5 @@
* Base interface for a map function used in
70 matches
Mail list logo
