Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12781
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218651842
Let's have a follow-up prs to make the following changes:
1. Make the command use those new helper functions added in DDLUtils.
2. Add tests for new keywords added
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218651713
Thanks. I am going to merge this to master and branch 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218626664
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218626668
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218626523
**[Test build #58420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58420/consoleFull)**
for PR 12781 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62944525
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE identifier
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62943939
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE identifier
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218611943
**[Test build #58420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58420/consoleFull)**
for PR 12781 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218611379
yea, build was broken
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218611391
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218521841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218521836
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218521788
**[Test build #58381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58381/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218513526
**[Test build #58381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58381/consoleFull)**
for PR 12781 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218513031
The last build failure was a compilation failure in a file not even touched
by this PR. Trying again.
---
If your project is set up for it, you can reply to this
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218512783
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218491739
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218491737
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218491679
**[Test build #58374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58374/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218490375
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218490327
**[Test build #58372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58372/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218490368
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218480935
**[Test build #58372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58372/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218482458
**[Test build #58374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58374/consoleFull)**
for PR 12781 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218481165
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62860721
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62860157
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62859605
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218446072
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218446068
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218445851
**[Test build #58364 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58364/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218427752
**[Test build #58364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58364/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218420572
**[Test build #58360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58360/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218420614
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218420608
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218413667
**[Test build #58360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58360/consoleFull)**
for PR 12781 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218378569
I think we can merge this one first. There are some other places where the
new DDL utility methods can be used to simplify code. I can fix them altogether
in
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218350899
#13025 is merged, are you going to update this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218168663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218170575
Part of the changes can be simplified using DDL utility methods introduced
in #13025.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218168661
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218168360
**[Test build #58233 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58233/consoleFull)**
for PR 12781 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62670600
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218143319
**[Test build #58233 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58233/consoleFull)**
for PR 12781 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-218142831
Updated test suite by normalizing `CatalogTable`s before comparing them.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62271545
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62177492
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-217105308
LGTM except the weird test-should-fail issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62162145
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -452,3 +455,241 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62161666
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62157923
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62079732
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62079118
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -452,3 +455,241 @@ case class ShowTablePropertiesCommand(table:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62078936
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -452,3 +455,241 @@ case class ShowTablePropertiesCommand(table:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r62076855
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE identifier
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216832273
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216832277
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216832102
**[Test build #57748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57748/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216815801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216815800
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216815628
**[Test build #57748 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57748/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216815437
**[Test build #57737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57737/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216809578
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216809580
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216809570
**[Test build #57744 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57744/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216808813
**[Test build #57744 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57744/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216779222
**[Test build #57737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57737/consoleFull)**
for PR 12781 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61867613
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216473295
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216473292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216473141
**[Test build #57610 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57610/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-216458438
**[Test build #57610 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57610/consoleFull)**
for PR 12781 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61846025
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -389,3 +392,238 @@ case class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61845886
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -389,3 +392,238 @@ case class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61779292
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -389,3 +392,238 @@ case class ShowTablePropertiesCommand(table:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61779220
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -389,3 +392,238 @@ case class ShowTablePropertiesCommand(table:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61772980
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,7 +45,9 @@ statement
| ALTER DATABASE identifier
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215915152
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215915151
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215915012
**[Test build #57378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57378/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215904092
**[Test build #57378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57378/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215849489
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215849493
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215849300
**[Test build #57349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57349/consoleFull)**
for PR 12781 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215848538
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215848535
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215848356
**[Test build #57348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57348/consoleFull)**
for PR 12781 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215830473
**[Test build #57349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57349/consoleFull)**
for PR 12781 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12781#discussion_r61619036
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -117,101 +112,3 @@ case class ExplainCommand(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12781#issuecomment-215829269
**[Test build #57348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57348/consoleFull)**
for PR 12781 at commit
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/12781
[SPARK-14346] SHOW CREATE TABLE for data source tables
## What changes were proposed in this pull request?
This PR adds native `SHOW CREATE TABLE` DDL command for data source tables.
92 matches
Mail list logo
