[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12846 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216713219 LGTM merging into master 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216395832 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216395836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216395684 **[Test build #57565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57565/consoleFull)** for PR 12846 at commit [`40f280a`](https://g

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216389301 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216389298 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216389178 **[Test build #57562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57562/consoleFull)** for PR 12846 at commit [`5a25075`](https://g

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216382976 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216382973 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216382775 **[Test build #57558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57558/consoleFull)** for PR 12846 at commit [`5f75242`](https://g

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216382062 **[Test build #57565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57565/consoleFull)** for PR 12846 at commit [`40f280a`](https://gi

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216382056 Fixed 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216380720 Just a minor thing, otherwise looks ok to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61813606 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -717,12 +717,11 @@ private[sql] class SQLConf extends Serializable with

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216376049 @vanzin how's it looking now ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216375370 **[Test build #57562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57562/consoleFull)** for PR 12846 at commit [`5a25075`](https://gi

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61809842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable with C

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61808094 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable wit

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61806604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable wit

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61804511 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable with C

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61803861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable wit

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216362685 **[Test build #57558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57558/consoleFull)** for PR 12846 at commit [`5f75242`](https://gi

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61800418 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable with C

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61800231 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala --- @@ -86,6 +86,10 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new SQL

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216352860 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216352861 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216352688 **[Test build #57548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57548/consoleFull)** for PR 12846 at commit [`7d9506a`](https://g

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216335225 **[Test build #57548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57548/consoleFull)** for PR 12846 at commit [`7d9506a`](https://gi

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216334279 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216334270 **[Test build #57546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57546/consoleFull)** for PR 12846 at commit [`08cea82`](https://g

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216334280 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216333989 **[Test build #57546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57546/consoleFull)** for PR 12846 at commit [`08cea82`](https://gi

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12846#issuecomment-216333816 cc: @vanzin @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14422][SQL] Improve handling of optiona...

2016-05-02 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/12846 [SPARK-14422][SQL] Improve handling of optional configs in SQLConf ## What changes were proposed in this pull request? Create a new API for handling Optional Configs in SQLConf. Right now