Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214939215
@liancheng Thank you very much Lian !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214938170
@dilipbiswal Great! LGTM now, I'm merging this one to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214876293
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214876307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214876009
**[Test build #57014 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57014/consoleFull)**
for PR 1 at commit
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214847459
@liancheng Hi Lian, i just pushed my branch which has the new test case for
your reference. It also has all your comments addressed :-)
---
If your project is set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214846747
**[Test build #57014 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57014/consoleFull)**
for PR 1 at commit
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214815027
@liancheng I had all the comments addressed and had left the tests running
last night was about to push today :-). Anyways thanks !! I will take a look at
your PR.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214803024
Hi @dilipbiswal, we did a bunch of major refactoring on the master branch,
and it's pretty close to 2.0 code freeze, so I took it over based on your
version and
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61027608
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +134,105 @@ class HiveCommandSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61011875
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -424,7 +424,7 @@ private[sql] object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61006959
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -424,7 +424,7 @@ private[sql] object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61004951
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61004685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61003756
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -277,9 +277,18 @@ class InMemoryCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60937575
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -36,12 +38,22 @@ class HiveCommandSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60937498
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -17,11 +17,13 @@
package
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60934317
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -424,7 +424,7 @@ private[sql] object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60934120
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60931135
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +134,105 @@ class HiveCommandSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60930580
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +134,105 @@ class HiveCommandSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60928725
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60927623
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60927757
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60927505
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60927399
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60926964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60926196
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60925953
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60923441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -277,9 +277,18 @@ class InMemoryCatalog extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60923122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -427,13 +427,18 @@ class SessionCatalog(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60923039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -427,13 +427,18 @@ class SessionCatalog(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r60922965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -277,9 +277,18 @@ class InMemoryCatalog extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210346927
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210346924
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210346717
**[Test build #55905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55905/consoleFull)**
for PR 1 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210317592
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210317598
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210317168
**[Test build #55901 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55901/consoleFull)**
for PR 1 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210304187
**[Test build #55905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55905/consoleFull)**
for PR 1 at commit
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210294481
@andrewor14 Thank you for a detailed review. I have implemented your
comments. A few points/questions.
1) Currently InMemoryCatalog does not make use of
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210292905
**[Test build #55901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55901/consoleFull)**
for PR 1 at commit
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59791626
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59790218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59781546
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59688027
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -404,6 +404,28 @@ private[hive] class HiveClientImpl(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -409,6 +409,25 @@ class SessionCatalog(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687495
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687465
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687220
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59686964
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59686977
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59675036
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -409,6 +409,25 @@ class SessionCatalog(
}
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-209673821
@dilipbiswal Thanks for working on this. I think it looks pretty good
overall. The existing API for show partitions is a little too tied to Hive so I
suggested an
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636620
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636516
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636373
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59636244
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635881
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59635435
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59634825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -409,6 +409,25 @@ class SessionCatalog(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59633351
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -404,6 +404,28 @@ private[hive] class HiveClientImpl(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59631726
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand(
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-207148007
cc @yhuai @andrewor14 @hvanhovell Could you review this PR too? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206658923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206658922
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206658766
**[Test build #55169 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55169/consoleFull)**
for PR 1 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206636777
**[Test build #55169 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55169/consoleFull)**
for PR 1 at commit
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206636426
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206628150
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206628154
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206625736
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206625734
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206625534
Currently i throw an exception for data source tables as in my
understanding the
partition spec metadata is not available in the hive meta store. I saw a
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/1
[SPARK-14445][SQL] Support native execution of SHOW COLUMNS and SHOW
PARTITIONS
## What changes were proposed in this pull request?
This PR adds Native execution of SHOW COLUMNS and SHOW
82 matches
Mail list logo
