Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219533007
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219533005
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219532737
**[Test build #58652 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58652/consoleFull)**
for PR 12693 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219502753
**[Test build #58652 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58652/consoleFull)**
for PR 12693 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219501208
you should be able to trigger it too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219501152
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user taoli91 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-219357737
@andrewor14 Could you please schedule another test for me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user taoli91 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218642713
I can't repro the failure on my environment. It seems my changes on this
commit shouldn't change the logic of the Launcher part. Is it possible that
it's a random
Github user taoli91 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218080350
Well it's wired, I can't repro the test failure locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218073552
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218073550
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218073420
**[Test build #58206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58206/consoleFull)**
for PR 12693 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218061787
**[Test build #58206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58206/consoleFull)**
for PR 12693 at commit
Github user taoli91 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-218061073
@andrewor14 I've fixed the failure. Could you please try it again? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-217950689
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-217950676
**[Test build #58158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58158/consoleFull)**
for PR 12693 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-217950688
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-217949218
**[Test build #58158 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58158/consoleFull)**
for PR 12693 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-217947789
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r62049836
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -640,12 +640,14 @@ class CheckpointSuite extends TestSuiteBase
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r62049944
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala ---
@@ -63,6 +60,9 @@ class MapWithStateSuite extends SparkFunSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r62049664
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -202,33 +202,37 @@ class EventLoggingListenerSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r62049286
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user taoli91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61987150
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -202,33 +202,37 @@ class EventLoggingListenerSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61987018
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -640,12 +640,14 @@ class CheckpointSuite extends
Github user taoli91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61986122
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61870506
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -202,33 +202,37 @@ class EventLoggingListenerSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61870401
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user taoli91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61841934
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61047794
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala ---
@@ -39,18 +39,15 @@ class MapWithStateSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61047763
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala ---
@@ -39,18 +39,15 @@ class MapWithStateSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61045778
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -644,8 +644,10 @@ class CheckpointSuite extends TestSuiteBase with
Github user taoli91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61045541
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -644,8 +644,10 @@ class CheckpointSuite extends TestSuiteBase
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61045196
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user taoli91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61044982
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-214664324
This cleanup looks generally good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61044679
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -644,8 +644,10 @@ class CheckpointSuite extends TestSuiteBase with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61044574
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/MapWithStateSuite.scala ---
@@ -64,6 +61,9 @@ class MapWithStateSuite extends SparkFunSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12693#discussion_r61044252
--- Diff:
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
@@ -243,7 +243,16 @@ private[spark] object ReliableCheckpointRDD extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12693#issuecomment-214659967
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user taoli91 opened a pull request:
https://github.com/apache/spark/pull/12693
[SPARK-14914] Fix Resource not closed after using, mostly for unit tests
## What changes were proposed in this pull request?
Close `FileStream`s, `ZipFile`s etc to release the resources after
41 matches
Mail list logo