Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222603352
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222603353
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222603171
**[Test build #59635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59635/consoleFull)**
for PR 13270 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222592978
**[Test build #59635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59635/consoleFull)**
for PR 13270 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222592244
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222592243
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222592234
**[Test build #59632 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59632/consoleFull)**
for PR 13270 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-222591642
**[Test build #59632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59632/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r65123201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -212,11 +212,46 @@ class SessionCatalog(
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64922718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -212,11 +212,46 @@ class SessionCatalog(
* If
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221756444
cc @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221754953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221754951
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221754832
**[Test build #59313 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59313/consoleFull)**
for PR 13270 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221753531
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221753528
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221753409
**[Test build #59311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59311/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64674180
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -28,11 +28,11 @@ class ShowCreateTableSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221742860
**[Test build #59313 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59313/consoleFull)**
for PR 13270 at commit
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221741745
@liancheng Thanks for the explanation!! It is safer this way. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221741286
**[Test build #59311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59311/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221739839
@xwu0226 For your [last comment][1] in your PR, I also realized that we are
not really using `CatalogTable.storage.locationUri` for data source tables
while doing
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221738175
@liancheng I see. Thank you!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221736990
@xwu0226 No we shouldn't have problem with Hive compatible tables now since
we only add the placeholder location URI when `table.storage.locationUri` is
empty (see
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221737110
@xwu0226 I should probably add a comment to explain the
`locationUri.isEmpty` thing since it's not quite intuitive.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221726486
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221726339
**[Test build #59295 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59295/consoleFull)**
for PR 13270 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221726488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221722759
@liancheng Thanks! I see what you mean for the code you handle the hive
compatible tables. This will handle the table lookup time.. But for [creating
table
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221715803
@xwu0226 Thanks. Handled Hive compatible tables [here][1]. `CatalogTable`
should be implementation agnostic, so it's infeasible to add a Hive specific
flag to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221710446
**[Test build #59295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59295/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64645557
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -68,7 +69,8 @@ private[spark] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221456715
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221456714
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221456607
**[Test build #59246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59246/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64503026
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -385,7 +385,10 @@ object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221448188
**[Test build #59246 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59246/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64500677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64500584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -385,7 +385,10 @@ object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64500603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221428304
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221428305
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221428174
**[Test build #59224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59224/consoleFull)**
for PR 13270 at commit
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64488208
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -385,7 +385,10 @@ object
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64485252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221415230
**[Test build #59224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59224/consoleFull)**
for PR 13270 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64482317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64327851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog(
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64318562
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221144781
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221144779
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221144664
**[Test build #59169 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59169/consoleFull)**
for PR 13270 at commit
Github user xwu0226 commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221137330
@liancheng sure. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221137189
@xwu0226 Would you please help review this one? It's based on our
discussion in your PR (#13120). The benefit of this version is that it avoids
the bad case
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221136564
**[Test build #59169 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59169/consoleFull)**
for PR 13270 at commit
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13270
[SPARK-15269][SQL] Removes unexpected empty table directories created while
creating external Spark SQL data sourcet tables.
This PR is an alternative to #13120 authored by @xwu0226.
##
56 matches
Mail list logo
