Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13269
https://github.com/apache/spark/pull/13402 is merged, and I have one more
PR to send.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13269
Are we going to break this PR to multiple smaller PRs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-52647
As we discussed offline, this PR also enables case insensitive encoder
resolution. Would be nice to add a test case for it. Basically something like
this:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r64940498
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -191,6 +189,26 @@ case class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-222041209
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-222041212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-222041073
**[Test build #59435 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59435/consoleFull)**
for PR 13269 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r64842044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -449,152 +449,151 @@ object ScalaReflection extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-222030468
**[Test build #59435 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59435/consoleFull)**
for PR 13269 at commit
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/13269#discussion_r64617059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala ---
@@ -42,17 +42,9 @@ class KeyValueGroupedDataset[K, V] private[sql](
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221158097
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221158098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221157983
**[Test build #59167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59167/consoleFull)**
for PR 13269 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221132593
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221132582
**[Test build #59165 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59165/consoleFull)**
for PR 13269 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221132596
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221132316
**[Test build #59167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59167/consoleFull)**
for PR 13269 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221131554
cc @marmbrus @liancheng @yhuai @clockfly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-221131551
**[Test build #59165 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59165/consoleFull)**
for PR 13269 at commit
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/13269
[SPARK-15494][SQL] encoder code cleanup
## What changes were proposed in this pull request?
Our encoder framework has been evolved a lot, this PR tries to clean up the
code to make it
20 matches
Mail list logo