Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57549839
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57082932
@liancheng I tried `export` and it worked. Thanks for the suggestion.
Also modified permission of `stop-thriftserver.sh`.
---
If your project is set up for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57083074
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57085586
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/176/consoleFull)
for PR 2509 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57085803
After updating my local repo, I found that `stop-thriftserver.sh` is still
not executable. Make sure to `git add` this file after `chmod +x`. This is the
only pending
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57089022
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/176/consoleFull)**
after a configured wait of `120m`.
---
If your project
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57097696
eh...I cloned the repository on another laptop and found it's executable,
as shown in top-left corner of
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57108375
Ah, sorry, my fault. Then this LGTM, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57115385
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57115522
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20958/consoleFull)
for PR 2509 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57119166
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57119163
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20958/consoleFull)
for PR 2509 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18122666
--- Diff: sbin/stop-thriftserver.sh ---
@@ -0,0 +1,25 @@
+#!/usr/bin/env bash
--- End diff --
This file should be executable, please `chmod
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18122679
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -320,6 +320,10 @@ object SparkSubmit {
} catch {
case e:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18122728
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-57047019
Thanks for working on this! I tested this PR locally and it works fine. But
there are still some minor issues pending to be resolved, please refer to the
comments for
Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18123634
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command,
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18126738
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18126747
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-56779230
@liancheng - can you take a look at this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18018270
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18018267
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -320,6 +320,10 @@ object SparkSubmit {
} catch {
case e:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18018268
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log $log
echo starting $command, logging to
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-56784684
Generally this is a good idea. But it would be better to make
`spark-daemon.sh` more general, rather than making `HiveThriftServer2` a
special case.
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-56814057
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20807/consoleFull)
for PR 2509 at commit
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-56818354
@liancheng As you said, I put spark-submit as an option to achieve
generalization and use source(dot) instead of `exec` to make `SUBMISSION_OPTS`
and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-56825846
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20807/consoleFull)
for PR 2509 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2509#issuecomment-56825854
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
29 matches
Mail list logo
