Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72800036
Thanks Jeremy! Good clean patch!
On Feb 3, 2015 10:45 PM, "UCB AMPLab" wrote:
> Test PASSed.
> Refer to this link for build results (access rights to CI serv
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72799033
[Test build #26725 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26725/consoleFull)
for PR 3803 at commit
[`b676534`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72799040
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r24064747
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -671,7 +674,11 @@ class SparkContext(config: SparkConf) extends Logging
with Exec
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r24064149
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -671,7 +674,11 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAll
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72793369
[Test build #26725 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26725/consoleFull)
for PR 3803 at commit
[`b676534`](https://githu
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r24063473
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -671,7 +674,11 @@ class SparkContext(config: SparkConf) extends Logging
with Exec
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72793042
Thanks for the detailed look @tdas! Think I addressed both nits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r24063184
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala
---
@@ -210,6 +211,20 @@ class JavaStreamingContext(val
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72785812
LGTM. Just two minor nits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r24061094
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala
---
@@ -210,6 +211,20 @@ class JavaStreamingContext(val ssc: S
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r24061014
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -671,7 +674,11 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAll
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72761356
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72761349
[Test build #26680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26680/consoleFull)
for PR 3803 at commit
[`eba925c`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72750244
[Test build #26680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26680/consoleFull)
for PR 3803 at commit
[`eba925c`](https://githu
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72612066
The Python parts look good to me, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23981497
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -361,6 +363,25 @@ class StreamingContext private[streaming] (
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23980723
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -361,6 +363,25 @@ class StreamingContext private[streaming] (
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23980541
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -361,6 +363,25 @@ class StreamingContext private[streaming] (
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23966691
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -657,6 +657,10 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAll
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23966451
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala
---
@@ -210,6 +211,18 @@ class JavaStreamingContext(val ssc: S
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23966407
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -361,6 +363,25 @@ class StreamingContext private[streaming] (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72394487
[Test build #26476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26476/consoleFull)
for PR 3803 at commit
[`14bca9a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72394489
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72391820
[Test build #26476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26476/consoleFull)
for PR 3803 at commit
[`14bca9a`](https://githu
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72391803
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23886182
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -657,6 +657,10 @@ class SparkContext(config: SparkConf) extends Logging
with Exec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72302378
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72302376
[Test build #26449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26449/consoleFull)
for PR 3803 at commit
[`14bca9a`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72300666
[Test build #26449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26449/consoleFull)
for PR 3803 at commit
[`14bca9a`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72292766
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72292757
[Test build #26435 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26435/consoleFull)
for PR 3803 at commit
[`9a3715a`](https://gith
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23881983
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -657,6 +657,10 @@ class SparkContext(config: SparkConf) extends Logging
with Execut
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23881764
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -657,6 +657,10 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAll
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72291526
@tdas pointed out that these new methods should be marked as
`@Experimental`, since `binaryRecords` is experimental.
---
If your project is set up for it, you can repl
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23881511
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
---
@@ -237,7 +240,14 @@ class FileInputDStream[K: ClassTag, V
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23881470
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala
---
@@ -210,6 +210,18 @@ class JavaStreamingContext(val s
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23881453
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -372,6 +392,33 @@ class StreamingContext private[streaming] (
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r23881377
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -671,7 +675,10 @@ class SparkContext(config: SparkConf) extends Logging
with Execut
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72285668
@JoshRosen I finished the refactored tests and added better handling of the
`getBytes` based on your suggestion.
---
If your project is set up for it, you can reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-72286100
[Test build #26435 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26435/consoleFull)
for PR 3803 at commit
[`9a3715a`](https://githu
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-71929328
Great thanks @JoshRosen will finish this up ASAP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-71928829
/bump, now that my test-refactoring PR has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22776172
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -373,6 +393,25 @@ class StreamingContext private[streaming] (
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22776187
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -233,6 +236,47 @@ class InputStreamsSuite extends TestSuiteBase
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-68803760
[Test build #25066 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25066/consoleFull)
for PR 3803 at commit
[`317b6d1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-68803767
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-68797365
Thanks for the review! I'll wait for @JoshRosen 's PR to merge and then
update the test here. And will wait for your thoughts on the `getBytes` issue.
Otherwise, I th
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22496437
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -373,6 +393,25 @@ class StreamingContext private[streaming] (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-68795630
[Test build #25066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25066/consoleFull)
for PR 3803 at commit
[`317b6d1`](https://githu
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22495425
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -233,6 +236,47 @@ class InputStreamsSuite extends TestSuiteBa
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22495402
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -233,6 +236,47 @@ class InputStreamsSuite extends TestSuiteBa
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3803#issuecomment-68753824
The Python part look good to me, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22287997
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -373,6 +393,25 @@ class StreamingContext private[streaming] (
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22287961
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -373,6 +393,25 @@ class StreamingContext private[streaming] (
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22287941
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -373,6 +393,25 @@ class StreamingContext private[streaming] (
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22287887
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -233,6 +236,47 @@ class InputStreamsSuite extends TestSuiteBase
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3803#discussion_r22287877
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -233,6 +236,47 @@ class InputStreamsSuite extends TestSuiteBase
59 matches
Mail list logo
