Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r30769763
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/TaskMemoryManager.java ---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97912751
@tgravescs I've opened #5814 to try to fix the compiler warnings (and error
due to `Unsafe.setMemory`); it would be great if you could test out that commit
and see
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97902582
Java 6's output:
$ javap sun.misc.Unsafe | grep setMemory
public native void setMemory(long, long, byte);
So Spark is using an API that
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97905259
On a side note, if Spark supports java 6, why are all jenkins builds
running java 7?
---
If your project is set up for it, you can reply to this email and have your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97898375
I'm looking into this issue now; these warnings can't be suppressed via the
usual annotations mechanism; it requires a special compiler flag. Planning to
submit a
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97889088
not sure what your question is exactly, I think the last one is an error
instead of warning. I didn't specifying anything special in build command: mvn
-Pyarn
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97899617
Thanks, Also I should have specified, I'm running on a rhel6 box using jdlk6
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97883422
Did you have warning turned on into error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97915047
@vanzin There's an old JIRA for building w/ Java 6 on Jenkins; I've
re-opened it: https://issues.apache.org/jira/browse/SPARK-1437
---
If your project is set up for
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97828392
I'm not able to build after this went in. Any special requirements to
build this?
[info] Compiling 15 Java sources to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97311169
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97315253
[Test build #732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/732/consoleFull)
for PR 5725 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97340590
[Test build #31245 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31245/consoleFull)
for PR 5725 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97340658
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97341692
Ok merging in master. Let's make sure we address @marmbrus 's comments in
followup prs.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97340664
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97311160
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97311123
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97311194
[Test build #31245 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31245/consoleFull)
for PR 5725 at commit
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97511381
sup**[sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java,
line 133
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29300182
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -207,7 +210,23 @@ private[spark] class Executor(
// Run the
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29303890
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -30,6 +30,7 @@ private[spark] object SQLConf {
val DEFAULT_SIZE_IN_BYTES =
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97284000
[Test build #31202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31202/consoleFull)
for PR 5725 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97284005
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97284007
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97263417
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97263416
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97263384
**[Test build #31173 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31173/consoleFull)**
for PR 5725 at commit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301548
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -207,7 +210,23 @@ private[spark] class Executor(
// Run the
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29303752
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +283,49 @@ case class GeneratedAggregate(
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97274034
The most recent test failure looks like a possible double-free somewhere.
Here's what I saw when I ran that test locally:
```
[info] Test
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29303644
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -41,13 +42,15 @@ case class AggregateEvaluation(
*
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301471
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +283,49 @@ case class GeneratedAggregate(
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29303434
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +283,49 @@ case class GeneratedAggregate(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29295786
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/TaskMemoryManager.java ---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97246338
[Test build #31185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31185/consoleFull)
for PR 5725 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97246262
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301701
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97274734
As part of UnsafeRowConverter refactoring, I realized that I forgot to add
support for a whole bunch of primitives, including booleans. These are trivial
to add, so
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97280969
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97246248
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29300995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97272175
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97272176
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97272168
[Test build #31185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31185/consoleFull)
for PR 5725 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29303406
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +283,49 @@ case class GeneratedAggregate(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29304001
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -30,6 +30,7 @@ private[spark] object SQLConf {
val DEFAULT_SIZE_IN_BYTES
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97281092
[Test build #31202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31202/consoleFull)
for PR 5725 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301372
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -41,13 +42,15 @@ case class AggregateEvaluation(
*
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301391
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -207,7 +210,23 @@ private[spark] class Executor(
// Run the
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301384
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -41,13 +42,15 @@ case class AggregateEvaluation(
*
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29301331
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +283,49 @@ case class GeneratedAggregate(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97280950
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97281833
LGTM. There are some issues, but we can easily address them in followup PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29284519
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29287015
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29287008
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29287003
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29284614
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97203679
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97203637
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97203797
[Test build #31173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31173/consoleFull)
for PR 5725 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +284,49 @@ case class GeneratedAggregate(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221210
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221238
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221149
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221682
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29268634
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the Apache
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29269216
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java
---
@@ -0,0 +1,251 @@
+/*
+ *
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97156621
update: thought about it more. I don't think we need to worry about
contention at the moment, since our allocation unit is pretty large.
---
If your project is set up for
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97145397
When running with off-heap, one concern is proper cleanup of managed memory
when tasks fail or are cancelled. Given that we currently do not share managed
memory
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29269390
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +284,49 @@ case class GeneratedAggregate(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29267684
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -265,7 +284,49 @@ case class GeneratedAggregate(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29267305
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -0,0 +1,552 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29267226
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29267770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29269271
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-97152921
I think good memory allocator implementations usually have a thread local
cache to reduce contention. We can do the same thing too, can't we? The problem
with only
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29274142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29274312
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29273686
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29218943
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29218448
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java
---
@@ -0,0 +1,251 @@
+/*
+ *
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29218666
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java
---
@@ -0,0 +1,251 @@
+/*
+ *
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29218869
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29218879
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-96962860
[Test build #31113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31113/consoleFull)
for PR 5725 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29220143
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the Apache
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29220523
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221410
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221663
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -0,0 +1,552 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221599
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -0,0 +1,552 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29221679
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryManager.java ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-96968405
I went through and left some comments. Kudos - this is super well done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-96814367
[Test build #31069 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31069/consoleFull)
for PR 5725 at commit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5725#discussion_r29202027
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -0,0 +1,618 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-96888987
[Test build #31095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31095/consoleFull)
for PR 5725 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-96895948
[Test build #31101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31101/consoleFull)
for PR 5725 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5725#issuecomment-96910423
[Test build #31113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31113/consoleFull)
for PR 5725 at commit
1 - 100 of 112 matches
Mail list logo
