Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-115561728
Ok, I will close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen closed the pull request at:
https://github.com/apache/spark/pull/6515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114744788
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114745145
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114744960
cc @JoshRosen will this substantially increase build time due to maven?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114745108
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114792514
[Test build #35650 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35650/console)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114792548
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114745333
[Test build #35650 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35650/consoleFull)
for PR 6515 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-115018376
I've thought about this a bit and I'm not sure that ErrorProne offers us a
huge win unless it's run as part of every build. I think the advantage of
ErrorProne over
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114974061
The last test seemed to take only `152m`, which is around the average.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114956452
Run this check would take about ten minutes on my laptop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114630902
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114631306
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114631412
[Test build #35584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35584/consoleFull)
for PR 6515 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114636320
@yijieshen note that this doesn't merge cleanly with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114631322
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114718441
@andrewor14, thanks for retesting this. I would merge this ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114416807
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114722967
@andrewor14, the latest commit merge cleanly with master now, mind
reviewing it as well as triggering the test?
---
If your project is set up for it, you can reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-114666597
[Test build #35584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35584/console)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-11434
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-112411907
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111429204
Also note the `[UnnecessaryStaticImport] Using static imports for types is
unnecessary` conflict with a scaladoc walk around:
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111434507
/Users/yijie/code/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/BaseRow.java:143:
error: [TypeParameterUnusedInFormals] Declaring a type parameter that is
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111426953
Not sure if it was too strict to level up `EqualsHashCode: Classes that
override equals should also override hashCode.` from warning to error.
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-111434925
Perhaps it's time to reconsider whether we should level up all the
`warnings` to `error` ?
---
If your project is set up for it, you can reply to this email and have
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-109544645
@rxin, can you help me to review the latest commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-109255206
@JoshRosen , I've made error prone check inside `dev/lint-java` and also
put it into `dev/run-tests`.
Since error prone can only be hooked into `compile` and
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108936871
@aarondav, I've moved the callback.wait into `while (callback0.success ==
null callback0.failure == null) ` loops since it seems like just waiting for
either success
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108938615
@vanzin , it seems no variable to check
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108967544
@yijieshen sounds right; it's a test anyway, so adding a variable to check
there sounds like overkill.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108629717
[Test build #34124 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34124/consoleFull)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108628832
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108628815
@harishreedharan @vanzin @srowen maybe the change from #6600 will fail here
:)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108628806
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108652391
[Test build #34124 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34124/consoleFull)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108652418
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-108628724
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107870235
@rxin, just turned on all the mature checkers from warning into error in
the latest commit, implementing `lint` now.
---
If your project is set up for it, you can
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107279699
Thanks @yijieshen. Just tried this locally and worked. Can you change the
report level from warning to error, and fix the few instances of warnings? The
reason is I don't
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107280681
Since this is now guarded behind a special Maven profile, we should also
make sure to update the Jenkins build to run with this enabled. AFAIK the
Jenkins Maven
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107288251
@JoshRosen, since the profile is tightly coupled with `compile`
`test-compile` goals in maven, is it OK to run `mvn package` in
`bin/run-tests`? e.g. in `lint-java`?
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107287257
@rxin, in error prone, some checks are `on` by default, and others are
experimental and `off` by default. Each of the checks is considered with a
`Severity level`,
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107074328
Jenkins, retest this please.
On Saturday, May 30, 2015, Yijie Shen notificati...@github.com wrote:
How can I ask Jenkins to retest it?
â
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107085777
[Test build #33815 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33815/consoleFull)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107085786
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107077638
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107077751
[Test build #33815 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33815/consoleFull)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107077624
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107087027
@yijieshen how do I run this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107077167
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106993985
Test more Error bug patterns manually, work as expected.
However, after an error report, if no `mvn clean` called before next `mvn
package`, and not changing the
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106994629
Not that sure how lint-java works. If I understand correctly, in lint-java,
we should run error prone separately like what lint-scala does?
If so, seems not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106994189
Got it - as long as it is fine on Jenkins, I think it is OK. We can rely on
Jenkins to do this anyway.
One thing to add is lint-java file in /dev folder.
---
If
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106994699
Ah ok. So the only way to run this is to use mvn compile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107113240
@rxin, just add -Pep-tests when running mvn package
I've turned on warnings in the second commit since it's optional and I
assume run this deliberately would love
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106996096
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106997413
[Test build #33802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33802/consoleFull)
for PR 6515 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107010067
[Test build #33802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33802/consoleFull)
for PR 6515 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107010071
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106994994
I think so, would keep an eye on this and create lint-java if possible
later.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106997021
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106997001
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6515#discussion_r31380059
--- Diff: pom.xml ---
@@ -1226,7 +1226,16 @@
encodingUTF-8/encoding
maxmem1024m/maxmem
forktrue/fork
+
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6515#discussion_r31381670
--- Diff: pom.xml ---
@@ -1226,7 +1226,16 @@
encodingUTF-8/encoding
maxmem1024m/maxmem
forktrue/fork
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-107054378
How can I ask Jenkins to retest it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106990571
Jenkins, ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/6515
[SPARK-7938][BUILD]Use Google ErrorProne during Maven build of Spark
[Error Prone](http://errorprone.info) augment the compilerâs type
analysis and hooks into standard build, aiming at
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106990363
Thanks, @yijieshen. Have you tried running this locally and see what was
produced?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106991739
Thanks. Can you manually inject a bug into some Java code to see if it
reports that correctly?
If those are all the warnings, I'd just update the code to remove
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106990693
@rxin, I've tried locally, when compiler's warning are suppressed by
default, nothing error occurs. When I turned on the warnings, it only warns on
spurious wakeups
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106992110
@rxin, I have insert
[DeadException](http://errorprone.info/bugpattern/DeadException) `new
Exception()`which is considered as ERROR in error prone, it reports
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106992204
No need to test all of them. As long as one works ... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106990453
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/6515#issuecomment-106990886
@rxin:
/Users/yijie/code/spark/network/common/src/test/java/org/apache/spark/network/RequestTimeoutIntegrationSuite.java:114:
warning: [WaitNotInLoop]
76 matches
Mail list logo
