Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6911
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114285670
Merged into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114283557
[Test build #35480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35480/console)
for PR 6911 at commit
[`d68706f`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114283650
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114279661
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114279571
[Test build #35479 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35479/console)
for PR 6911 at commit
[`519f698`](https://github.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32986938
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -311,21 +310,23 @@ public double getDouble(int i) {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32979049
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(field
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114244708
[Test build #35480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35480/consoleFull)
for PR 6911 at commit
[`d68706f`](https://gith
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32977275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(fi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114243272
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114243182
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32976949
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(fi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114242049
[Test build #35479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35479/consoleFull)
for PR 6911 at commit
[`519f698`](https://gith
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32976895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(fi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114240454
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114240395
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32976252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(field
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32972763
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -311,21 +310,23 @@ public double getDouble(int i) {
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114226149
This looks good to me overall. I like the idea of storing the length in
the fixed-length values section alongside the pointer to the variable-length
data. I wonder w
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32972528
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java
---
@@ -142,14 +141,7 @@ public UnsafeRo
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32972053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(fi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32971644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -246,19 +262,33 @@ private class StringUnsa
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32971184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -246,19 +262,33 @@ private class StringUnsa
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113845961
[Test build #947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/947/console)
for PR 6911 at commit
[`180b49d`](https://github.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113838234
[Test build #947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/947/consoleFull)
for PR 6911 at commit
[`180b49d`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113737426
[Test build #943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/943/console)
for PR 6911 at commit
[`180b49d`](https://github.c
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113733769
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113733710
[Test build #35359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35359/console)
for PR 6911 at commit
[`180b49d`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113722728
[Test build #943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/943/consoleFull)
for PR 6911 at commit
[`180b49d`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113720790
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113720758
[Test build #35357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35357/console)
for PR 6911 at commit
[`22e4c0a`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113718122
[Test build #35359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35359/consoleFull)
for PR 6911 at commit
[`180b49d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113718007
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113718050
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113717256
The 2GB row limit isn't an issue since we already implicitly have that
limit in `UnsafeRowConverter`.
---
If your project is set up for it, you can reply to this emai
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113716875
[Test build #35357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35357/consoleFull)
for PR 6911 at commit
[`22e4c0a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113716854
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113716859
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113701807
[Test build #35346 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35346/console)
for PR 6911 at commit
[`6abfe93`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113701812
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113691829
[Test build #35346 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35346/consoleFull)
for PR 6911 at commit
[`6abfe93`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113691127
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113691084
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113680070
[Test build #35339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35339/console)
for PR 6911 at commit
[`447dea0`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113680080
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113675867
[Test build #35339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35339/consoleFull)
for PR 6911 at commit
[`447dea0`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113674579
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113674573
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/6911
[SPARK-8492] [SQL] support binaryType in UnsafeRow
Support BinaryType in UnsafeRow, just like StringType.
Also change the layout of StringType and BinaryType in UnsafeRow, by
combining offse
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-113674457
cc @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
51 matches
Mail list logo
