GitHub user yijieshen opened a pull request:
https://github.com/apache/spark/pull/7365
[SPARK-8935][WIP] Implement code generation for all casts
JIRA: https://issues.apache.org/jira/browse/SPARK-8935
You can merge this pull request into a Git repository by running:
$ git pull h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-120833494
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-120834801
Not ready to be reviewed, just want to trigger test first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-120835049
Jenkins, OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121070279
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121075404
@yijieshen Just want to mention that you can easily test it locally by:
```
$ buid/sbt
sbt> catalyst/test
sbt> sql/test
```
---
If your project is set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121075589
[Test build #1061 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1061/consoleFull)
for PR 7365 at commit
[`6c00e5a`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121077677
[Test build #1061 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1061/console)
for PR 7365 at commit
[`6c00e5a`](https://github
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34521956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,364 @@ case class Cast(child: Expression, dataTyp
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34521979
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,364 @@ case class Cast(child: Expression, dataTyp
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121135059
@davies , thanks for the tip, it's just what I need to check any
unconscious situations. :)
@davies @rxin, the pr is almost done for the current implementation, I
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34538094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,515 @@ case class Cast(child: Expression, da
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34538299
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,515 @@ case class Cast(child: Expression, da
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34538349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,515 @@ case class Cast(child: Expression, dataTyp
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121535054
`CodeHolder` is removed in the latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-121694729
@cloud-fan Take a look at this also if you have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34743636
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -371,7 +371,7 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34945753
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -422,47 +422,487 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34945762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -422,47 +422,487 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34945784
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -422,47 +422,487 @@ case class Cast(child: Expression, da
Github user yijieshen commented on the pull request:
https://github.com/apache/spark/pull/7365#issuecomment-122515973
@cloud-fan , thanks for reviewing, will resolve the comment soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user yijieshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34948044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -422,47 +422,487 @@ case class Cast(child: Expression, da
22 matches
Mail list logo
