[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2015-11-23 Thread apatrida
Github user apatrida commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-158929639 So... how does this work then? because whenever we deploy a conflicting library with Spark over EMR we crash Spark. (i.e. newer Jackson) ... therefore this works how?

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39929991 Thanks - merged with some minor changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/217#discussion_r11416985 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -310,11 +314,14 @@ private[spark] class Executor( val classUri = conf.ge

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/217#discussion_r11416979 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -34,13 +34,14 @@ object TestUtils { * Note: if this is used during class loader t

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39890433 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13900/ --- If your project

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39890430 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39884606 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39884584 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39825020 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13889/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39825018 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39821357 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39821371 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39820352 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39820353 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13888/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39820263 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39820273 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/217#discussion_r11378988 --- Diff: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala --- @@ -26,21 +26,28 @@ import org.apache.hadoop.fs.{FileSystem, Path}

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/217#discussion_r11378778 --- Diff: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala --- @@ -26,21 +26,28 @@ import org.apache.hadoop.fs.{FileSystem, Path}

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/217#discussion_r11378555 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -42,6 +42,20 @@ object TestUtils { } /** + * Create a jar that

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-08 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/217#discussion_r11378521 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -95,4 +109,22 @@ object TestUtils { result.renameTo(out) out }

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39815229 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13881/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39815228 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39815143 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39815148 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-04 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39630440 On Friday, April 4, 2014, Patrick Wendell wrote: > 1) What do you mean "not be in the Spark project"? Do you mean the package > name associated with the class?

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39630090 1) What do you mean "not be in the Spark project"? Do you mean the package name associated with the class? The tool now just creates classes in the default (i.e. no) pack

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-04 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39628786 That code looks useful :) Just a heads up though its probably going to be a bit ugly since: 1) I need the classes to not be in the Spark project its self (so I'll

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39626705 I don't know for sure, but ya I'd guess `.class` files might be an issue. @holdenk would it be possible to re-write the tests using this utility here https://github.com/a

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-04-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-39594472 @pwendell are we allowed to have JARs and .class files in our repo, even for testing? If not we'll need to modify the tests here to build them. --- If your project is set

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-03-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-38881854 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: Spark 939 allow user jars to take precedence o...

2014-03-25 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/217#issuecomment-38604429 Removing WIP tag, it should be good to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project